Subject: Re: BUG #15565: truncate bug with tables which have temp table
 inherited
References: <15565-ce67a48d0244436a@postgresql.org>
 <0285c6d1-2d11-2f2c-6fae-d4575cdc3c7b@lab.ntt.co.jp>
 <CAKJS1f_pDqUvyWeiUufRUJ2nUHvD4-rYvjHr2ZiPLsvQ6UQkUg@mail.gmail.com>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Message-ID: <496ce153-fb3b-c8b1-65bd-8a376a88dbc2@lab.ntt.co.jp>
Date: Tue, 25 Dec 2018 17:03:37 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: 
 <CAKJS1f_pDqUvyWeiUufRUJ2nUHvD4-rYvjHr2ZiPLsvQ6UQkUg@mail.gmail.com>
Content-Type: multipart/mixed;
 boundary="------------EDCC41FF1EE9F6D5CA49CA8C"
Content-Language: en-US
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: digoal@126.com, pgsql-bugs@lists.postgresql.org,
        PG Bug reporting form <noreply@postgresql.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------EDCC41FF1EE9F6D5CA49CA8C
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 2018/12/25 16:27, David Rowley wrote:
> On Tue, 25 Dec 2018 at 13:50, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> I'm not sure if the error being shown is a bug, but maybe we could remove
>> the error by making truncate do the same thing as select/update/delete,
>> that is, ignore child tables that are temporary of tables of other
>> sessions.  Attached patch to do that.
> 
> I glanced at this and was confused at where "newrelation" comes from
> and also the single parameter heap_close(). It does not look like it
> would compile.

Sorry, that was pretty negligent of me.  Here's the updated patch.

Thanks,
Amit


--------------EDCC41FF1EE9F6D5CA49CA8C
Content-Type: text/plain; charset=UTF-8;
 name="truncate-ignore-other-session-temp-children-v2.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="truncate-ignore-other-session-temp-children-v2.patch"

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2Jh
Y2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXggNTg4YzFlYzUzNi4uYmFkNjk4YzEy
NSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKKysrIGIv
c3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKQEAgLTE0MTYsNiArMTQxNiwyMCBA
QCBFeGVjdXRlVHJ1bmNhdGUoVHJ1bmNhdGVTdG10ICpzdG10KQogCiAJCQkJLyogZmluZF9h
bGxfaW5oZXJpdG9ycyBhbHJlYWR5IGdvdCBsb2NrICovCiAJCQkJcmVsID0gaGVhcF9vcGVu
KGNoaWxkcmVsaWQsIE5vTG9jayk7CisKKwkJCQkvKgorCQkJCSAqIEl0IGlzIHBvc3NpYmxl
IHRoYXQgdGhlIHBhcmVudCB0YWJsZSBoYXMgY2hpbGRyZW4gdGhhdCBhcmUKKwkJCQkgKiB0
ZW1wIHRhYmxlcyBvZiBvdGhlciBiYWNrZW5kcy4gIFdlIGNhbm5vdCBzYWZlbHkgYWNjZXNz
CisJCQkJICogc3VjaCB0YWJsZXMgKGJlY2F1c2Ugb2YgYnVmZmVyaW5nIGlzc3VlcyksIGFu
ZCB0aGUgYmVzdAorCQkJCSAqIHRoaW5nIHRvIGRvIHNlZW1zIHRvIGJlIHRvIHNpbGVudGx5
IGlnbm9yZSB0aGVtLiAgTm8gcG9pbnQKKwkJCQkgKiBpbiBob2xkaW5nIG9udG8gdGhlIGxv
Y2sgZWl0aGVyLgorCQkJCSAqLworCQkJCWlmIChSRUxBVElPTl9JU19PVEhFUl9URU1QKHJl
bCkpCisJCQkJeworCQkJCQloZWFwX2Nsb3NlKHJlbCwgQWNjZXNzRXhjbHVzaXZlTG9jayk7
CisJCQkJCWNvbnRpbnVlOworCQkJCX0KKwogCQkJCXRydW5jYXRlX2NoZWNrX3JlbChSZWxh
dGlvbkdldFJlbGlkKHJlbCksIHJlbC0+cmRfcmVsKTsKIAkJCQl0cnVuY2F0ZV9jaGVja19h
Y3Rpdml0eShyZWwpOwogCg==
--------------EDCC41FF1EE9F6D5CA49CA8C--