From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: Aleksandr Parfenov <a.parfenov@postgrespro.ru>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: PostgreSQL crashes with SIGSEGV
In-reply-to: 
 <CAH2-WzmAKo=KoBJrTB0M7UUnM-L=Gycs_=iT8+Z2YohmxEbFWg@mail.gmail.com>
References: <1512661638.9720.34.camel@oopsware.de>
 <CAH2-WzmxBVYUrqtmOyP9jB1j2ZO7xTpPx65ZKTO362Qg0MRgxA@mail.gmail.com>
 <151608914608.25640.2144132915573008595.pgcf@coridan.postgresql.org>
 <14267.1516216998@sss.pgh.pa.us>
 <CAH2-WzmAKo=KoBJrTB0M7UUnM-L=Gycs_=iT8+Z2YohmxEbFWg@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Wed, 17 Jan 2018 12:19:50 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4976.1516221082.1@sss.pgh.pa.us>
Date: Wed, 17 Jan 2018 15:31:22 -0500
Message-ID: <4977.1516221082@sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Jan 17, 2018 at 11:23 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I don't feel particularly comfortable committing a patch that
>> was clearly labeled as a rushed draft by its author.
>> Peter, where do you stand on this work?

> I would like to take another pass over
> WIP-tuplesort-memcontext-fix.patch, to be on the safe side. I'm
> currently up to my neck in parallel CREATE INDEX work, though, and
> would prefer to avoid context switching for a week or two, if
> possible. How time sensitive do you think this is?

Probably not very.  It'd be nice to have it done by the next minor
releases, ie before 5-Feb ... but given that these bugs are years
old, missing that deadline would not be catastrophic.

> I'm not sure whether or not we should also apply this
> still-to-be-written 9.5 patch to 9.4 and 9.3, since those versions
> don't have grouping sets, and so cannot crash. ISTM that we should
> leave them alone, since tuplesort has had this problem forever.

+1.  If the problem isn't known to be reproducible in those branches,
the risk of adding new bugs seems to outweigh any benefit.

			regards, tom lane