Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: BUG #17212: pg_amcheck fails on checking temporary relations
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: <71339EFC-3060-4775-B9C6-D39E02752A2F@enterprisedb.com>
Date: Mon, 4 Oct 2021 16:34:53 -0700
Cc: Alexander Lakhin <exclusion@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Robert Haas <robertmhaas@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4AA50C05-F3AE-4441-B9D8-81EC72D6ACA4@enterprisedb.com>
References: <17212-34dd4a1d6bba98bf@postgresql.org>
 <CAH2-Wz=bw-Uk2yoOq7yevC9hyMGgZ2Ud34nd9YJJPXJ3pkVcrw@mail.gmail.com>
 <E85855BD-C063-4B24-9EAA-02DECC8F42B9@enterprisedb.com>
 <E283B45F-5745-49C9-BBC7-99876E2FABD1@enterprisedb.com>
 <f42de8ec-f219-0922-93b3-37a72bba1feb@gmail.com>
 <28B36E41-1E8F-4DC1-A924-711621BA4972@enterprisedb.com>
 <CAH2-Wz=v4py=c79J7wpdVmQMkd8rO7gj5Ur5Dp4E0y7aQUz6cg@mail.gmail.com>
 <386F66EE-DEFD-42EA-9DB2-102BF3414669@enterprisedb.com>
 <CAH2-Wzkwb+1GSONMrXByHhgkzD-N59A_kFcvsoA_+M9cNNHm5g@mail.gmail.com>
 <71339EFC-3060-4775-B9C6-D39E02752A2F@enterprisedb.com>
To: Peter Geoghegan <pg@bowt.ie>
Archived-At: 
 <https://www.postgresql.org/message-id/4AA50C05-F3AE-4441-B9D8-81EC72D6ACA4%40enterprisedb.com>
Precedence: bulk


> On Oct 4, 2021, at 4:28 PM, Mark Dilger <mark.dilger@enterprisedb.com> =
wrote:
>=20
> pg_amcheck -i idx1 -i idx2 -i idx3

I forgot to mention:  There's a continuum between `pg_amcheck -a` which =
checks everything in all databases of the cluster, and `pg_amcheck -i =
just_one_index`.  There are any number of combinations of object names, =
schema names, database names, and patterns over the same, which select =
anything from an empty set to a huge set of things to check.  I'm trying =
to keep the behavior the same for all of those, and that's why I'm =
trying to avoid having `pg_amcheck -a` silently skip indexes that are =
unavailable for checking while having `pg_amcheck -i just_one_index` =
give a report about the index.  I wouldn't know where to draw the line =
between reporting the issue and not, and I doubt whatever line I choose =
will be intuitive to users.

=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company