Message-ID: <5038b33a6dc639009f4b3d43fa6ae0c5ba9e04f7.camel@j-davis.com>
Subject: CREATE DATABASE copies datlocale even if datlocprovider differs
From: Jeff Davis <pgsql@j-davis.com>
To: pgsql-bugs@postgresql.org
Date: Tue, 29 Jul 2025 16:33:45 -0700
Content-Type: multipart/mixed; boundary="=-BkB/ZCA7N6Pz3BV8UX0S"
User-Agent: Evolution 3.52.3-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/5038b33a6dc639009f4b3d43fa6ae0c5ba9e04f7.camel%40j-davis.com>
Precedence: bulk

--=-BkB/ZCA7N6Pz3BV8UX0S
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


  initdb -D data --locale-provider=3Dbuiltin --builtin-locale=3D'C.UTF-8'
  CREATE DATABASE d2 TEMPLATE template0 LOCALE_PROVIDER 'icu';
  WARNING:  ICU locale "C.UTF-8" has unknown language "c"
  HINT:  To disable ICU locale validation, set the parameter
"icu_validation_level" to "disabled".
  CREATE DATABASE

  SELECT datlocale FROM pg_database WHERE datname=3D'd2';
   datlocale=20
  -----------
   C.UTF-8
  (1 row)

It's only an issue if template0 is builtin and the new database is icu.
libc doesn't use the datlocale field, and the builtin provider will
reject ICU locale names. ICU is less strict for historical reasons.

I think that should throw an error rather than trying to reinterpret
datlocale for the new provider. Patch attached, intended to backport
through 17.

In theory that could break existing CREATE DATABASE commands, but given
that it's such a narrow case I don't think it's a major problem. We
could mitigate it by patching only 18+. Thoughts?

Regards,
	Jeff Davis


--=-BkB/ZCA7N6Pz3BV8UX0S
Content-Disposition: attachment;
	filename*0=0001-Do-not-copy-datlocale-unless-datlocprovider-matches.patc;
	filename*1=h
Content-Type: text/x-patch;
	name="0001-Do-not-copy-datlocale-unless-datlocprovider-matches.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA3NjE3ZjE1NGI0YzEwZTE4MWVlZWI5NDlkNzczYjVmMWVlZTY3OTU0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU
dWUsIDI5IEp1bCAyMDI1IDE2OjExOjMyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRG8gbm90IGNv
cHkgZGF0bG9jYWxlIHVubGVzcyBkYXRsb2Nwcm92aWRlciBtYXRjaGVzLgoKRHVyaW5nIENSRUFU
RSBEQVRBQkFTRSwgaWYgY2hhbmdpbmcgdGhlIGxvY2FsZSBwcm92aWRlciwgcmVxdWlyZSB0aGF0
CmEgbmV3IGxvY2FsZSBpcyBzcGVjaWZpZWQgcmF0aGVyIHRoYW4gdHJ5aW5nIHRvIHJlaW50ZXJw
cmV0IHRoZSBvbGQKbG9jYWxlIHdpdGggdGhlIG5ldyBwcm92aWRlci4KLS0tCiBzcmMvYmFja2Vu
ZC9jb21tYW5kcy9kYmNvbW1hbmRzLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp
b24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21tYW5kcy9k
YmNvbW1hbmRzLmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9kYmNvbW1hbmRzLmMKaW5kZXggNTAy
YTQ1MTYzYzguLjkyYTM5NmI4NDA2IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5kcy9k
YmNvbW1hbmRzLmMKKysrIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvZGJjb21tYW5kcy5jCkBAIC0x
MDUyLDcgKzEwNTIsNyBAQCBjcmVhdGVkYihQYXJzZVN0YXRlICpwc3RhdGUsIGNvbnN0IENyZWF0
ZWRiU3RtdCAqc3RtdCkKIAkJZGJjdHlwZSA9IHNyY19jdHlwZTsKIAlpZiAoZGJsb2Nwcm92aWRl
ciA9PSAnXDAnKQogCQlkYmxvY3Byb3ZpZGVyID0gc3JjX2xvY3Byb3ZpZGVyOwotCWlmIChkYmxv
Y2FsZSA9PSBOVUxMKQorCWlmIChkYmxvY2FsZSA9PSBOVUxMICYmIGRibG9jcHJvdmlkZXIgPT0g
c3JjX2xvY3Byb3ZpZGVyKQogCQlkYmxvY2FsZSA9IHNyY19sb2NhbGU7CiAJaWYgKGRiaWN1cnVs
ZXMgPT0gTlVMTCkKIAkJZGJpY3VydWxlcyA9IHNyY19pY3VydWxlczsKLS0gCjIuNDMuMAoK


--=-BkB/ZCA7N6Pz3BV8UX0S--