Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1u4Z8r-003xAc-BA
	for pgsql-bugs@arkaria.postgresql.org; Tue, 15 Apr 2025 05:47:29 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1u4Z8p-0065Ur-Fe
	for pgsql-bugs@arkaria.postgresql.org; Tue, 15 Apr 2025 05:47:28 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1u4Z8p-0065Uh-7G
	for pgsql-bugs@lists.postgresql.org; Tue, 15 Apr 2025 05:47:28 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1u4Z8m-0008nZ-25
	for pgsql-bugs@lists.postgresql.org;
	Tue, 15 Apr 2025 05:47:27 +0000
Received: from [192.168.11.4] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133])
	by oss.nttdata.com (Postfix) with ESMTPSA id 0194060251;
	Tue, 15 Apr 2025 14:47:19 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com
Content-Type: multipart/mixed; boundary="------------hWAyJvGEKPgjFDAxZPk9aAW6"
Message-ID: <508337df-2ea5-469a-b4be-920d0378dcdb@oss.nttdata.com>
Date: Tue, 15 Apr 2025 14:47:19 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Missing whitespace in pg_restore manpage
To: Lele Gaifax <lele@metapensiero.it>, pgsql-bugs@lists.postgresql.org
References: <87lds3ysm0.fsf@metapensiero.it>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <87lds3ysm0.fsf@metapensiero.it>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/508337df-2ea5-469a-b4be-920d0378dcdb%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------hWAyJvGEKPgjFDAxZPk9aAW6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 2025/04/14 18:55, Lele Gaifax wrote:
> Hi all,
> 
> the manpage for "pg_restore" tool, in its "--filter" option description,
> is missing a whitespace after the reference to "--exclude-schema"
> option:
> 
> diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
> index 0ba68ad5305..b6de497aee1 100644
> --- a/doc/src/sgml/ref/pg_restore.sgml
> +++ b/doc/src/sgml/ref/pg_restore.sgml
> @@ -231,7 +231,7 @@ PostgreSQL documentation
>           or included from restore. The patterns are interpreted according to the
>           same rules as
>           <option>-n</option>/<option>--schema</option> for including objects in schemas,
> -        <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,
> +        <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
>           <option>-P</option>/<option>--function</option> for restoring named functions,
>           <option>-I</option>/<option>--index</option> for restoring named indexes,
>           <option>-t</option>/<option>--table</option> for restoring named tables

Thanks for the report! I think you're right, and I've created a patch
based on your suggestion.

Since this typo was introduced in v17, the patch should be back-patched
to that branch as well.

By the way, I noticed both "Lele Gaifax" and "Emanuele Gaifas" in your email.
Could you let me know which name you'd prefer to use as the author in
the commit message? For now, I've used "Lele Gaifax" in the attached patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------hWAyJvGEKPgjFDAxZPk9aAW6
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-doc-Fix-missing-whitespace-in-pg_restore-document.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-doc-Fix-missing-whitespace-in-pg_restore-document.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBkOWU5NDRhMzQ1N2JjMDQ3NjNhOWMwYjNkM2UwY2ZhM2VlM2Q2MzRkIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFR1ZSwgMTUgQXByIDIwMjUgMTQ6Mzk6MDMgKzA5MDAKU3ViamVjdDogW1BB
VENIIHYxXSBkb2M6IEZpeCBtaXNzaW5nIHdoaXRlc3BhY2UgaW4gcGdfcmVzdG9yZSBkb2N1
bWVudGF0aW9uLgoKUHJldmlvdXNseSwgYSBzcGFjZSB3YXMgbWlzc2luZyBiZXR3ZWVuICI8
b3B0aW9uPi0tZXhjbHVkZS1zY2hlbWE8L29wdGlvbj4iCmFuZCAiZm9yIiBpbiB0aGUgcGdf
cmVzdG9yZSBkb2N1bWVudGF0aW9uLiBUaGlzIGNvbW1pdCBmaXhlcyB0aGUgdHlwbyBieQph
ZGRpbmcgdGhlIG1pc3Npbmcgd2hpdGVzcGFjZS4KCkJhY2stcGF0Y2ggdG8gdjE3IHdoZXJl
IHRoZSB0eXBvIHdhcyBhZGRlZC4KCkF1dGhvcjogTGVsZSBHYWlmYXggPGxlbGVAbWV0YXBl
bnNpZXJvLml0PgpSZXZpZXdlZC1ieTogRnVqaWkgTWFzYW8gPG1hc2FvLmZ1amlpQGdtYWls
LmNvbT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS84N2xkczN5c20wLmZzZkBt
ZXRhcGVuc2llcm8uaXQKQmFja3BhdGNoLXRocm91Z2g6IDE3Ci0tLQogZG9jL3NyYy9zZ21s
L3JlZi9wZ19yZXN0b3JlLnNnbWwgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp
b24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvcmVmL3Bn
X3Jlc3RvcmUuc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYvcGdfcmVzdG9yZS5zZ21sCmluZGV4
IDBiYTY4YWQ1MzA1Li5iNmRlNDk3YWVlMSAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3Jl
Zi9wZ19yZXN0b3JlLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZXN0b3JlLnNn
bWwKQEAgLTIzMSw3ICsyMzEsNyBAQCBQb3N0Z3JlU1FMIGRvY3VtZW50YXRpb24KICAgICAg
ICAgb3IgaW5jbHVkZWQgZnJvbSByZXN0b3JlLiBUaGUgcGF0dGVybnMgYXJlIGludGVycHJl
dGVkIGFjY29yZGluZyB0byB0aGUKICAgICAgICAgc2FtZSBydWxlcyBhcwogICAgICAgICA8
b3B0aW9uPi1uPC9vcHRpb24+LzxvcHRpb24+LS1zY2hlbWE8L29wdGlvbj4gZm9yIGluY2x1
ZGluZyBvYmplY3RzIGluIHNjaGVtYXMsCi0gICAgICAgIDxvcHRpb24+LU48L29wdGlvbj4v
PG9wdGlvbj4tLWV4Y2x1ZGUtc2NoZW1hPC9vcHRpb24+Zm9yIGV4Y2x1ZGluZyBvYmplY3Rz
IGluIHNjaGVtYXMsCisgICAgICAgIDxvcHRpb24+LU48L29wdGlvbj4vPG9wdGlvbj4tLWV4
Y2x1ZGUtc2NoZW1hPC9vcHRpb24+IGZvciBleGNsdWRpbmcgb2JqZWN0cyBpbiBzY2hlbWFz
LAogICAgICAgICA8b3B0aW9uPi1QPC9vcHRpb24+LzxvcHRpb24+LS1mdW5jdGlvbjwvb3B0
aW9uPiBmb3IgcmVzdG9yaW5nIG5hbWVkIGZ1bmN0aW9ucywKICAgICAgICAgPG9wdGlvbj4t
STwvb3B0aW9uPi88b3B0aW9uPi0taW5kZXg8L29wdGlvbj4gZm9yIHJlc3RvcmluZyBuYW1l
ZCBpbmRleGVzLAogICAgICAgICA8b3B0aW9uPi10PC9vcHRpb24+LzxvcHRpb24+LS10YWJs
ZTwvb3B0aW9uPiBmb3IgcmVzdG9yaW5nIG5hbWVkIHRhYmxlcwotLSAKMi40OS4wCgo=

--------------hWAyJvGEKPgjFDAxZPk9aAW6--