Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mImR2-0007HM-Me for pgsql-bugs@arkaria.postgresql.org; Wed, 25 Aug 2021 06:30:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mImQz-0004Wr-U3 for pgsql-bugs@arkaria.postgresql.org; Wed, 25 Aug 2021 06:30:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mImQz-0004Wj-N4 for pgsql-bugs@lists.postgresql.org; Wed, 25 Aug 2021 06:30:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mImQx-0008EW-LJ for pgsql-bugs@lists.postgresql.org; Wed, 25 Aug 2021 06:30:48 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 17P6TcBJ520274; Wed, 25 Aug 2021 02:29:38 -0400 From: Tom Lane To: Dilyan Palauzov cc: pgsql-bugs@lists.postgresql.org Subject: Re: No libldap_r in OpenLDAP 2.5 - use LDAP_API_FEATURE_X_OPENLDAP_REENTRANT from ldap_features.h In-reply-to: <20210825052142.Horde.fX47Irhz5YmXoRVbIbyYUJm@webmail.aegee.org> References: <20210825052142.Horde.fX47Irhz5YmXoRVbIbyYUJm@webmail.aegee.org> Comments: In-reply-to Dilyan Palauzov message dated "Wed, 25 Aug 2021 05:21:42 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <520272.1629872978.1@sss.pgh.pa.us> Date: Wed, 25 Aug 2021 02:29:38 -0400 Message-ID: <520273.1629872978@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dilyan Palauzov writes: > The current postgres/configure.ac logic is: if libldap_r is availabe, > then use it, otherwise use libldap. Right. > I propose, instead of looking for the presence of libldap_r, to check > the feature macro, and if libldap is reentrant, not to use libldap_r . Why? This seems more fragile (i.e., it adds an assumption that the visible header file matches the available libraries), and if there is a concrete benefit, you did not say what that is. regards, tom lane