From: Sergei Kornilov <sk@zsrv.org>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: =?utf-8?B?0J7Qu9C10LMg0KHQsNC80L7QudC70L7Qsg==?= <splarv@ya.ru>,
	pgsql-bugs@lists.postgresql.org,
	=?utf-8?B?w4FsdmFybyBIZXJyZXJh?= <alvherre@kurilemu.de>,
	Nathan Bossart <nathandbossart@gmail.com>
In-Reply-To: <CAHGQGwFq-7p1nCfemJCe0_VXVWxpGdq2D4ss+ns6p7=W1FTDqg@mail.gmail.com>
References: <202601301728.sfkizrto3t5i@alvherre.pgsql> <9b9341b0-942e-4d34-b94f-92bd918fad04@ya.ru>
	 <1317421770387925@cea5cfd9-50d3-4d85-a924-a7cc75f8f215> <CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com>
	 <aYpYaRipZ_-lYxNY@nathan> <CAHGQGwFzC+HYEwJGhpmu1NBiQp_Ln8t0z9CDt8QCQDnUtFAFYA@mail.gmail.com>
	 <aYtXgaKfiYpaqQyW@nathan> <CAHGQGwFq-7p1nCfemJCe0_VXVWxpGdq2D4ss+ns6p7=W1FTDqg@mail.gmail.com>
Subject: Re: basic_archive lost archive_directory
MIME-Version: 1.0
Date: Tue, 24 Feb 2026 10:33:07 +0300
Message-Id: <5234821771918387@77e1e142-da70-4850-bfce-1a67e6fd1d40>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
Archived-At: <https://www.postgresql.org/message-id/5234821771918387%4077e1e142-da70-4850-bfce-1a67e6fd1d40>
Precedence: bulk

Hello

Honestly, I don't think that only 8 stat calls per each 1Gbps of WAL writes is too much. I doubt basic_archive will be used in systems where there's a lot of writing. Although there is little benefit from this stat call, I agree.

> That said, if users are generally fine with the "could not create file" error,
> I'm ok with the proposed patch (i.e., just removing the check).

I'm ok with this error message.

regards, Sergei