Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1fn8kB-0003Uq-53
	for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Aug 2018 20:38:15 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1fn8k8-0002sz-Vf
	for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Aug 2018 20:38:12 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fn8k8-0002sf-PT
	for pgsql-bugs@lists.postgresql.org; Tue, 07 Aug 2018 20:38:12 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fn8k4-0000he-21
	for pgsql-bugs@lists.postgresql.org; Tue, 07 Aug 2018 20:38:10 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w77Kc3jm005240;
	Tue, 7 Aug 2018 16:38:03 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Haribabu Kommi <kommi.haribabu@gmail.com>, nickbarnes01@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15310: pg_upgrade dissociates event triggers from extensions
In-reply-to: <20180807112910.GB19883@paquier.xyz>
References: <153360083872.1395.4593932457718151600@wrigleys.postgresql.org>
 <CAJrrPGcNzZ1n-xNsRfpxt=c_vYWnDK7hd_z80p4G8Tr1G15wAA@mail.gmail.com>
 <20180807112910.GB19883@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 07 Aug 2018 13:29:10 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5238.1533674283.1@sss.pgh.pa.us>
Date: Tue, 07 Aug 2018 16:38:03 -0400
Message-ID: <5239.1533674283@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> That sounds like a bug to me.  Could you add more tests to
> src/test/modules/test_pg_dump with an event trigger part of an extension
> with a binary upgrade test?

It doesn't seem especially useful to me to lock this particular barn
door behind the horse.  What would be great is a way of cross-checking
that the grammar, pg_dump, and the various callers of
recordDependencyOnCurrentExtension are all on the same page about
which objects can be extension members.  I see no way to automate that
unfortunately :-(

			regards, tom lane