Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xRYdu-000000014uo-0RoE for pgsql-bugs@arkaria.postgresql.org; Thu, 12 Nov 2026 17:31:22 +0000 Received: from localhost ([127.0.0.1]:47742 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xRYds-0000000451k-21u9 for pgsql-bugs@arkaria.postgresql.org; Thu, 12 Nov 2026 17:31:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:42566) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xRUDf-0000000GNTW-0Bl1 for pgsql-bugs@lists.postgresql.org; Thu, 12 Nov 2026 12:47:59 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xRUDc-00000000Xnr-3Vwo for pgsql-bugs@lists.postgresql.org; Thu, 12 Nov 2026 12:47:58 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-491971ac844so3920744f8f.2 for ; Thu, 12 Nov 2026 04:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=databricks.com; s=google; t=1794487675; x=1795092475; darn=lists.postgresql.org; h=to:cc:date:message-id:subject:mime-version:content-type:from:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FTlQy34/qSfmcQ47+is+NHK2PNGDmNC2fYfMYPPNxi0=; b=NFAsdixwk6aa661v7Rmt8BSIIoahHjQHApTVHJlOs/uc0BVXlLsmO0r4h9e/KXH4Hf davrlNVzEHvBYEuA0mn42Q7OVe+NQ0oVbljXuU2WdSj0WHs6gVPMsLHRdVy3n/f7qm+k qRUrjWyvMI7D3I9Fj+MeeY3yiXMxRrJIVzKkd//wkUJSlZpIseIWwIwObovtrrXNl6/Z fTtOchDOrqYJ8fpTSKiO+bkV1NGj89+/Js5VjDVxxb2iyRxRhKGuNVzBO0zA91Djvfwb Te4c3rqgIpABznbyv4CG0i/Ueg2fDMZCKjTjRP2a2DMcZQwb1OyGiS6GUrT8SyA0N5UX WR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794487675; x=1795092475; h=to:cc:date:message-id:subject:mime-version:content-type:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=FTlQy34/qSfmcQ47+is+NHK2PNGDmNC2fYfMYPPNxi0=; b=QHn9g+tfrGwwz0BegSFnI/qKkin8TmHutfmvawGVY6jq+isSFK8C6n1SxY8PiYXHdD 7XFITde2TQMpQGp5NHgt/ywBYOG7FBBJsRtqshHQpNp9pieZppECnd9N6e1urIGuv4rR 5dsFITXp9hOuidDS4iKvaYSQTNB6YAYfcH4GO6YrSGU2b8/tqxqikKyWtQAnKPRANaRq +brl3ClbTziyqx+kbos5/twqixPEQNAD0loSXPX/kYER2w20y5WFj0jYPl3iCcCXk7HE HaUWFXeW4B0atZ1YfEA7fVz28VjmFEo6wFXznxFOvxqbqSMsytvCQuKG+YnJ1jA6ow2V OfjA== X-Forwarded-Encrypted: i=1; AL+hErEsqWP36HUQ2Pm1lwt863kSr//jwlKcqCvKFou9mlfADCGbHviX2mfq53v736lEXXh387/EeCLHPuse@lists.postgresql.org X-Gm-Message-State: APuU4Z/tL3x8BV64CaXAihszUOoHvKpT4Odzo/Oe+pI6EAz+SksxOSWv q7kefsAbHgoNKefcLQlKInErgYQNYLD0xm18/d7GAwwtlGDTfBpiRi7uutMbU5cb2s8= X-Gm-Gg: AYBFou2i129XH2rVk7xR316YCZeabDGA8AuRWA9k4T4iK0knabsb4qJoQlSzzzj2A3X S4xKCyKg9Z+RuK+gXUcLZtoeuAb9Tc1vqkbA/1CrE3zULJJ+mGexeRT88mr+Q3GN3r0FS28CRbo 75MUNdfiVNEz+v0WQS64P4ImA4JgaNZV0zeLPfWVImXG0qEFlrXobrOdncg3tAWd551nAZeFMlh ynuzMyesPbe5Qxn9Qr/6NORtXk+TOAYHV9hXfodhxAMIPOGyqKhRfBcyBpPxjuivxAPHnve8Xko 8wvOWNg3fB0HnTSN5s+j9bcw8wRBu8AsyOd7OgnYXp05ndfxMjdqkNTg/G3VMsYlyNN1dg1L3Mw UsDqw2xafJyTfmEi1gnZTbfRp4hPXdLnW4+zHZoxHauOxfvqFLYFmeotSpMZEL10C8g2a3fX65q /it3V/oFuSTs6qhXsUf3p38GHBi1zTLyGg5sBg1dYrVLeP/r0u5KKVCCpfkMxmt4lg8KYSLjTOy WJwnA3Vb4XvYaXzpQKpXnnKD7G1Jonb7Hd0yLiWhKRyzA8M3F6RgtQBVQ1TLydUVDFSaqFUDefM HRyWGJFZxvASj2uSoR6dlkcKTB7IE2uv5gzBizzvwKoSJaA4D7aAJhEBHkt3mitMDQnM6Yciu8u qNEIMELg3VHiSZpI= X-Received: by 2002:a5d:584d:0:b0:492:7d9c:fcf8 with SMTP id ffacd0b85a97d-499c7a2371amr10157277f8f.49.1794487674654; Thu, 12 Nov 2026 04:47:54 -0800 (PST) Received: from smtpclient.apple ([75.125.238.93]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4988bdef64dsm15057855f8f.20.2026.11.12.04.47.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2026 04:47:47 -0800 (PST) From: Konstantin Knizhnik Content-Type: multipart/alternative; boundary="Apple-Mail=_13202E66-6869-45A3-844A-476F78DB037C" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.4\)) Subject: Re: BUG #19519: REPACK can fail due to missing chunk for toast value Message-Id: <524F8ABD-E66D-4964-B7BD-07160BFC5FDE@databricks.com> Date: Thu, 12 Nov 2026 14:47:34 +0200 Cc: Matthias van de Meent , Michael Paquier , Andrey Borodin , Heikki Linnakangas , Srinath Reddy Sadipiralla , Imran Zaheer , Alexander Lakhin , PostgreSQL mailing lists To: Rui Zhao X-Mailer: Apple Mail (2.3864.700.51.1.4) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail=_13202E66-6869-45A3-844A-476F78DB037C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Hi, >=20 > Attached is v8 of the fix for the "missing chunk number 0 for toast > value" failures during heap rewrites and non-concurrent index builds. >=20 > This is a rebase of Matthias' v7 onto current master, with Rui Zhao's > two follow-up patches folded in, plus a bit of cleanup and one extra > fix for a whole-row expression index. >=20 > Compared to v7: >=20 > - Rebased onto current master (conflict in tableam.h resolved by > keeping master's slice validation and returning bool with flags). > - Folded in Rui's 0001 (skipped stashed prior versions are counted as > removed, not reported as a rewrite failure) and 0002 (cleanup loop > off-by-ones). > - Replaced the duplicated goto-heavy sort-path and index-build cleanup > with a shared heap_inline_recently_dead_toast() helper. > - Index builds now collect every varlena attribute referenced by the > index definition, expressions (including whole-row Vars) and the > predicate, so a whole-row expression index no longer races the same > way. A new isolation permutation covers that case. > - Dropped the duplicate recovery TAP test in favor of the dblink > isolation spec (as the v7 commit message already planned). Added > sort-path CLUSTER and UPDATE-chain permutations there. > - Comment / include-order / pgindent cleanup; TOAST_MISSING_OK is now > (1 << 0). >=20 > Verification on current master: >=20 > - make check: all 243 tests passed > - src/test/isolation: all 139 tests passed > - contrib/dblink isolation: rewrite_stale_xmin passed > - The same isolation test on unpatched master fails all 11 > permutations with the missing-chunk error (CLUSTER index and sort > paths, VACUUM FULL, REPACK, CREATE INDEX, whole-row expression > index; DELETE and UPDATE chains). >=20 > CF entry: https://commitfest.postgresql.org/patch/6824/ > I will update it with v8 shortly. >=20 > Regards, > Konstantin >=20 >=20 > On 24/10/2026 18:36, Rui Zhao wrote: > > Thanks for updating the patch. I tested v7 on 4b97fd15fb4 and found = the > > UPDATE case from my previous mail still fails, plus two cleanup = leaks. > > > > Attached are 0001 and 0002 on top of v7. All tests I ran passed.=20 =EF=BF=BC= --Apple-Mail=_13202E66-6869-45A3-844A-476F78DB037C Content-Type: multipart/mixed; boundary="Apple-Mail=_62091BF7-E2A4-4692-8A58-19E5656A5476" --Apple-Mail=_62091BF7-E2A4-4692-8A58-19E5656A5476 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii

Hi,


Attached is v8 of the fix for the "missing chunk number 0 for toast

value" failures during heap rewrites and non-concurrent index builds.


This is a rebase of Matthias' v7 onto current master, with Rui Zhao's

two follow-up patches folded in, plus a bit of cleanup and one extra

fix for a whole-row expression index.


Compared to v7:


- Rebased onto current master (conflict in tableam.h resolved by

  keeping master's slice validation and returning bool with flags).

- Folded in Rui's 0001 (skipped stashed prior versions are counted as

  removed, not reported as a rewrite failure) and 0002 (cleanup loop

  off-by-ones).

- Replaced the duplicated goto-heavy sort-path and index-build cleanup

  with a shared heap_inline_recently_dead_toast() helper.

- Index builds now collect every varlena attribute referenced by the

  index definition, expressions (including whole-row Vars) and the

  predicate, so a whole-row expression index no longer races the same

  way. A new isolation permutation covers that case.

- Dropped the duplicate recovery TAP test in favor of the dblink

  isolation spec (as the v7 commit message already planned). Added

  sort-path CLUSTER and UPDATE-chain permutations there.

- Comment / include-order / pgindent cleanup; TOAST_MISSING_OK is now

  (1 << 0).


Verification on current master:


- make check: all 243 tests passed

- src/test/isolation: all 139 tests passed

- contrib/dblink isolation: rewrite_stale_xmin passed

- The same isolation test on unpatched master fails all 11

  permutations with the missing-chunk error (CLUSTER index and sort

  paths, VACUUM FULL, REPACK, CREATE INDEX, whole-row expression

  index; DELETE and UPDATE chains).


CF entry: https://commitfest.postgresql.org/patch/6824/

I will update it with v8 shortly.


Regards,

Konstantin



On 24/10/2026 18:36, Rui Zhao wrote:

> Thanks for updating the patch. I tested v7 on 4b97fd15fb4 and found the

> UPDATE case from my previous mail still fails, plus two cleanup leaks.

>

> Attached are 0001 and 0002 on top of v7. All tests I ran passed. 

--Apple-Mail=_62091BF7-E2A4-4692-8A58-19E5656A5476 Content-Disposition: attachment; filename=v8-0001-Fix-missing-chunk-errors-during-heap-rewrites-and.patch Content-Type: application/x-apple-msg-attachment; x-unix-mode=0666; name="v8-0001-Fix-missing-chunk-errors-during-heap-rewrites-and.patch" Content-Transfer-Encoding: quoted-printable =46rom=20ffd8366a6ad0d2cf65ddfc407a09de4ad4415bac=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Konstantin=20Knizhnik=20=0A= Date:=20Thu,=2012=20Nov=202026=2014:46:55=20+0200=0ASubject:=20[PATCH=20= v8]=20Fix=20"missing=20chunk"=20errors=20during=20heap=20rewrites=20and=20= index=0A=20builds=0A=0AA=20transaction=20in=20another=20database=20can=20= hold=20back=20the=20xmin=20of=20the=20backend=0Arunning=20CLUSTER,=20= VACUUM=20FULL,=20REPACK=20or=20a=20non-concurrent=20CREATE=20INDEX,=0Aas=20= GetSnapshotData()=20does=20not=20filter=20by=20database.=20=20= ComputeXidHorizons()=0Adoes,=20so=20a=20concurrent=20VACUUM=20or=20= on-access=20pruning=20can=20remove=20the=20TOAST=0Achunks=20of=20a=20= tuple=20deleted=20or=20updated=20by=20a=20committed=20transaction=20= while=0AHeapTupleSatisfiesVacuum()=20in=20the=20rewrite=20still=20= classifies=20the=20tuple=20as=0AHEAPTUPLE_RECENTLY_DEAD.=20=20Fetching=20= its=20TOAST=20data=20then=20fails=20with=0A"missing=20chunk=20number=200=20= for=20toast=20value=20...".=0A=0ASuch=20a=20tuple=20is=20invisible=20to=20= every=20snapshot=20that=20can=20still=20look=20at=20the=0Arelation,=20so=20= it=20is=20safe=20to=20skip=20it.=20=20This=20commit=20adds=20a=20= TOAST_MISSING_OK=0Aflag=20that=20makes=20the=20TOAST=20fetch=20paths=20= (table_relation_fetch_toast_slice,=0Atoast_fetch_datum,=20= detoast_external_attr_extended,=20toast_tuple_init=20and=0A= heap_toast_insert_or_update)=20report=20missing=20chunks=20to=20the=20= caller=20instead=0Aof=20raising=20an=20error,=20and=20uses=20it=20only=20= for=20RECENTLY_DEAD=20tuples:=0A=0A-=20In=20a=20heap=20rewrite,=20a=20= RECENTLY_DEAD=20tuple=20whose=20TOAST=20data=20is=20gone=20is=0A=20=20= not=20written=20and=20is=20counted=20as=20removed.=20=20This=20covers=20= both=20directly=0A=20=20written=20tuples=20and=20update-chain=20members=20= stashed=20in=20rewriteheap.c,=0A=20=20whose=20result=20is=20reported=20= by=20end_heap_rewrite().=0A-=20When=20the=20rewrite=20sorts=20the=20= tuples,=20the=20TOAST=20data=20of=20RECENTLY_DEAD=0A=20=20tuples=20is=20= inlined=20before=20the=20sort,=20so=20that=20missing=20chunks=20are=20= detected=0A=20=20while=20the=20tuple's=20visibility=20is=20still=20= known.=0A-=20In=20a=20non-concurrent=20index=20build,=20the=20varlena=20= attributes=20referenced=20by=0A=20=20the=20index=20(columns,=20= expressions=20including=20whole-row=20references,=20and=0A=20=20= predicate)=20are=20inlined=20for=20tuples=20that=20are=20not=20alive,=20= and=20the=20tuple=20is=0A=20=20skipped=20from=20the=20index=20if=20its=20= TOAST=20data=20is=20gone.=0A=0AREPACK=20CONCURRENTLY=20and=20CREATE=20= INDEX=20CONCURRENTLY=20use=20MVCC=20snapshots=20and=0Aare=20not=20= affected.=0A=0AAn=20isolation=20test=20is=20added=20to=20contrib/dblink,=20= which=20is=20used=20to=20hold=20an=0AXID=20in=20another=20database.=0A=0A= Reported-by:=20Alexander=20Lakhin=20=0AReported-by:=20= Ekaterina=20Testova=20=0AAuthor:=20Michael=20= Paquier=20=0ACo-authored-by:=20Matthias=20van=20de=20= Meent=20=0ACo-authored-by:=20Rui=20Zhao=20= =0ADiscussion:=20= https://postgr.es/m/18351-f6e06364b3a2e669@postgresql.org=0ADiscussion:=20= https://postgr.es/m/19519-fe02d8ff679d834d@postgresql.org=0ADiscussion:=20= https://postgr.es/m/1779078055.630771314@fmail2.qdit=0A---=0A=20= contrib/dblink/.gitignore=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20|=20=20=202=20+=0A=20contrib/dblink/Makefile=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20|=20=20=202=20+=0A=20= .../dblink/expected/rewrite_stale_xmin.out=20=20=20=20|=20752=20= ++++++++++++++++++=0A=20contrib/dblink/meson.build=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20|=20=20=205=20+=0A=20= contrib/dblink/specs/rewrite_stale_xmin.spec=20=20|=20249=20++++++=0A=20= src/backend/access/common/detoast.c=20=20=20=20=20=20=20=20=20=20=20|=20=20= 43=20+-=0A=20src/backend/access/heap/heapam.c=20=20=20=20=20=20=20=20=20=20= =20=20=20=20|=20=20=204=20+-=0A=20= src/backend/access/heap/heapam_handler.c=20=20=20=20=20=20|=20240=20= +++++-=0A=20src/backend/access/heap/heaptoast.c=20=20=20=20=20=20=20=20=20= =20=20|=20=2048=20+-=0A=20src/backend/access/heap/rewriteheap.c=20=20=20=20= =20=20=20=20=20|=20=2071=20+-=0A=20= src/backend/access/table/toast_helper.c=20=20=20=20=20=20=20|=20=2041=20= +-=0A=20src/include/access/detoast.h=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20|=20=20=209=20+=0A=20src/include/access/heaptoast.h=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20|=20=2016=20+-=0A=20= src/include/access/rewriteheap.h=20=20=20=20=20=20=20=20=20=20=20=20=20=20= |=20=20=206=20+-=0A=20src/include/access/tableam.h=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20|=20=2026=20+-=0A=20= src/include/access/toast_helper.h=20=20=20=20=20=20=20=20=20=20=20=20=20= |=20=2011=20+-=0A=2016=20files=20changed,=201467=20insertions(+),=2058=20= deletions(-)=0A=20create=20mode=20100644=20= contrib/dblink/expected/rewrite_stale_xmin.out=0A=20create=20mode=20= 100644=20contrib/dblink/specs/rewrite_stale_xmin.spec=0A=0Adiff=20--git=20= a/contrib/dblink/.gitignore=20b/contrib/dblink/.gitignore=0Aindex=20= 5dcb3ff9723..33bc8d8ffeb=20100644=0A---=20a/contrib/dblink/.gitignore=0A= +++=20b/contrib/dblink/.gitignore=0A@@=20-2,3=20+2,5=20@@=0A=20/log/=0A=20= /results/=0A=20/tmp_check/=0A+/output_iso/=0A+/tmp_check_iso/=0Adiff=20= --git=20a/contrib/dblink/Makefile=20b/contrib/dblink/Makefile=0Aindex=20= fde0b49ddbb..a0ba4128081=20100644=0A---=20a/contrib/dblink/Makefile=0A= +++=20b/contrib/dblink/Makefile=0A@@=20-13,6=20+13,8=20@@=20PGFILEDESC=20= =3D=20"dblink=20-=20connect=20to=20other=20PostgreSQL=20databases"=0A=20=0A= =20REGRESS=20=3D=20dblink=0A=20REGRESS_OPTS=20=3D=20= --dlpath=3D$(top_builddir)/src/test/regress=0A+ISOLATION=20=3D=20= rewrite_stale_xmin=0A+ISOLATION_OPTS=20=3D=20--load-extension=3Ddblink=0A= =20TAP_TESTS=20=3D=201=0A=20=0A=20ifdef=20USE_PGXS=0Adiff=20--git=20= a/contrib/dblink/expected/rewrite_stale_xmin.out=20= b/contrib/dblink/expected/rewrite_stale_xmin.out=0Anew=20file=20mode=20= 100644=0Aindex=2000000000000..168c6ea3f4b=0A---=20/dev/null=0A+++=20= b/contrib/dblink/expected/rewrite_stale_xmin.out=0A@@=20-0,0=20+1,752=20= @@=0A+Parsed=20test=20spec=20with=203=20sessions=0A+=0A+starting=20= permutation:=20s1_hold_xmin=20s2_begin=20s3_delete=20s3_vacuum_main_only=20= s2_commit=20s3_vacuum_toast=20s3_cluster=20s1_release=0A+step=20= s1_hold_xmin:=20=0A+=20=20=20=20SELECT=20dblink_connect('holder',=0A+=20=20= =20=20=20=20=20=20'dbname=3Dregress_other_db=20port=3D'=20||=20= current_setting('port'));=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'BEGIN');=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20= TABLE=20xid_holder(x=20int)');=0A+=0A+dblink_connect=0A+--------------=0A= +OK=20=20=20=20=20=20=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A= +-----------=0A+BEGIN=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20= =0A+------------=0A+CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20= =0A+=20=20=20=20BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20= =20SELECT=201;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A= +(1=20row)=0A+=0A+step=20s3_delete:=20=0A+=20=20=20=20DELETE=20FROM=20= rewrite_test=20WHERE=20id=20=3D=201;=0A+=0A+step=20s3_vacuum_main_only:=20= =0A+=20=20=20=20VACUUM=20(PROCESS_TOAST=20false)=20rewrite_test;=0A+=0A= +step=20s2_commit:=20COMMIT;=0A+step=20s3_vacuum_toast:=20=0A+=20=20=20=20= VACUUM=20pg_toast.rewrite_test_toast;=0A+=0A+step=20s3_cluster:=20=0A+=20= =20=20=20CLUSTER=20rewrite_test=20USING=20rewrite_test_pkey;=0A+=0A+step=20= s1_release:=20=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'COMMIT');=0A+=20=20=20=20SELECT=20dblink_disconnect('holder');=0A+=0A= +dblink_exec=0A+-----------=0A+COMMIT=20=20=20=20=20=0A+(1=20row)=0A+=0A= +dblink_disconnect=0A+-----------------=0A+OK=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A+starting=20permutation:=20= s1_hold_xmin=20s2_begin=20s3_delete=20s3_vacuum_main_only=20s2_commit=20= s3_vacuum_toast=20s3_cluster_sort=20s3_check_rows=20s1_release=0A+step=20= s1_hold_xmin:=20=0A+=20=20=20=20SELECT=20dblink_connect('holder',=0A+=20=20= =20=20=20=20=20=20'dbname=3Dregress_other_db=20port=3D'=20||=20= current_setting('port'));=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'BEGIN');=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20= TABLE=20xid_holder(x=20int)');=0A+=0A+dblink_connect=0A+--------------=0A= +OK=20=20=20=20=20=20=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A= +-----------=0A+BEGIN=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20= =0A+------------=0A+CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20= =0A+=20=20=20=20BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20= =20SELECT=201;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A= +(1=20row)=0A+=0A+step=20s3_delete:=20=0A+=20=20=20=20DELETE=20FROM=20= rewrite_test=20WHERE=20id=20=3D=201;=0A+=0A+step=20s3_vacuum_main_only:=20= =0A+=20=20=20=20VACUUM=20(PROCESS_TOAST=20false)=20rewrite_test;=0A+=0A= +step=20s2_commit:=20COMMIT;=0A+step=20s3_vacuum_toast:=20=0A+=20=20=20=20= VACUUM=20pg_toast.rewrite_test_toast;=0A+=0A+step=20s3_cluster_sort:=20=0A= +=20=20=20=20SET=20enable_indexscan=20=3D=20off;=0A+=20=20=20=20CLUSTER=20= rewrite_test=20USING=20rewrite_test_pkey;=0A+=20=20=20=20RESET=20= enable_indexscan;=0A+=0A+step=20s3_check_rows:=20=0A+=20=20=20=20SELECT=20= id,=20length(data),=20left(data,=201)=20FROM=20rewrite_test=20ORDER=20BY=20= id;=0A+=20=20=20=20SELECT=20reltuples=20FROM=20pg_class=20WHERE=20oid=20= =3D=20'rewrite_test'::regclass;=0A+=0A+id|length|left=0A+--+------+----=0A= +=202|=20=202500|y=20=20=20=0A+(1=20row)=0A+=0A+reltuples=0A+---------=0A= +=20=20=20=20=20=20=20=201=0A+(1=20row)=0A+=0A+step=20s1_release:=20=0A+=20= =20=20=20SELECT=20dblink_exec('holder',=20'COMMIT');=0A+=20=20=20=20= SELECT=20dblink_disconnect('holder');=0A+=0A+dblink_exec=0A+-----------=0A= +COMMIT=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_disconnect=0A= +-----------------=0A+OK=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=0A= +(1=20row)=0A+=0A+=0A+starting=20permutation:=20s1_hold_xmin=20s2_begin=20= s3_delete=20s3_vacuum_main_only=20s2_commit=20s3_vacuum_toast=20= s3_vacuum_full=20s1_release=0A+step=20s1_hold_xmin:=20=0A+=20=20=20=20= SELECT=20dblink_connect('holder',=0A+=20=20=20=20=20=20=20=20= 'dbname=3Dregress_other_db=20port=3D'=20||=20current_setting('port'));=0A= +=20=20=20=20SELECT=20dblink_exec('holder',=20'BEGIN');=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20TABLE=20xid_holder(x=20= int)');=0A+=0A+dblink_connect=0A+--------------=0A+OK=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A+-----------=0A+BEGIN=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20=0A+------------=0A= +CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20=0A+=20=20=20=20= BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20=20SELECT=20= 1;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A+(1=20row)=0A= +=0A+step=20s3_delete:=20=0A+=20=20=20=20DELETE=20FROM=20rewrite_test=20= WHERE=20id=20=3D=201;=0A+=0A+step=20s3_vacuum_main_only:=20=0A+=20=20=20=20= VACUUM=20(PROCESS_TOAST=20false)=20rewrite_test;=0A+=0A+step=20= s2_commit:=20COMMIT;=0A+step=20s3_vacuum_toast:=20=0A+=20=20=20=20VACUUM=20= pg_toast.rewrite_test_toast;=0A+=0A+step=20s3_vacuum_full:=20=0A+=20=20=20= =20VACUUM=20FULL=20rewrite_test;=0A+=0A+step=20s1_release:=20=0A+=20=20=20= =20SELECT=20dblink_exec('holder',=20'COMMIT');=0A+=20=20=20=20SELECT=20= dblink_disconnect('holder');=0A+=0A+dblink_exec=0A+-----------=0A+COMMIT=20= =20=20=20=20=0A+(1=20row)=0A+=0A+dblink_disconnect=0A+-----------------=0A= +OK=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A= +starting=20permutation:=20s1_hold_xmin=20s2_begin=20s3_delete=20= s3_vacuum_main_only=20s2_commit=20s3_vacuum_toast=20s3_repack=20= s1_release=0A+step=20s1_hold_xmin:=20=0A+=20=20=20=20SELECT=20= dblink_connect('holder',=0A+=20=20=20=20=20=20=20=20= 'dbname=3Dregress_other_db=20port=3D'=20||=20current_setting('port'));=0A= +=20=20=20=20SELECT=20dblink_exec('holder',=20'BEGIN');=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20TABLE=20xid_holder(x=20= int)');=0A+=0A+dblink_connect=0A+--------------=0A+OK=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A+-----------=0A+BEGIN=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20=0A+------------=0A= +CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20=0A+=20=20=20=20= BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20=20SELECT=20= 1;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A+(1=20row)=0A= +=0A+step=20s3_delete:=20=0A+=20=20=20=20DELETE=20FROM=20rewrite_test=20= WHERE=20id=20=3D=201;=0A+=0A+step=20s3_vacuum_main_only:=20=0A+=20=20=20=20= VACUUM=20(PROCESS_TOAST=20false)=20rewrite_test;=0A+=0A+step=20= s2_commit:=20COMMIT;=0A+step=20s3_vacuum_toast:=20=0A+=20=20=20=20VACUUM=20= pg_toast.rewrite_test_toast;=0A+=0A+step=20s3_repack:=20=0A+=20=20=20=20= REPACK=20rewrite_test;=0A+=0A+step=20s1_release:=20=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'COMMIT');=0A+=20=20=20=20SELECT=20= dblink_disconnect('holder');=0A+=0A+dblink_exec=0A+-----------=0A+COMMIT=20= =20=20=20=20=0A+(1=20row)=0A+=0A+dblink_disconnect=0A+-----------------=0A= +OK=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A= +starting=20permutation:=20s1_hold_xmin=20s2_begin=20s3_delete=20= s3_vacuum_main_only=20s2_commit=20s3_vacuum_toast=20s3_create_index=20= s1_release=0A+step=20s1_hold_xmin:=20=0A+=20=20=20=20SELECT=20= dblink_connect('holder',=0A+=20=20=20=20=20=20=20=20= 'dbname=3Dregress_other_db=20port=3D'=20||=20current_setting('port'));=0A= +=20=20=20=20SELECT=20dblink_exec('holder',=20'BEGIN');=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20TABLE=20xid_holder(x=20= int)');=0A+=0A+dblink_connect=0A+--------------=0A+OK=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A+-----------=0A+BEGIN=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20=0A+------------=0A= +CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20=0A+=20=20=20=20= BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20=20SELECT=20= 1;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A+(1=20row)=0A= +=0A+step=20s3_delete:=20=0A+=20=20=20=20DELETE=20FROM=20rewrite_test=20= WHERE=20id=20=3D=201;=0A+=0A+step=20s3_vacuum_main_only:=20=0A+=20=20=20=20= VACUUM=20(PROCESS_TOAST=20false)=20rewrite_test;=0A+=0A+step=20= s2_commit:=20COMMIT;=0A+step=20s3_vacuum_toast:=20=0A+=20=20=20=20VACUUM=20= pg_toast.rewrite_test_toast;=0A+=0A+step=20s3_create_index:=20=0A+=20=20=20= =20CREATE=20INDEX=20rewrite_test_data_idx=20ON=20rewrite_test=20(data);=0A= +=0A+step=20s1_release:=20=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'COMMIT');=0A+=20=20=20=20SELECT=20dblink_disconnect('holder');=0A+=0A= +dblink_exec=0A+-----------=0A+COMMIT=20=20=20=20=20=0A+(1=20row)=0A+=0A= +dblink_disconnect=0A+-----------------=0A+OK=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A+starting=20permutation:=20= s1_hold_xmin=20s2_begin=20s3_delete=20s3_vacuum_main_only=20s2_commit=20= s3_vacuum_toast=20s3_create_index_wholerow=20s1_release=0A+step=20= s1_hold_xmin:=20=0A+=20=20=20=20SELECT=20dblink_connect('holder',=0A+=20=20= =20=20=20=20=20=20'dbname=3Dregress_other_db=20port=3D'=20||=20= current_setting('port'));=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'BEGIN');=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20= TABLE=20xid_holder(x=20int)');=0A+=0A+dblink_connect=0A+--------------=0A= +OK=20=20=20=20=20=20=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A= +-----------=0A+BEGIN=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20= =0A+------------=0A+CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20= =0A+=20=20=20=20BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20= =20SELECT=201;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A= +(1=20row)=0A+=0A+step=20s3_delete:=20=0A+=20=20=20=20DELETE=20FROM=20= rewrite_test=20WHERE=20id=20=3D=201;=0A+=0A+step=20s3_vacuum_main_only:=20= =0A+=20=20=20=20VACUUM=20(PROCESS_TOAST=20false)=20rewrite_test;=0A+=0A= +step=20s2_commit:=20COMMIT;=0A+step=20s3_vacuum_toast:=20=0A+=20=20=20=20= VACUUM=20pg_toast.rewrite_test_toast;=0A+=0A+step=20= s3_create_index_wholerow:=20=0A+=20=20=20=20CREATE=20INDEX=20= rewrite_test_row_idx=20ON=20rewrite_test=20((rewrite_test=20IS=20NOT=20= NULL));=0A+=0A+step=20s1_release:=20=0A+=20=20=20=20SELECT=20= dblink_exec('holder',=20'COMMIT');=0A+=20=20=20=20SELECT=20= dblink_disconnect('holder');=0A+=0A+dblink_exec=0A+-----------=0A+COMMIT=20= =20=20=20=20=0A+(1=20row)=0A+=0A+dblink_disconnect=0A+-----------------=0A= +OK=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A= +starting=20permutation:=20s1_hold_xmin=20s2_begin=20s3_update=20= s3_vacuum_main_only=20s2_commit=20s3_vacuum_toast=20s3_vacuum_full=20= s3_check_rows=20s1_release=0A+step=20s1_hold_xmin:=20=0A+=20=20=20=20= SELECT=20dblink_connect('holder',=0A+=20=20=20=20=20=20=20=20= 'dbname=3Dregress_other_db=20port=3D'=20||=20current_setting('port'));=0A= +=20=20=20=20SELECT=20dblink_exec('holder',=20'BEGIN');=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20TABLE=20xid_holder(x=20= int)');=0A+=0A+dblink_connect=0A+--------------=0A+OK=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A+-----------=0A+BEGIN=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20=0A+------------=0A= +CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20=0A+=20=20=20=20= BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20=20SELECT=20= 1;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A+(1=20row)=0A= +=0A+step=20s3_update:=20=0A+=20=20=20=20UPDATE=20rewrite_test=20SET=20= data=20=3D=20repeat('z',=202500)=20WHERE=20id=20=3D=201;=0A+=0A+step=20= s3_vacuum_main_only:=20=0A+=20=20=20=20VACUUM=20(PROCESS_TOAST=20false)=20= rewrite_test;=0A+=0A+step=20s2_commit:=20COMMIT;=0A+step=20= s3_vacuum_toast:=20=0A+=20=20=20=20VACUUM=20pg_toast.rewrite_test_toast;=0A= +=0A+step=20s3_vacuum_full:=20=0A+=20=20=20=20VACUUM=20FULL=20= rewrite_test;=0A+=0A+step=20s3_check_rows:=20=0A+=20=20=20=20SELECT=20= id,=20length(data),=20left(data,=201)=20FROM=20rewrite_test=20ORDER=20BY=20= id;=0A+=20=20=20=20SELECT=20reltuples=20FROM=20pg_class=20WHERE=20oid=20= =3D=20'rewrite_test'::regclass;=0A+=0A+id|length|left=0A+--+------+----=0A= +=201|=20=202500|z=20=20=20=0A+=202|=20=202500|y=20=20=20=0A+(2=20rows)=0A= +=0A+reltuples=0A+---------=0A+=20=20=20=20=20=20=20=202=0A+(1=20row)=0A= +=0A+step=20s1_release:=20=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'COMMIT');=0A+=20=20=20=20SELECT=20dblink_disconnect('holder');=0A+=0A= +dblink_exec=0A+-----------=0A+COMMIT=20=20=20=20=20=0A+(1=20row)=0A+=0A= +dblink_disconnect=0A+-----------------=0A+OK=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A+starting=20permutation:=20= s1_hold_xmin=20s2_begin=20s3_update=20s3_vacuum_main_only=20s2_commit=20= s3_vacuum_toast=20s3_repack=20s3_check_rows=20s1_release=0A+step=20= s1_hold_xmin:=20=0A+=20=20=20=20SELECT=20dblink_connect('holder',=0A+=20=20= =20=20=20=20=20=20'dbname=3Dregress_other_db=20port=3D'=20||=20= current_setting('port'));=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'BEGIN');=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20= TABLE=20xid_holder(x=20int)');=0A+=0A+dblink_connect=0A+--------------=0A= +OK=20=20=20=20=20=20=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A= +-----------=0A+BEGIN=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20= =0A+------------=0A+CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20= =0A+=20=20=20=20BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20= =20SELECT=201;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A= +(1=20row)=0A+=0A+step=20s3_update:=20=0A+=20=20=20=20UPDATE=20= rewrite_test=20SET=20data=20=3D=20repeat('z',=202500)=20WHERE=20id=20=3D=20= 1;=0A+=0A+step=20s3_vacuum_main_only:=20=0A+=20=20=20=20VACUUM=20= (PROCESS_TOAST=20false)=20rewrite_test;=0A+=0A+step=20s2_commit:=20= COMMIT;=0A+step=20s3_vacuum_toast:=20=0A+=20=20=20=20VACUUM=20= pg_toast.rewrite_test_toast;=0A+=0A+step=20s3_repack:=20=0A+=20=20=20=20= REPACK=20rewrite_test;=0A+=0A+step=20s3_check_rows:=20=0A+=20=20=20=20= SELECT=20id,=20length(data),=20left(data,=201)=20FROM=20rewrite_test=20= ORDER=20BY=20id;=0A+=20=20=20=20SELECT=20reltuples=20FROM=20pg_class=20= WHERE=20oid=20=3D=20'rewrite_test'::regclass;=0A+=0A+id|length|left=0A= +--+------+----=0A+=201|=20=202500|z=20=20=20=0A+=202|=20=202500|y=20=20=20= =0A+(2=20rows)=0A+=0A+reltuples=0A+---------=0A+=20=20=20=20=20=20=20=20= 2=0A+(1=20row)=0A+=0A+step=20s1_release:=20=0A+=20=20=20=20SELECT=20= dblink_exec('holder',=20'COMMIT');=0A+=20=20=20=20SELECT=20= dblink_disconnect('holder');=0A+=0A+dblink_exec=0A+-----------=0A+COMMIT=20= =20=20=20=20=0A+(1=20row)=0A+=0A+dblink_disconnect=0A+-----------------=0A= +OK=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A= +starting=20permutation:=20s1_hold_xmin=20s2_begin=20s3_update=20= s3_update_again=20s3_vacuum_main_only=20s2_commit=20s3_vacuum_toast=20= s3_vacuum_full=20s3_check_rows=20s1_release=0A+step=20s1_hold_xmin:=20=0A= +=20=20=20=20SELECT=20dblink_connect('holder',=0A+=20=20=20=20=20=20=20=20= 'dbname=3Dregress_other_db=20port=3D'=20||=20current_setting('port'));=0A= +=20=20=20=20SELECT=20dblink_exec('holder',=20'BEGIN');=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20TABLE=20xid_holder(x=20= int)');=0A+=0A+dblink_connect=0A+--------------=0A+OK=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A+-----------=0A+BEGIN=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20=0A+------------=0A= +CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20=0A+=20=20=20=20= BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20=20SELECT=20= 1;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A+(1=20row)=0A= +=0A+step=20s3_update:=20=0A+=20=20=20=20UPDATE=20rewrite_test=20SET=20= data=20=3D=20repeat('z',=202500)=20WHERE=20id=20=3D=201;=0A+=0A+step=20= s3_update_again:=20=0A+=20=20=20=20UPDATE=20rewrite_test=20SET=20data=20= =3D=20repeat('w',=202500)=20WHERE=20id=20=3D=201;=0A+=0A+step=20= s3_vacuum_main_only:=20=0A+=20=20=20=20VACUUM=20(PROCESS_TOAST=20false)=20= rewrite_test;=0A+=0A+step=20s2_commit:=20COMMIT;=0A+step=20= s3_vacuum_toast:=20=0A+=20=20=20=20VACUUM=20pg_toast.rewrite_test_toast;=0A= +=0A+step=20s3_vacuum_full:=20=0A+=20=20=20=20VACUUM=20FULL=20= rewrite_test;=0A+=0A+step=20s3_check_rows:=20=0A+=20=20=20=20SELECT=20= id,=20length(data),=20left(data,=201)=20FROM=20rewrite_test=20ORDER=20BY=20= id;=0A+=20=20=20=20SELECT=20reltuples=20FROM=20pg_class=20WHERE=20oid=20= =3D=20'rewrite_test'::regclass;=0A+=0A+id|length|left=0A+--+------+----=0A= +=201|=20=202500|w=20=20=20=0A+=202|=20=202500|y=20=20=20=0A+(2=20rows)=0A= +=0A+reltuples=0A+---------=0A+=20=20=20=20=20=20=20=202=0A+(1=20row)=0A= +=0A+step=20s1_release:=20=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'COMMIT');=0A+=20=20=20=20SELECT=20dblink_disconnect('holder');=0A+=0A= +dblink_exec=0A+-----------=0A+COMMIT=20=20=20=20=20=0A+(1=20row)=0A+=0A= +dblink_disconnect=0A+-----------------=0A+OK=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A+starting=20permutation:=20= s1_hold_xmin=20s2_begin=20s3_update=20s3_update_again=20= s3_vacuum_main_only=20s2_commit=20s3_vacuum_toast=20s3_repack=20= s3_check_rows=20s1_release=0A+step=20s1_hold_xmin:=20=0A+=20=20=20=20= SELECT=20dblink_connect('holder',=0A+=20=20=20=20=20=20=20=20= 'dbname=3Dregress_other_db=20port=3D'=20||=20current_setting('port'));=0A= +=20=20=20=20SELECT=20dblink_exec('holder',=20'BEGIN');=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20TABLE=20xid_holder(x=20= int)');=0A+=0A+dblink_connect=0A+--------------=0A+OK=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A+-----------=0A+BEGIN=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20=0A+------------=0A= +CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20=0A+=20=20=20=20= BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20=20SELECT=20= 1;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A+(1=20row)=0A= +=0A+step=20s3_update:=20=0A+=20=20=20=20UPDATE=20rewrite_test=20SET=20= data=20=3D=20repeat('z',=202500)=20WHERE=20id=20=3D=201;=0A+=0A+step=20= s3_update_again:=20=0A+=20=20=20=20UPDATE=20rewrite_test=20SET=20data=20= =3D=20repeat('w',=202500)=20WHERE=20id=20=3D=201;=0A+=0A+step=20= s3_vacuum_main_only:=20=0A+=20=20=20=20VACUUM=20(PROCESS_TOAST=20false)=20= rewrite_test;=0A+=0A+step=20s2_commit:=20COMMIT;=0A+step=20= s3_vacuum_toast:=20=0A+=20=20=20=20VACUUM=20pg_toast.rewrite_test_toast;=0A= +=0A+step=20s3_repack:=20=0A+=20=20=20=20REPACK=20rewrite_test;=0A+=0A= +step=20s3_check_rows:=20=0A+=20=20=20=20SELECT=20id,=20length(data),=20= left(data,=201)=20FROM=20rewrite_test=20ORDER=20BY=20id;=0A+=20=20=20=20= SELECT=20reltuples=20FROM=20pg_class=20WHERE=20oid=20=3D=20= 'rewrite_test'::regclass;=0A+=0A+id|length|left=0A+--+------+----=0A+=20= 1|=20=202500|w=20=20=20=0A+=202|=20=202500|y=20=20=20=0A+(2=20rows)=0A+=0A= +reltuples=0A+---------=0A+=20=20=20=20=20=20=20=202=0A+(1=20row)=0A+=0A= +step=20s1_release:=20=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'COMMIT');=0A+=20=20=20=20SELECT=20dblink_disconnect('holder');=0A+=0A= +dblink_exec=0A+-----------=0A+COMMIT=20=20=20=20=20=0A+(1=20row)=0A+=0A= +dblink_disconnect=0A+-----------------=0A+OK=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+=0A+starting=20permutation:=20= s1_hold_xmin=20s2_begin=20s3_update=20s3_update_again=20= s3_vacuum_main_only=20s2_commit=20s3_vacuum_toast=20s3_cluster_sort=20= s3_check_rows=20s1_release=0A+step=20s1_hold_xmin:=20=0A+=20=20=20=20= SELECT=20dblink_connect('holder',=0A+=20=20=20=20=20=20=20=20= 'dbname=3Dregress_other_db=20port=3D'=20||=20current_setting('port'));=0A= +=20=20=20=20SELECT=20dblink_exec('holder',=20'BEGIN');=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20TABLE=20xid_holder(x=20= int)');=0A+=0A+dblink_connect=0A+--------------=0A+OK=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=0A+-----------=0A+BEGIN=20= =20=20=20=20=20=0A+(1=20row)=0A+=0A+dblink_exec=20=0A+------------=0A= +CREATE=20TABLE=0A+(1=20row)=0A+=0A+step=20s2_begin:=20=0A+=20=20=20=20= BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20=20SELECT=20= 1;=0A+=0A+?column?=0A+--------=0A+=20=20=20=20=20=20=201=0A+(1=20row)=0A= +=0A+step=20s3_update:=20=0A+=20=20=20=20UPDATE=20rewrite_test=20SET=20= data=20=3D=20repeat('z',=202500)=20WHERE=20id=20=3D=201;=0A+=0A+step=20= s3_update_again:=20=0A+=20=20=20=20UPDATE=20rewrite_test=20SET=20data=20= =3D=20repeat('w',=202500)=20WHERE=20id=20=3D=201;=0A+=0A+step=20= s3_vacuum_main_only:=20=0A+=20=20=20=20VACUUM=20(PROCESS_TOAST=20false)=20= rewrite_test;=0A+=0A+step=20s2_commit:=20COMMIT;=0A+step=20= s3_vacuum_toast:=20=0A+=20=20=20=20VACUUM=20pg_toast.rewrite_test_toast;=0A= +=0A+step=20s3_cluster_sort:=20=0A+=20=20=20=20SET=20enable_indexscan=20= =3D=20off;=0A+=20=20=20=20CLUSTER=20rewrite_test=20USING=20= rewrite_test_pkey;=0A+=20=20=20=20RESET=20enable_indexscan;=0A+=0A+step=20= s3_check_rows:=20=0A+=20=20=20=20SELECT=20id,=20length(data),=20= left(data,=201)=20FROM=20rewrite_test=20ORDER=20BY=20id;=0A+=20=20=20=20= SELECT=20reltuples=20FROM=20pg_class=20WHERE=20oid=20=3D=20= 'rewrite_test'::regclass;=0A+=0A+id|length|left=0A+--+------+----=0A+=20= 1|=20=202500|w=20=20=20=0A+=202|=20=202500|y=20=20=20=0A+(2=20rows)=0A+=0A= +reltuples=0A+---------=0A+=20=20=20=20=20=20=20=202=0A+(1=20row)=0A+=0A= +step=20s1_release:=20=0A+=20=20=20=20SELECT=20dblink_exec('holder',=20= 'COMMIT');=0A+=20=20=20=20SELECT=20dblink_disconnect('holder');=0A+=0A= +dblink_exec=0A+-----------=0A+COMMIT=20=20=20=20=20=0A+(1=20row)=0A+=0A= +dblink_disconnect=0A+-----------------=0A+OK=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=0A+(1=20row)=0A+=0Adiff=20--git=20= a/contrib/dblink/meson.build=20b/contrib/dblink/meson.build=0Aindex=20= e2489f41229..86fbd372b88=20100644=0A---=20a/contrib/dblink/meson.build=0A= +++=20b/contrib/dblink/meson.build=0A@@=20-36,6=20+36,11=20@@=20tests=20= +=3D=20{=0A=20=20=20=20=20],=0A=20=20=20=20=20'regress_args':=20= ['--dlpath',=20meson.project_build_root()=20/=20'src/test/regress'],=0A=20= =20=20},=0A+=20=20'isolation':=20{=0A+=20=20=20=20'specs':=20[=0A+=20=20=20= =20=20=20'rewrite_stale_xmin',=0A+=20=20=20=20],=0A+=20=20},=0A=20=20=20= 'tap':=20{=0A=20=20=20=20=20'tests':=20[=0A=20=20=20=20=20=20=20= 't/001_auth_scram.pl',=0Adiff=20--git=20= a/contrib/dblink/specs/rewrite_stale_xmin.spec=20= b/contrib/dblink/specs/rewrite_stale_xmin.spec=0Anew=20file=20mode=20= 100644=0Aindex=2000000000000..63ba262f359=0A---=20/dev/null=0A+++=20= b/contrib/dblink/specs/rewrite_stale_xmin.spec=0A@@=20-0,0=20+1,249=20@@=0A= +#=20Test=20that=20heap=20rewrites=20and=20index=20builds=20cope=20with=20= RECENTLY_DEAD=20tuples=0A+#=20whose=20TOAST=20data=20has=20already=20= been=20removed.=0A+#=0A+#=20A=20transaction=20in=20another=20database=20= holds=20back=20the=20xmin=20of=20the=20rewriting=0A+#=20backend,=20but=20= not=20the=20removal=20horizon=20of=20this=20database.=20=20The=20main=20= table=20and=0A+#=20its=20TOAST=20table=20are=20vacuumed=20separately,=20= with=20a=20same-database=20snapshot=20that=0A+#=20keeps=20the=20dead=20= tuple=20released=20in=20between,=20so=20the=20tuple=20survives=20while=20= its=0A+#=20TOAST=20chunks=20are=20removed.=0A+=0A+setup=0A+{=0A+=20=20=20= =20CREATE=20DATABASE=20regress_other_db;=0A+}=0A+=0A+setup=0A+{=0A+=20=20= =20=20CREATE=20EXTENSION=20IF=20NOT=20EXISTS=20dblink;=0A+=0A+=20=20=20=20= CREATE=20TABLE=20rewrite_test=20(id=20int=20PRIMARY=20KEY,=20data=20= text)=0A+=20=20=20=20=20=20=20=20WITH=20(autovacuum_enabled=20=3D=20= off);=0A+=20=20=20=20ALTER=20TABLE=20rewrite_test=20ALTER=20COLUMN=20= data=20SET=20STORAGE=20EXTERNAL;=0A+=20=20=20=20INSERT=20INTO=20= rewrite_test=20VALUES=20(1,=20repeat('x',=202500));=0A+=20=20=20=20= INSERT=20INTO=20rewrite_test=20VALUES=20(2,=20repeat('y',=202500));=0A+=0A= +=20=20=20=20--=20Rename=20the=20toast=20table=20to=20a=20known=20name=20= so=20we=20can=20VACUUM=20it=20directly.=0A+=20=20=20=20SET=20= allow_system_table_mods=20TO=20true;=0A+=20=20=20=20DO=20$$DECLARE=20r=20= record;=0A+=20=20=20=20=20=20BEGIN=0A+=20=20=20=20=20=20=20=20SELECT=20= INTO=20r=20reltoastrelid::regclass::text=20AS=20table_name=0A+=20=20=20=20= =20=20=20=20=20=20FROM=20pg_class=20WHERE=20oid=20=3D=20= 'rewrite_test'::regclass;=0A+=20=20=20=20=20=20=20=20EXECUTE=20'ALTER=20= TABLE=20'=20||=20r.table_name=20||=20'=20RENAME=20TO=20= rewrite_test_toast;';=0A+=20=20=20=20=20=20END$$;=0A+=20=20=20=20RESET=20= allow_system_table_mods;=0A+}=0A+=0A+teardown=0A+{=0A+=20=20=20=20DROP=20= DATABASE=20regress_other_db;=0A+}=0A+=0A+#=20Session=20s1:=20use=20= dblink=20to=20hold=20a=20transaction=20in=20another=20database.=0A+#=20= This=20must=20start=20before=20the=20DELETE=20so=20its=20XID=20is=20= older,=20ensuring=0A+#=20GetSnapshotData()=20holds=20back=20any=20= rewrites.=0A+session=20s1=0A+step=20s1_hold_xmin=0A+{=0A+=20=20=20=20= SELECT=20dblink_connect('holder',=0A+=20=20=20=20=20=20=20=20= 'dbname=3Dregress_other_db=20port=3D'=20||=20current_setting('port'));=0A= +=20=20=20=20SELECT=20dblink_exec('holder',=20'BEGIN');=0A+=20=20=20=20= SELECT=20dblink_exec('holder',=20'CREATE=20TEMP=20TABLE=20xid_holder(x=20= int)');=0A+}=0A+step=20s1_release=0A+{=0A+=20=20=20=20SELECT=20= dblink_exec('holder',=20'COMMIT');=0A+=20=20=20=20SELECT=20= dblink_disconnect('holder');=0A+}=0A+=0A+#=20Session=20s2:=20holds=20= xmin=20in=20the=20SAME=20database=20temporarily,=20so=20the=0A+#=20= main-table=20vacuum=20preserves=20the=20dead=20tuple=20as=20= RECENTLY_DEAD.=0A+session=20s2=0A+step=20s2_begin=0A+{=0A+=20=20=20=20= BEGIN=20ISOLATION=20LEVEL=20REPEATABLE=20READ;=0A+=20=20=20=20SELECT=20= 1;=0A+}=0A+step=20s2_commit=20{=20COMMIT;=20}=0A+=0A+#=20Session=20s3:=20= performs=20DML,=20split=20vacuum,=20and=20the=20rewrite.=0A+session=20s3=0A= +step=20s3_delete=0A+{=0A+=20=20=20=20DELETE=20FROM=20rewrite_test=20= WHERE=20id=20=3D=201;=0A+}=0A+step=20s3_update=0A+{=0A+=20=20=20=20= UPDATE=20rewrite_test=20SET=20data=20=3D=20repeat('z',=202500)=20WHERE=20= id=20=3D=201;=0A+}=0A+step=20s3_update_again=0A+{=0A+=20=20=20=20UPDATE=20= rewrite_test=20SET=20data=20=3D=20repeat('w',=202500)=20WHERE=20id=20=3D=20= 1;=0A+}=0A+step=20s3_check_rows=0A+{=0A+=20=20=20=20SELECT=20id,=20= length(data),=20left(data,=201)=20FROM=20rewrite_test=20ORDER=20BY=20id;=0A= +=20=20=20=20SELECT=20reltuples=20FROM=20pg_class=20WHERE=20oid=20=3D=20= 'rewrite_test'::regclass;=0A+}=0A+step=20s3_vacuum_main_only=0A+{=0A+=20=20= =20=20VACUUM=20(PROCESS_TOAST=20false)=20rewrite_test;=0A+}=0A+step=20= s3_vacuum_toast=0A+{=0A+=20=20=20=20VACUUM=20= pg_toast.rewrite_test_toast;=0A+}=0A+step=20s3_cluster=0A+{=0A+=20=20=20=20= CLUSTER=20rewrite_test=20USING=20rewrite_test_pkey;=0A+}=0A+#=20Use=20= the=20seqscan-and-sort=20strategy,=20which=20fetches=20TOAST=20data=20= before=20sorting=0A+step=20s3_cluster_sort=0A+{=0A+=20=20=20=20SET=20= enable_indexscan=20=3D=20off;=0A+=20=20=20=20CLUSTER=20rewrite_test=20= USING=20rewrite_test_pkey;=0A+=20=20=20=20RESET=20enable_indexscan;=0A+}=0A= +step=20s3_vacuum_full=0A+{=0A+=20=20=20=20VACUUM=20FULL=20rewrite_test;=0A= +}=0A+step=20s3_repack=0A+{=0A+=20=20=20=20REPACK=20rewrite_test;=0A+}=0A= +step=20s3_create_index=0A+{=0A+=20=20=20=20CREATE=20INDEX=20= rewrite_test_data_idx=20ON=20rewrite_test=20(data);=0A+}=0A+step=20= s3_create_index_wholerow=0A+{=0A+=20=20=20=20CREATE=20INDEX=20= rewrite_test_row_idx=20ON=20rewrite_test=20((rewrite_test=20IS=20NOT=20= NULL));=0A+}=0A+=0A+teardown=20{=20DROP=20TABLE=20IF=20EXISTS=20= rewrite_test;=20}=0A+=0A+#=20CLUSTER=0A+permutation=0A+=20=20=20=20= s1_hold_xmin=0A+=20=20=20=20s2_begin=0A+=20=20=20=20s3_delete=0A+=20=20=20= =20s3_vacuum_main_only=0A+=20=20=20=20s2_commit=0A+=20=20=20=20= s3_vacuum_toast=0A+=20=20=20=20s3_cluster=0A+=20=20=20=20s1_release=0A+=0A= +#=20CLUSTER,=20sorting=0A+permutation=0A+=20=20=20=20s1_hold_xmin=0A+=20= =20=20=20s2_begin=0A+=20=20=20=20s3_delete=0A+=20=20=20=20= s3_vacuum_main_only=0A+=20=20=20=20s2_commit=0A+=20=20=20=20= s3_vacuum_toast=0A+=20=20=20=20s3_cluster_sort=0A+=20=20=20=20= s3_check_rows=0A+=20=20=20=20s1_release=0A+=0A+#=20VACUUM=20FULL=0A= +permutation=0A+=20=20=20=20s1_hold_xmin=0A+=20=20=20=20s2_begin=0A+=20=20= =20=20s3_delete=0A+=20=20=20=20s3_vacuum_main_only=0A+=20=20=20=20= s2_commit=0A+=20=20=20=20s3_vacuum_toast=0A+=20=20=20=20s3_vacuum_full=0A= +=20=20=20=20s1_release=0A+=0A+#=20REPACK=0A+permutation=0A+=20=20=20=20= s1_hold_xmin=0A+=20=20=20=20s2_begin=0A+=20=20=20=20s3_delete=0A+=20=20=20= =20s3_vacuum_main_only=0A+=20=20=20=20s2_commit=0A+=20=20=20=20= s3_vacuum_toast=0A+=20=20=20=20s3_repack=0A+=20=20=20=20s1_release=0A+=0A= +#=20CREATE=20INDEX=0A+permutation=0A+=20=20=20=20s1_hold_xmin=0A+=20=20=20= =20s2_begin=0A+=20=20=20=20s3_delete=0A+=20=20=20=20s3_vacuum_main_only=0A= +=20=20=20=20s2_commit=0A+=20=20=20=20s3_vacuum_toast=0A+=20=20=20=20= s3_create_index=0A+=20=20=20=20s1_release=0A+=0A+#=20CREATE=20INDEX=20on=20= a=20whole-row=20expression=0A+permutation=0A+=20=20=20=20s1_hold_xmin=0A= +=20=20=20=20s2_begin=0A+=20=20=20=20s3_delete=0A+=20=20=20=20= s3_vacuum_main_only=0A+=20=20=20=20s2_commit=0A+=20=20=20=20= s3_vacuum_toast=0A+=20=20=20=20s3_create_index_wholerow=0A+=20=20=20=20= s1_release=0A+=0A+#=20Preserve=20the=20live=20successor=20when=20a=20= stashed=20prior=20version=20loses=20its=20TOAST.=0A+permutation=0A+=20=20= =20=20s1_hold_xmin=0A+=20=20=20=20s2_begin=0A+=20=20=20=20s3_update=0A+=20= =20=20=20s3_vacuum_main_only=0A+=20=20=20=20s2_commit=0A+=20=20=20=20= s3_vacuum_toast=0A+=20=20=20=20s3_vacuum_full=0A+=20=20=20=20= s3_check_rows=0A+=20=20=20=20s1_release=0A+=0A+permutation=0A+=20=20=20=20= s1_hold_xmin=0A+=20=20=20=20s2_begin=0A+=20=20=20=20s3_update=0A+=20=20=20= =20s3_vacuum_main_only=0A+=20=20=20=20s2_commit=0A+=20=20=20=20= s3_vacuum_toast=0A+=20=20=20=20s3_repack=0A+=20=20=20=20s3_check_rows=0A= +=20=20=20=20s1_release=0A+=0A+permutation=0A+=20=20=20=20s1_hold_xmin=0A= +=20=20=20=20s2_begin=0A+=20=20=20=20s3_update=0A+=20=20=20=20= s3_update_again=0A+=20=20=20=20s3_vacuum_main_only=0A+=20=20=20=20= s2_commit=0A+=20=20=20=20s3_vacuum_toast=0A+=20=20=20=20s3_vacuum_full=0A= +=20=20=20=20s3_check_rows=0A+=20=20=20=20s1_release=0A+=0A+permutation=0A= +=20=20=20=20s1_hold_xmin=0A+=20=20=20=20s2_begin=0A+=20=20=20=20= s3_update=0A+=20=20=20=20s3_update_again=0A+=20=20=20=20= s3_vacuum_main_only=0A+=20=20=20=20s2_commit=0A+=20=20=20=20= s3_vacuum_toast=0A+=20=20=20=20s3_repack=0A+=20=20=20=20s3_check_rows=0A= +=20=20=20=20s1_release=0A+=0A+permutation=0A+=20=20=20=20s1_hold_xmin=0A= +=20=20=20=20s2_begin=0A+=20=20=20=20s3_update=0A+=20=20=20=20= s3_update_again=0A+=20=20=20=20s3_vacuum_main_only=0A+=20=20=20=20= s2_commit=0A+=20=20=20=20s3_vacuum_toast=0A+=20=20=20=20s3_cluster_sort=0A= +=20=20=20=20s3_check_rows=0A+=20=20=20=20s1_release=0Adiff=20--git=20= a/src/backend/access/common/detoast.c=20= b/src/backend/access/common/detoast.c=0Aindex=208223cc219c1..b27b6bb9780=20= 100644=0A---=20a/src/backend/access/common/detoast.c=0A+++=20= b/src/backend/access/common/detoast.c=0A@@=20-17,6=20+17,7=20@@=0A=20= #include=20"access/table.h"=0A=20#include=20"access/tableam.h"=0A=20= #include=20"access/toast_compression.h"=0A+#include=20= "access/toast_helper.h"=0A=20#include=20"access/toast_internals.h"=0A=20= #include=20"common/int.h"=0A=20#include=20"common/pg_lzcompress.h"=0A@@=20= -24,7=20+25,7=20@@=0A=20#include=20"utils/memutils.h"=0A=20#include=20= "utils/rel.h"=0A=20=0A-static=20varlena=20*toast_fetch_datum(varlena=20= *attr);=0A+static=20varlena=20*toast_fetch_datum(varlena=20*attr,=20= uint32=20flags);=0A=20static=20varlena=20= *toast_fetch_datum_slice(varlena=20*attr,=0A=20=09=09=09=09=09=09=09=09=09= =09int32=20sliceoffset,=0A=20=09=09=09=09=09=09=09=09=09=09int32=20= slicelength);=0A@@=20-61,7=20+62,7=20@@=20detoast_external_attr(varlena=20= *attr)=0A=20=09=09/*=0A=20=09=09=20*=20This=20is=20an=20external=20= stored=20plain=20value=0A=20=09=09=20*/=0A-=09=09result=20=3D=20= toast_fetch_datum(attr);=0A+=09=09result=20=3D=20toast_fetch_datum(attr,=20= 0);=0A=20=09}=0A=20=09else=20if=20(VARATT_IS_EXTERNAL_INDIRECT(attr))=0A=20= =09{=0A@@=20-112,6=20+113,24=20@@=20detoast_external_attr(varlena=20= *attr)=0A=20}=0A=20=0A=20=0A+/*=20----------=0A+=20*=20= detoast_external_attr_extended=20-=0A+=20*=0A+=20*=09Like=20= detoast_external_attr,=20but=20returns=20NULL=20instead=20of=20raising=20= an=0A+=20*=09error=20if=20the=20chunks=20of=20an=20on-disk=20value=20are=20= missing.=20=20Only=20meant=20for=0A+=20*=09RECENTLY_DEAD=20tuples,=20see=20= TOAST_MISSING_OK.=0A+=20*=20----------=0A+=20*/=0A+varlena=20*=0A= +detoast_external_attr_extended(varlena=20*attr)=0A+{=0A+=09if=20= (VARATT_IS_EXTERNAL_ONDISK(attr))=0A+=09=09return=20= toast_fetch_datum(attr,=20TOAST_MISSING_OK);=0A+=09else=0A+=09=09return=20= detoast_external_attr(attr);=0A+}=0A+=0A+=0A=20/*=20----------=0A=20=20*=20= detoast_attr=20-=0A=20=20*=0A@@=20-130,7=20+149,7=20@@=20= detoast_attr(varlena=20*attr)=0A=20=09=09/*=0A=20=09=09=20*=20This=20is=20= an=20externally=20stored=20datum=20---=20fetch=20it=20back=20from=20= there=0A=20=09=09=20*/=0A-=09=09attr=20=3D=20toast_fetch_datum(attr);=0A= +=09=09attr=20=3D=20toast_fetch_datum(attr,=200);=0A=20=09=09/*=20If=20= it's=20compressed,=20decompress=20it=20*/=0A=20=09=09if=20= (VARATT_IS_COMPRESSED(attr))=0A=20=09=09{=0A@@=20-277,7=20+296,7=20@@=20= detoast_attr_slice(varlena=20*attr,=0A=20=09=09=09preslice=20=3D=20= toast_fetch_datum_slice(attr,=200,=20max_size);=0A=20=09=09}=0A=20=09=09= else=0A-=09=09=09preslice=20=3D=20toast_fetch_datum(attr);=0A+=09=09=09= preslice=20=3D=20toast_fetch_datum(attr,=200);=0A=20=09}=0A=20=09else=20= if=20(VARATT_IS_EXTERNAL_INDIRECT(attr))=0A=20=09{=0A@@=20-352,10=20= +371,12=20@@=20detoast_attr_slice(varlena=20*attr,=0A=20=20*=0A=20=20*=09= Reconstruct=20an=20in=20memory=20Datum=20from=20the=20chunks=20saved=0A=20= =20*=09in=20the=20toast=20relation=0A+=20*=0A+=20*=09If=20flags=20= includes=20TOAST_MISSING_OK,=20returns=20NULL=20when=20chunks=20are=20= missing.=0A=20=20*=20----------=0A=20=20*/=0A=20static=20varlena=20*=0A= -toast_fetch_datum(varlena=20*attr)=0A+toast_fetch_datum(varlena=20= *attr,=20uint32=20flags)=0A=20{=0A=20=09Relation=09toastrel;=0A=20=09= varlena=20=20=20=20*result;=0A@@=20-389,8=20+410,14=20@@=20= toast_fetch_datum(varlena=20*attr)=0A=20=09toastrel=20=3D=20= table_open(toastrelid,=20AccessShareLock);=0A=20=0A=20=09/*=20Fetch=20= all=20chunks=20*/=0A-=09table_relation_fetch_toast_slice(toastrel,=20= valueid,=0A-=09=09=09=09=09=09=09=09=09=20attrsize,=200,=20attrsize,=20= result);=0A+=09if=20(!table_relation_fetch_toast_slice(toastrel,=20= valueid,=0A+=09=09=09=09=09=09=09=09=09=09=20=20attrsize,=200,=20= attrsize,=20result,=0A+=09=09=09=09=09=09=09=09=09=09=20=20flags))=0A+=09= {=0A+=09=09pfree(result);=0A+=09=09table_close(toastrel,=20= AccessShareLock);=0A+=09=09return=20NULL;=0A+=09}=0A=20=0A=20=09/*=20= Close=20toast=20table=20*/=0A=20=09table_close(toastrel,=20= AccessShareLock);=0A@@=20-475,7=20+502,7=20@@=20= toast_fetch_datum_slice(varlena=20*attr,=20int32=20sliceoffset,=0A=20=09= /*=20Fetch=20all=20chunks=20*/=0A=20=09= table_relation_fetch_toast_slice(toastrel,=20valueid,=0A=20=09=09=09=09=09= =09=09=09=09=20attrsize,=20sliceoffset,=20slicelength,=0A-=09=09=09=09=09= =09=09=09=09=20result);=0A+=09=09=09=09=09=09=09=09=09=20result,=200);=0A= =20=0A=20=09/*=20Close=20toast=20table=20*/=0A=20=09= table_close(toastrel,=20AccessShareLock);=0Adiff=20--git=20= a/src/backend/access/heap/heapam.c=20b/src/backend/access/heap/heapam.c=0A= index=203bb33699349..0b3c4ae85ed=20100644=0A---=20= a/src/backend/access/heap/heapam.c=0A+++=20= b/src/backend/access/heap/heapam.c=0A@@=20-2266,7=20+2266,7=20@@=20= heap_prepare_insert(Relation=20relation,=20HeapTuple=20tup,=20= TransactionId=20xid,=0A=20=09=09return=20tup;=0A=20=09}=0A=20=09else=20= if=20(HeapTupleHasExternal(tup)=20||=20tup->t_len=20>=20= TOAST_TUPLE_THRESHOLD)=0A-=09=09return=20= heap_toast_insert_or_update(relation,=20tup,=20NULL,=20options);=0A+=09=09= return=20heap_toast_insert_or_update(relation,=20tup,=20NULL,=20options,=20= 0);=0A=20=09else=0A=20=09=09return=20tup;=0A=20}=0A@@=20-3983,7=20= +3983,7=20@@=20l2:=0A=20=09=09=09=20*=20tuples=20too.=20We=20never=20= skip=20the=20FSM=20here.=0A=20=09=09=09=20*/=0A=20=09=09=09heaptup=20=3D=20= heap_toast_insert_or_update(relation,=20newtup,=20&oldtup,=0A-=09=09=09=09= =09=09=09=09=09=09=09=09=20=20walLogical=20?=200=20:=20= HEAP_INSERT_NO_LOGICAL);=0A+=09=09=09=09=09=09=09=09=09=09=09=09=20=20= walLogical=20?=200=20:=20HEAP_INSERT_NO_LOGICAL,=200);=0A=20=09=09=09= newtupsize=20=3D=20MAXALIGN(heaptup->t_len);=0A=20=09=09}=0A=20=09=09= else=0Adiff=20--git=20a/src/backend/access/heap/heapam_handler.c=20= b/src/backend/access/heap/heapam_handler.c=0Aindex=20= 05a81e4557a..bc10b4fe891=20100644=0A---=20= a/src/backend/access/heap/heapam_handler.c=0A+++=20= b/src/backend/access/heap/heapam_handler.c=0A@@=20-19,6=20+19,7=20@@=0A=20= =20*/=0A=20#include=20"postgres.h"=0A=20=0A+#include=20= "access/detoast.h"=0A=20#include=20"access/genam.h"=0A=20#include=20= "access/heapam.h"=0A=20#include=20"access/heaptoast.h"=0A@@=20-26,6=20= +27,7=20@@=0A=20#include=20"access/rewriteheap.h"=0A=20#include=20= "access/syncscan.h"=0A=20#include=20"access/tableam.h"=0A+#include=20= "access/toast_helper.h"=0A=20#include=20"access/tsmapi.h"=0A=20#include=20= "access/visibilitymap.h"=0A=20#include=20"access/xact.h"=0A@@=20-36,6=20= +38,7=20@@=0A=20#include=20"commands/progress.h"=0A=20#include=20= "executor/executor.h"=0A=20#include=20"miscadmin.h"=0A+#include=20= "optimizer/optimizer.h"=0A=20#include=20"pgstat.h"=0A=20#include=20= "storage/bufmgr.h"=0A=20#include=20"storage/bufpage.h"=0A@@=20-48,9=20= +51,14=20@@=0A=20#include=20"utils/rel.h"=0A=20#include=20= "utils/tuplesort.h"=0A=20=0A-static=20void=20= reform_and_rewrite_tuple(HeapTuple=20tuple,=0A+static=20bool=20= reform_and_rewrite_tuple(HeapTuple=20tuple,=0A=20=09=09=09=09=09=09=09=09= =09=20Relation=20OldHeap,=20Relation=20NewHeap,=0A-=09=09=09=09=09=09=09=09= =09=20Datum=20*values,=20bool=20*isnull,=20RewriteState=20rwstate);=0A+=09= =09=09=09=09=09=09=09=09=20Datum=20*values,=20bool=20*isnull,=20= RewriteState=20rwstate,=0A+=09=09=09=09=09=09=09=09=09=20bool=20= recently_dead);=0A+static=20HeapTuple=20= heap_inline_recently_dead_toast(HeapTuple=20tuple,=0A+=09=09=09=09=09=09=09= =09=09=09=09=09=20TupleDesc=20tupdesc,=0A+=09=09=09=09=09=09=09=09=09=09=09= =09=20const=20Bitmapset=20*attrs,=0A+=09=09=09=09=09=09=09=09=09=09=09=09= =20Datum=20*values,=20bool=20*isnull);=0A=20static=20void=20= heap_insert_for_repack(HeapTuple=20tuple,=20Relation=20OldHeap,=0A=20=09=09= =09=09=09=09=09=09=20=20=20Relation=20NewHeap,=20Datum=20*values,=20bool=20= *isnull,=0A=20=09=09=09=09=09=09=09=09=20=20=20BulkInsertState=20= bistate);=0A@@=20-703,6=20+711,7=20@@=20= heapam_relation_copy_for_cluster(Relation=20OldHeap,=20Relation=20= NewHeap,=0A=20=09=09HeapTuple=09tuple;=0A=20=09=09Buffer=09=09buf;=0A=20=09= =09bool=09=09isdead;=0A+=09=09bool=09=09recently_dead=20=3D=20false;=0A=20= =0A=20=09=09CHECK_FOR_INTERRUPTS();=0A=20=0A@@=20-789,6=20+798,7=20@@=20= heapam_relation_copy_for_cluster(Relation=20OldHeap,=20Relation=20= NewHeap,=0A=20=09=09=09=09=09break;=0A=20=09=09=09=09case=20= HEAPTUPLE_RECENTLY_DEAD:=0A=20=09=09=09=09=09*tups_recently_dead=20+=3D=20= 1;=0A+=09=09=09=09=09recently_dead=20=3D=20true;=0A=20=09=09=09=09=09= pg_fallthrough;=0A=20=09=09=09=09case=20HEAPTUPLE_LIVE:=0A=20=09=09=09=09= =09/*=20Live=20or=20recently=20dead,=20must=20copy=20it=20*/=0A@@=20= -822,6=20+832,7=20@@=20heapam_relation_copy_for_cluster(Relation=20= OldHeap,=20Relation=20NewHeap,=0A=20=09=09=09=09=09=09=09=20= RelationGetRelationName(OldHeap));=0A=20=09=09=09=09=09/*=20treat=20as=20= recently=20dead=20*/=0A=20=09=09=09=09=09*tups_recently_dead=20+=3D=201;=0A= +=09=09=09=09=09recently_dead=20=3D=20true;=0A=20=09=09=09=09=09isdead=20= =3D=20false;=0A=20=09=09=09=09=09break;=0A=20=09=09=09=09default:=0A@@=20= -850,7=20+861,30=20@@=20heapam_relation_copy_for_cluster(Relation=20= OldHeap,=20Relation=20NewHeap,=0A=20=09=09*num_tuples=20+=3D=201;=0A=20=09= =09if=20(tuplesort=20!=3D=20NULL)=0A=20=09=09{=0A-=09=09=09= tuplesort_putheaptuple(tuplesort,=20tuple);=0A+=09=09=09HeapTuple=09= sorttup=20=3D=20tuple;=0A+=0A+=09=09=09/*=0A+=09=09=09=20*=20The=20= tuples=20are=20written=20out=20only=20after=20the=20sort,=20by=20which=20= time=0A+=09=09=09=20*=20the=20TOAST=20data=20of=20a=20recently-dead=20= tuple=20may=20be=20gone,=20so=20fetch=0A+=09=09=09=20*=20it=20now.=20=20= If=20it=20is=20already=20gone,=20the=20tuple=20is=20dead=20to=20everyone=0A= +=09=09=09=20*=20who=20could=20still=20read=20it,=20so=20skip=20it.=0A+=09= =09=09=20*/=0A+=09=09=09if=20(recently_dead=20&&=20= HeapTupleHasExternal(tuple))=0A+=09=09=09{=0A+=09=09=09=09sorttup=20=3D=20= heap_inline_recently_dead_toast(tuple,=20oldTupDesc,=0A+=09=09=09=09=09=09= =09=09=09=09=09=09=09=09=20=20NULL,=20values,=20isnull);=0A+=09=09=09=09= if=20(sorttup=20=3D=3D=20NULL)=0A+=09=09=09=09{=0A+=09=09=09=09=09= *tups_vacuumed=20+=3D=201;=0A+=09=09=09=09=09*num_tuples=20-=3D=201;=0A+=09= =09=09=09=09*tups_recently_dead=20-=3D=201;=0A+=09=09=09=09=09continue;=0A= +=09=09=09=09}=0A+=09=09=09}=0A+=0A+=09=09=09= tuplesort_putheaptuple(tuplesort,=20sorttup);=0A+=09=09=09if=20(sorttup=20= !=3D=20tuple)=0A+=09=09=09=09heap_freetuple(sorttup);=0A=20=0A=20=09=09=09= /*=0A=20=09=09=09=20*=20In=20scan-and-sort=20mode,=20report=20increase=20= in=20number=20of=20tuples=0A@@=20-868,8=20+902,19=20@@=20= heapam_relation_copy_for_cluster(Relation=20OldHeap,=20Relation=20= NewHeap,=0A=20=09=09=09int64=09=09ct_val[2];=0A=20=0A=20=09=09=09if=20= (!concurrent)=0A-=09=09=09=09reform_and_rewrite_tuple(tuple,=20OldHeap,=20= NewHeap,=0A-=09=09=09=09=09=09=09=09=09=09=20values,=20isnull,=20= rwstate);=0A+=09=09=09{=0A+=09=09=09=09if=20= (!reform_and_rewrite_tuple(tuple,=20OldHeap,=20NewHeap,=0A+=09=09=09=09=09= =09=09=09=09=09=09=20=20values,=20isnull,=20rwstate,=0A+=09=09=09=09=09=09= =09=09=09=09=09=20=20recently_dead))=0A+=09=09=09=09{=0A+=09=09=09=09=09= /*=20TOAST=20data=20of=20a=20recently-dead=20tuple=20is=20gone=20*/=0A+=09= =09=09=09=09Assert(recently_dead);=0A+=09=09=09=09=09*tups_vacuumed=20+=3D= =201;=0A+=09=09=09=09=09*num_tuples=20-=3D=201;=0A+=09=09=09=09=09= *tups_recently_dead=20-=3D=201;=0A+=09=09=09=09=09continue;=0A+=09=09=09=09= }=0A+=09=09=09}=0A=20=09=09=09else=0A=20=09=09=09=09= heap_insert_for_repack(tuple,=20OldHeap,=20NewHeap,=0A=20=09=09=09=09=09=09= =09=09=09=20=20=20values,=20isnull,=20bistate);=0A@@=20-920,11=20+965,12=20= @@=20heapam_relation_copy_for_cluster(Relation=20OldHeap,=20Relation=20= NewHeap,=0A=20=09=09=09=09break;=0A=20=0A=20=09=09=09n_tuples=20+=3D=20= 1;=0A+=09=09=09/*=20TOAST=20data=20of=20recently-dead=20tuples=20was=20= inlined=20before=20the=20sort=20*/=0A=20=09=09=09if=20(!concurrent)=0A-=09= =09=09=09reform_and_rewrite_tuple(tuple,=0A-=09=09=09=09=09=09=09=09=09=09= =20OldHeap,=20NewHeap,=0A-=09=09=09=09=09=09=09=09=09=09=20values,=20= isnull,=0A-=09=09=09=09=09=09=09=09=09=09=20rwstate);=0A+=09=09=09=09= (void)=20reform_and_rewrite_tuple(tuple,=0A+=09=09=09=09=09=09=09=09=09=09= =09=09OldHeap,=20NewHeap,=0A+=09=09=09=09=09=09=09=09=09=09=09=09values,=20= isnull,=0A+=09=09=09=09=09=09=09=09=09=09=09=09rwstate,=20false);=0A=20=09= =09=09else=0A=20=09=09=09=09heap_insert_for_repack(tuple,=20OldHeap,=20= NewHeap,=0A=20=09=09=09=09=09=09=09=09=09=20=20=20values,=20isnull,=20= bistate);=0A@@=20-939,7=20+985,14=20@@=20= heapam_relation_copy_for_cluster(Relation=20OldHeap,=20Relation=20= NewHeap,=0A=20=0A=20=09/*=20Write=20out=20any=20remaining=20tuples,=20= and=20fsync=20if=20needed=20*/=0A=20=09if=20(rwstate)=0A-=09=09= end_heap_rewrite(rwstate);=0A+=09{=0A+=09=09double=09=09tuples_dropped=20= =3D=20end_heap_rewrite(rwstate);=0A+=0A+=09=09/*=20Stashed=20tuples=20= with=20missing=20TOAST=20were=20scanned=20as=20recently=20dead.=20*/=0A+=09= =09*tups_vacuumed=20+=3D=20tuples_dropped;=0A+=09=09*num_tuples=20-=3D=20= tuples_dropped;=0A+=09=09*tups_recently_dead=20-=3D=20tuples_dropped;=0A= +=09}=0A=20=09if=20(bistate)=0A=20=09=09FreeBulkInsertState(bistate);=0A=20= =0A@@=20-1156,6=20+1209,9=20@@=20heapam_index_build_range_scan(Relation=20= heapRelation,=0A=20=09BlockNumber=20previous_blkno=20=3D=20= InvalidBlockNumber;=0A=20=09BlockNumber=20root_blkno=20=3D=20= InvalidBlockNumber;=0A=20=09OffsetNumber=20= root_offsets[MaxHeapTuplesPerPage];=0A+=09Bitmapset=20=20= *detoast_index_attrs=20=3D=20NULL;=0A+=09Datum=09=20=20=20*inline_values=20= =3D=20NULL;=0A+=09bool=09=20=20=20*inline_isnull=20=3D=20NULL;=0A=20=0A=20= =09/*=0A=20=09=20*=20sanity=20checks=0A@@=20-1252,6=20+1308,50=20@@=20= heapam_index_build_range_scan(Relation=20heapRelation,=0A=20=09=09=20=20=20= !TransactionIdIsValid(OldestXmin));=0A=20=09Assert(snapshot=20=3D=3D=20= SnapshotAny=20||=20!anyvisible);=0A=20=0A+=09/*=0A+=09=20*=20Collect=20= the=20varlena=20columns=20that=20the=20index=20columns,=20expressions=20= and=0A+=09=20*=20predicate=20reference,=20so=20that=20their=20TOAST=20= data=20can=20be=20fetched=20for=0A+=09=20*=20RECENTLY_DEAD=20tuples;=20= see=20below.=20=20A=20whole-row=20reference=20needs=20all=20of=0A+=09=20= *=20them.=20=20The=20set=20contains=20plain=20attribute=20numbers.=0A+=09= =20*/=0A+=09{=0A+=09=09TupleDesc=09desc=20=3D=20= RelationGetDescr(heapRelation);=0A+=09=09Bitmapset=20=20*refattrs=20=3D=20= NULL;=0A+=09=09bool=09=09wholerow;=0A+=0A+=09=09for=20(int=20i=20=3D=20= 0;=20i=20<=20indexInfo->ii_NumIndexAttrs;=20i++)=0A+=09=09{=0A+=09=09=09= AttrNumber=09attnum=20=3D=20indexInfo->ii_IndexAttrNumbers[i];=0A+=0A+=09= =09=09if=20(attnum=20!=3D=200)=0A+=09=09=09=09refattrs=20=3D=20= bms_add_member(refattrs,=0A+=09=09=09=09=09=09=09=09=09=09=20=20attnum=20= -=20FirstLowInvalidHeapAttributeNumber);=0A+=09=09}=0A+=09=09= pull_varattnos((Node=20*)=20indexInfo->ii_Expressions,=201,=20= &refattrs);=0A+=09=09pull_varattnos((Node=20*)=20= indexInfo->ii_Predicate,=201,=20&refattrs);=0A+=0A+=09=09wholerow=20=3D=20= bms_is_member(InvalidAttrNumber=20-=20= FirstLowInvalidHeapAttributeNumber,=0A+=09=09=09=09=09=09=09=09=20= refattrs);=0A+=0A+=09=09for=20(AttrNumber=20attnum=20=3D=201;=20attnum=20= <=3D=20desc->natts;=20attnum++)=0A+=09=09{=0A+=09=09=09if=20= (TupleDescCompactAttr(desc,=20attnum=20-=201)->attlen=20!=3D=20-1)=0A+=09= =09=09=09continue;=0A+=09=09=09if=20(wholerow=20||=0A+=09=09=09=09= bms_is_member(attnum=20-=20FirstLowInvalidHeapAttributeNumber,=0A+=09=09=09= =09=09=09=09=20=20refattrs))=0A+=09=09=09=09detoast_index_attrs=20=3D=20= bms_add_member(detoast_index_attrs,=0A+=09=09=09=09=09=09=09=09=09=09=09=09= =09=20attnum);=0A+=09=09}=0A+=09=09bms_free(refattrs);=0A+=0A+=09=09if=20= (detoast_index_attrs=20!=3D=20NULL)=0A+=09=09{=0A+=09=09=09inline_values=20= =3D=20palloc_array(Datum,=20desc->natts);=0A+=09=09=09inline_isnull=20=3D=20= palloc_array(bool,=20desc->natts);=0A+=09=09}=0A+=09}=0A+=0A=20=09/*=20= Publish=20number=20of=20blocks=20to=20scan=20*/=0A=20=09if=20(progress)=0A= =20=09{=0A@@=20-1590,6=20+1690,29=20@@=20= heapam_index_build_range_scan(Relation=20heapRelation,=0A=20=09=09/*=20= Set=20up=20for=20predicate=20or=20expression=20evaluation=20*/=0A=20=09=09= ExecStoreBufferHeapTuple(heapTuple,=20slot,=20hscan->rs_cbuf);=0A=20=0A+=09= =09/*=0A+=09=09=20*=20The=20TOAST=20data=20of=20a=20RECENTLY_DEAD=20= tuple=20can=20be=20removed=20while=20we=0A+=09=09=20*=20look=20at=20it;=20= see=20heap_inline_recently_dead_toast().=20=20Fetch=20what=20the=0A+=09=09= =20*=20index=20needs=20up=20front,=20and=20skip=20the=20tuple=20if=20it=20= is=20already=20gone.=0A+=09=09=20*/=0A+=09=09if=20(!tupleIsAlive=20&&=20= detoast_index_attrs=20!=3D=20NULL=20&&=0A+=09=09=09= HeapTupleHasExternal(heapTuple))=0A+=09=09{=0A+=09=09=09HeapTuple=09= inlined;=0A+=0A+=09=09=09inlined=20=3D=20= heap_inline_recently_dead_toast(heapTuple,=0A+=09=09=09=09=09=09=09=09=09= =09=09=09=09=20=20RelationGetDescr(heapRelation),=0A+=09=09=09=09=09=09=09= =09=09=09=09=09=09=20=20detoast_index_attrs,=0A+=09=09=09=09=09=09=09=09=09= =09=09=09=09=20=20inline_values,=20inline_isnull);=0A+=09=09=09if=20= (inlined=20=3D=3D=20NULL)=0A+=09=09=09=09continue;=0A+=09=09=09if=20= (inlined=20!=3D=20heapTuple)=0A+=09=09=09{=0A+=09=09=09=09= ExecForceStoreHeapTuple(inlined,=20slot,=20true);=0A+=09=09=09=09= slot->tts_tableOid=20=3D=20RelationGetRelid(heapRelation);=0A+=09=09=09}=0A= +=09=09}=0A+=0A=20=09=09/*=0A=20=09=09=20*=20In=20a=20partial=20index,=20= discard=20tuples=20that=20don't=20satisfy=20the=0A=20=09=09=20*=20= predicate.=0A@@=20-1698,6=20+1821,12=20@@=20= heapam_index_build_range_scan(Relation=20heapRelation,=0A=20=09= indexInfo->ii_ExpressionsState=20=3D=20NIL;=0A=20=09= indexInfo->ii_PredicateState=20=3D=20NULL;=0A=20=0A+=09= bms_free(detoast_index_attrs);=0A+=09if=20(inline_values)=0A+=09=09= pfree(inline_values);=0A+=09if=20(inline_isnull)=0A+=09=09= pfree(inline_isnull);=0A+=0A=20=09return=20reltuples;=0A=20}=0A=20=0A@@=20= -2338,20=20+2467,105=20@@=20heapam_scan_sample_next_tuple(TableScanDesc=20= scan,=20SampleScanState=20*scanstate,=0A=20=20*=20SET=20WITHOUT=20OIDS.=0A= =20=20*=0A=20=20*=20So,=20we=20must=20reconstruct=20the=20tuple=20from=20= component=20Datums.=0A+=20*=0A+=20*=20recently_dead=20must=20be=20set=20= if=20the=20tuple=20is=20RECENTLY_DEAD.=20=20Returns=20false=20if=0A+=20*=20= the=20tuple=20was=20skipped=20because=20its=20TOAST=20data=20is=20gone;=20= see=0A+=20*=20rewrite_heap_tuple().=0A=20=20*/=0A-static=20void=0A= +static=20bool=0A=20reform_and_rewrite_tuple(HeapTuple=20tuple,=0A=20=09=09= =09=09=09=09=20Relation=20OldHeap,=20Relation=20NewHeap,=0A-=09=09=09=09=09= =09=20Datum=20*values,=20bool=20*isnull,=20RewriteState=20rwstate)=0A+=09= =09=09=09=09=09=20Datum=20*values,=20bool=20*isnull,=20RewriteState=20= rwstate,=0A+=09=09=09=09=09=09=20bool=20recently_dead)=0A=20{=0A=20=09= HeapTuple=09newtuple;=0A+=09bool=09=09written;=0A=20=0A=20=09newtuple=20= =3D=20reform_tuple(tuple,=20OldHeap,=20NewHeap,=20values,=20isnull);=0A=20= =0A=20=09/*=20The=20heap=20rewrite=20module=20does=20the=20rest=20*/=0A-=09= rewrite_heap_tuple(rwstate,=20tuple,=20newtuple);=0A+=09written=20=3D=20= rewrite_heap_tuple(rwstate,=20tuple,=20newtuple,=20recently_dead);=0A=20=0A= =20=09heap_freetuple(newtuple);=0A+=09return=20written;=0A+}=0A+=0A+/*=0A= +=20*=20Fetch=20the=20out-of-line=20TOAST=20values=20of=20a=20= RECENTLY_DEAD=20tuple,=20and=20return=20a=0A+=20*=20copy=20of=20the=20= tuple=20with=20those=20values=20stored=20inline,=20keeping=20the=20= original=0A+=20*=20tuple's=20identity=20and=20visibility=20information.=0A= +=20*=0A+=20*=20Other=20backends=20may=20already=20consider=20a=20= RECENTLY_DEAD=20tuple=20fully=20dead,=20so=0A+=20*=20its=20TOAST=20data=20= can=20be=20removed=20by=20VACUUM=20or=20pruning=20of=20the=20TOAST=20= relation=20at=0A+=20*=20any=20time.=20=20If=20any=20value=20is=20already=20= gone,=20return=20NULL:=20nobody=20can=20see=20the=0A+=20*=20tuple=20= anymore,=20and=20the=20caller=20should=20treat=20it=20as=20dead.=0A+=20*=0A= +=20*=20attrs=20is=20the=20set=20of=20attribute=20numbers=20to=20fetch,=20= or=20NULL=20for=20all=20of=20them.=0A+=20*=20Returns=20the=20tuple=20= itself=20if=20there=20is=20nothing=20to=20fetch.=20=20values=20and=20= isnull=0A+=20*=20are=20caller-provided=20workspace=20of=20tupdesc->natts=20= entries.=0A+=20*/=0A+static=20HeapTuple=0A= +heap_inline_recently_dead_toast(HeapTuple=20tuple,=20TupleDesc=20= tupdesc,=0A+=09=09=09=09=09=09=09=09const=20Bitmapset=20*attrs,=0A+=09=09= =09=09=09=09=09=09Datum=20*values,=20bool=20*isnull)=0A+{=0A+=09= Bitmapset=20=20*fetched=20=3D=20NULL;=0A+=09HeapTuple=09result=20=3D=20= NULL;=0A+=09int=09=09=09i;=0A+=0A+=09heap_deform_tuple(tuple,=20tupdesc,=20= values,=20isnull);=0A+=0A+=09for=20(i=20=3D=200;=20i=20<=20= tupdesc->natts;=20i++)=0A+=09{=0A+=09=09CompactAttribute=20*att=20=3D=20= TupleDescCompactAttr(tupdesc,=20i);=0A+=09=09varlena=20=20=20=20*value;=0A= +=0A+=09=09if=20(att->attlen=20!=3D=20-1=20||=20isnull[i])=0A+=09=09=09= continue;=0A+=09=09if=20(attrs=20!=3D=20NULL=20&&=20!bms_is_member(i=20+=20= 1,=20attrs))=0A+=09=09=09continue;=0A+=0A+=09=09/*=20reform_tuple()=20= throws=20away=20dropped=20columns=20anyway=20*/=0A+=09=09if=20= (att->attisdropped)=0A+=09=09{=0A+=09=09=09isnull[i]=20=3D=20true;=0A+=09= =09=09continue;=0A+=09=09}=0A+=0A+=09=09value=20=3D=20(varlena=20*)=20= DatumGetPointer(values[i]);=0A+=09=09if=20= (!VARATT_IS_EXTERNAL_ONDISK(value))=0A+=09=09=09continue;=0A+=0A+=09=09= value=20=3D=20detoast_external_attr_extended(value);=0A+=09=09if=20= (value=20=3D=3D=20NULL)=0A+=09=09=09goto=20cleanup;=0A+=0A+=09=09= values[i]=20=3D=20PointerGetDatum(value);=0A+=09=09fetched=20=3D=20= bms_add_member(fetched,=20i);=0A+=09}=0A+=0A+=09if=20(fetched=20=3D=3D=20= NULL)=0A+=09=09return=20tuple;=0A+=0A+=09result=20=3D=20= heap_form_tuple(tupdesc,=20values,=20isnull);=0A+=0A+=09= result->t_data->t_choice=20=3D=20tuple->t_data->t_choice;=0A+=09= result->t_data->t_ctid=20=3D=20tuple->t_data->t_ctid;=0A+=09= result->t_data->t_infomask2=20&=3D=20~HEAP2_XACT_MASK;=0A+=09= result->t_data->t_infomask2=20|=3D=0A+=09=09tuple->t_data->t_infomask2=20= &=20HEAP2_XACT_MASK;=0A+=09result->t_data->t_infomask=20&=3D=20= ~HEAP_XACT_MASK;=0A+=09result->t_data->t_infomask=20|=3D=20= tuple->t_data->t_infomask=20&=20HEAP_XACT_MASK;=0A+=09result->t_self=20=3D= =20tuple->t_self;=0A+=09result->t_tableOid=20=3D=20tuple->t_tableOid;=0A= +=0A+cleanup:=0A+=09i=20=3D=20-1;=0A+=09while=20((i=20=3D=20= bms_next_member(fetched,=20i))=20>=3D=200)=0A+=09=09= pfree(DatumGetPointer(values[i]));=0A+=09bms_free(fetched);=0A+=0A+=09= return=20result;=0A=20}=0A=20=0A=20/*=0Adiff=20--git=20= a/src/backend/access/heap/heaptoast.c=20= b/src/backend/access/heap/heaptoast.c=0Aindex=20e329662b683..1097e076bb9=20= 100644=0A---=20a/src/backend/access/heap/heaptoast.c=0A+++=20= b/src/backend/access/heap/heaptoast.c=0A@@=20-84,9=20+84,11=20@@=20= heap_toast_delete(Relation=20rel,=20HeapTuple=20oldtup,=20bool=20= is_speculative)=0A=20=20*=09newtup:=20the=20candidate=20new=20tuple=20to=20= be=20inserted=0A=20=20*=09oldtup:=20the=20old=20row=20version=20for=20= UPDATE,=20or=20NULL=20for=20INSERT=0A=20=20*=09options:=20options=20to=20= be=20passed=20to=20heap_insert()=20for=20toast=20rows=0A+=20*=09flags:=20= TOAST=20fetch=20flags,=20see=20toast_helper.h=0A=20=20*=20Result:=0A=20=20= *=09either=20newtup=20if=20no=20toasting=20is=20needed,=20or=20a=20= palloc'd=20modified=20tuple=0A-=20*=09that=20is=20what=20should=20= actually=20get=20stored=0A+=20*=09that=20is=20what=20should=20actually=20= get=20stored,=20or=20NULL=20if=20flags=20includes=0A+=20*=09= TOAST_MISSING_OK=20and=20an=20external=20value=20of=20newtup=20could=20= not=20be=20fetched=0A=20=20*=0A=20=20*=20NOTE:=20neither=20newtup=20nor=20= oldtup=20will=20be=20modified.=20=20This=20is=20a=20change=0A=20=20*=20= from=20the=20pre-8.1=20API=20of=20this=20routine.=0A@@=20-94,7=20+96,7=20= @@=20heap_toast_delete(Relation=20rel,=20HeapTuple=20oldtup,=20bool=20= is_speculative)=0A=20=20*/=0A=20HeapTuple=0A=20= heap_toast_insert_or_update(Relation=20rel,=20HeapTuple=20newtup,=20= HeapTuple=20oldtup,=0A-=09=09=09=09=09=09=09uint32=20options)=0A+=09=09=09= =09=09=09=09uint32=20options,=20uint32=20flags)=0A=20{=0A=20=09HeapTuple=09= result_tuple;=0A=20=09TupleDesc=09tupleDesc;=0A@@=20-154,7=20+156,8=20@@=20= heap_toast_insert_or_update(Relation=20rel,=20HeapTuple=20newtup,=20= HeapTuple=20oldtup,=0A=20=09=09ttc.ttc_oldisnull=20=3D=20= toast_oldisnull;=0A=20=09}=0A=20=09ttc.ttc_attr=20=3D=20toast_attr;=0A-=09= toast_tuple_init(&ttc);=0A+=09if=20(!toast_tuple_init(&ttc,=20flags))=0A= +=09=09return=20NULL;=0A=20=0A=20=09/*=20----------=0A=20=09=20*=20= Compress=20and/or=20save=20external=20until=20data=20fits=20into=20= target=20length=0A@@=20-636,11=20+639,15=20@@=20= toast_build_flattened_tuple(TupleDesc=20tupleDesc,=0A=20=20*=20= sliceoffset=20is=20the=20byte=20offset=20within=20the=20TOAST=20value=20= from=20which=20to=20fetch.=0A=20=20*=20slicelength=20is=20the=20number=20= of=20bytes=20to=20be=20fetched=20from=20the=20TOAST=20value.=0A=20=20*=20= result=20is=20the=20varlena=20into=20which=20the=20results=20should=20be=20= written.=0A+=20*=20flags=20are=20TOAST=20fetch=20flags,=20see=20= toast_helper.h.=0A+=20*=0A+=20*=20Returns=20true=20on=20success.=20=20If=20= flags=20includes=20TOAST_MISSING_OK,=20returns=20false=0A+=20*=20instead=20= of=20raising=20an=20error=20when=20chunks=20are=20missing=20or=20= inconsistent.=0A=20=20*/=0A-void=0A+bool=0A=20= heap_fetch_toast_slice(Relation=20toastrel,=20Oid8=20valueid,=20int32=20= attrsize,=0A=20=09=09=09=09=09=20=20=20int32=20sliceoffset,=20int32=20= slicelength,=0A-=09=09=09=09=09=20=20=20varlena=20*result)=0A+=09=09=09=09= =09=20=20=20varlena=20*result,=20uint32=20flags)=0A=20{=0A=20=09Relation=20= =20=20*toastidxs;=0A=20=09ScanKeyData=20toastkey[3];=0A@@=20-753,27=20= +760,45=20@@=20heap_fetch_toast_slice(Relation=20toastrel,=20Oid8=20= valueid,=20int32=20attrsize,=0A=20=09=09=20*=20Some=20checks=20on=20the=20= data=20we've=20found=0A=20=09=09=20*/=0A=20=09=09if=20(curchunk=20!=3D=20= expectedchunk)=0A+=09=09{=0A+=09=09=09if=20(flags=20&=20= TOAST_MISSING_OK)=0A+=09=09=09=09goto=20toast_missing;=0A+=0A=20=09=09=09= ereport(ERROR,=0A=20=09=09=09=09=09(errcode(ERRCODE_DATA_CORRUPTED),=0A=20= =09=09=09=09=09=20errmsg_internal("unexpected=20chunk=20number=20%d=20= (expected=20%d)=20for=20toast=20value=20%"=20PRIu64=20"=20in=20%s",=0A=20= =09=09=09=09=09=09=09=09=09=20curchunk,=20expectedchunk,=20valueid,=0A=20= =09=09=09=09=09=09=09=09=09=20RelationGetRelationName(toastrel))));=0A+=09= =09}=0A+=0A=20=09=09if=20(curchunk=20>=20endchunk)=0A+=09=09{=0A+=09=09=09= if=20(flags=20&=20TOAST_MISSING_OK)=0A+=09=09=09=09goto=20toast_missing;=0A= +=0A=20=09=09=09ereport(ERROR,=0A=20=09=09=09=09=09= (errcode(ERRCODE_DATA_CORRUPTED),=0A=20=09=09=09=09=09=20= errmsg_internal("unexpected=20chunk=20number=20%d=20(out=20of=20range=20= %d..%d)=20for=20toast=20value=20%"=20PRIu64=20"=20in=20%s",=0A=20=09=09=09= =09=09=09=09=09=09=20curchunk,=0A=20=09=09=09=09=09=09=09=09=09=20= startchunk,=20endchunk,=20valueid,=0A=20=09=09=09=09=09=09=09=09=09=20= RelationGetRelationName(toastrel))));=0A+=09=09}=0A+=0A=20=09=09= expected_size=20=3D=20curchunk=20<=20totalchunks=20-=201=20?=20= max_chunk_size=0A=20=09=09=09:=20attrsize=20-=20((totalchunks=20-=201)=20= *=20max_chunk_size);=0A+=0A=20=09=09if=20(chunksize=20!=3D=20= expected_size)=0A+=09=09{=0A+=09=09=09if=20(flags=20&=20= TOAST_MISSING_OK)=0A+=09=09=09=09goto=20toast_missing;=0A+=0A=20=09=09=09= ereport(ERROR,=0A=20=09=09=09=09=09(errcode(ERRCODE_DATA_CORRUPTED),=0A=20= =09=09=09=09=09=20errmsg_internal("unexpected=20chunk=20size=20%d=20= (expected=20%d)=20in=20chunk=20%d=20of=20%d=20for=20toast=20value=20%"=20= PRIu64=20"=20in=20%s",=0A=20=09=09=09=09=09=09=09=09=09=20chunksize,=20= expected_size,=0A=20=09=09=09=09=09=09=09=09=09=20curchunk,=20= totalchunks,=20valueid,=0A=20=09=09=09=09=09=09=09=09=09=20= RelationGetRelationName(toastrel))));=0A+=09=09}=0A=20=0A=20=09=09/*=0A=20= =09=09=20*=20Copy=20the=20data=20into=20proper=20place=20in=20our=20= result=0A@@=20-797,13=20+822,26=20@@=20heap_fetch_toast_slice(Relation=20= toastrel,=20Oid8=20valueid,=20int32=20attrsize,=0A=20=09=20*=20Final=20= checks=20that=20we=20successfully=20fetched=20the=20datum=0A=20=09=20*/=0A= =20=09if=20(expectedchunk=20!=3D=20(endchunk=20+=201))=0A+=09{=0A+=09=09= if=20(flags=20&=20TOAST_MISSING_OK)=0A+=09=09=09goto=20toast_missing;=0A= +=0A=20=09=09ereport(ERROR,=0A=20=09=09=09=09= (errcode(ERRCODE_DATA_CORRUPTED),=0A=20=09=09=09=09=20= errmsg_internal("missing=20chunk=20number=20%d=20for=20toast=20value=20= %"=20PRIu64=20"=20in=20%s",=0A=20=09=09=09=09=09=09=09=09=20= expectedchunk,=20valueid,=0A=20=09=09=09=09=09=09=09=09=20= RelationGetRelationName(toastrel))));=0A+=09}=0A=20=0A=20=09/*=20End=20= scan=20and=20close=20indexes.=20*/=0A=20=09= systable_endscan_ordered(toastscan);=0A=20=09= toast_close_indexes(toastidxs,=20num_indexes,=20AccessShareLock);=0A+=0A= +=09return=20true;=0A+=0A+toast_missing:=0A+=09= systable_endscan_ordered(toastscan);=0A+=09= toast_close_indexes(toastidxs,=20num_indexes,=20AccessShareLock);=0A+=0A= +=09return=20false;=0A=20}=0Adiff=20--git=20= a/src/backend/access/heap/rewriteheap.c=20= b/src/backend/access/heap/rewriteheap.c=0Aindex=20= be0f6646b83..2ab3f77edfc=20100644=0A---=20= a/src/backend/access/heap/rewriteheap.c=0A+++=20= b/src/backend/access/heap/rewriteheap.c=0A@@=20-108,6=20+108,7=20@@=0A=20= #include=20"access/heapam_xlog.h"=0A=20#include=20"access/heaptoast.h"=0A= =20#include=20"access/rewriteheap.h"=0A+#include=20= "access/toast_helper.h"=0A=20#include=20"access/transam.h"=0A=20#include=20= "access/xact.h"=0A=20#include=20"access/xloginsert.h"=0A@@=20-149,6=20= +150,7=20@@=20typedef=20struct=20RewriteStateData=0A=20=09XLogRecPtr=09= rs_begin_lsn;=09/*=20XLogInsertLsn=20when=20starting=20the=20rewrite=20= */=0A=20=09HTAB=09=20=20=20*rs_unresolved_tups;=20/*=20unmatched=20A=20= tuples=20*/=0A=20=09HTAB=09=20=20=20*rs_old_new_tid_map;=20/*=20= unmatched=20B=20tuples=20*/=0A+=09double=09=09rs_tuples_dropped;=09/*=20= #=20stashed=20tuples=20skipped,=20TOAST=20gone=20*/=0A=20=09HTAB=09=20=20= =20*rs_logical_mappings;=09/*=20logical=20remapping=20files=20*/=0A=20=09= uint32=09=09rs_num_rewrite_mappings;=09/*=20#=20in=20memory=20mappings=20= */=0A=20}=20RewriteStateData;=0A@@=20-172,6=20+174,7=20@@=20typedef=20= struct=0A=20{=0A=20=09TidHashKey=09key;=09=09=09/*=20expected=20xmin/old=20= location=20of=20B=20tuple=20*/=0A=20=09ItemPointerData=20old_tid;=09/*=20= A's=20location=20in=20the=20old=20heap=20*/=0A+=09bool=09=09= recently_dead;=09/*=20A=20was=20RECENTLY_DEAD=20*/=0A=20=09HeapTuple=09= tuple;=09=09=09/*=20A's=20tuple=20contents=20*/=0A=20}=20= UnresolvedTupData;=0A=20=0A@@=20-211,7=20+214,8=20@@=20typedef=20struct=20= RewriteMappingDataEntry=0A=20=0A=20=0A=20/*=20prototypes=20for=20= internal=20functions=20*/=0A-static=20void=20= raw_heap_insert(RewriteState=20state,=20HeapTuple=20tup);=0A+static=20= bool=20raw_heap_insert(RewriteState=20state,=20HeapTuple=20tup,=0A+=09=09= =09=09=09=09=09bool=20recently_dead);=0A=20=0A=20/*=20internal=20logical=20= remapping=20prototypes=20*/=0A=20static=20void=20= logical_begin_heap_rewrite(RewriteState=20state);=0A@@=20-293,12=20= +297,16=20@@=20begin_heap_rewrite(Relation=20old_heap,=20Relation=20= new_heap,=20TransactionId=20oldest_xm=0A=20=20*=20End=20a=20rewrite.=0A=20= =20*=0A=20=20*=20state=20and=20any=20other=20resources=20are=20freed.=0A= +=20*=0A+=20*=20Returns=20the=20number=20of=20stashed=20tuples=20that=20= were=20skipped=20because=20their=20TOAST=0A+=20*=20data=20was=20gone;=20= see=20rewrite_heap_tuple().=0A=20=20*/=0A-void=0A+double=0A=20= end_heap_rewrite(RewriteState=20state)=0A=20{=0A=20=09HASH_SEQ_STATUS=20= seq_status;=0A=20=09UnresolvedTup=20unresolved;=0A+=09double=09=09= tuples_dropped;=0A=20=0A=20=09/*=0A=20=09=20*=20Write=20any=20remaining=20= tuples=20in=20the=20UnresolvedTups=20table.=20If=20we=20have=20any=0A@@=20= -309,7=20+317,8=20@@=20end_heap_rewrite(RewriteState=20state)=0A=20=09= while=20((unresolved=20=3D=20hash_seq_search(&seq_status))=20!=3D=20= NULL)=0A=20=09{=0A=20=09=09= ItemPointerSetInvalid(&unresolved->tuple->t_data->t_ctid);=0A-=09=09= raw_heap_insert(state,=20unresolved->tuple);=0A+=09=09if=20= (!raw_heap_insert(state,=20unresolved->tuple,=20= unresolved->recently_dead))=0A+=09=09=09state->rs_tuples_dropped=20+=3D=20= 1;=0A=20=09}=0A=20=0A=20=09/*=20Write=20the=20last=20page,=20if=20any=20= */=0A@@=20-323,8=20+332,12=20@@=20end_heap_rewrite(RewriteState=20state)=0A= =20=0A=20=09logical_end_heap_rewrite(state);=0A=20=0A+=09tuples_dropped=20= =3D=20state->rs_tuples_dropped;=0A+=0A=20=09/*=20Deleting=20the=20= context=20frees=20everything=20*/=0A=20=09= MemoryContextDelete(state->rs_cxt);=0A+=0A+=09return=20tuples_dropped;=0A= =20}=0A=20=0A=20/*=0A@@=20-337,10=20+350,18=20@@=20= end_heap_rewrite(RewriteState=20state)=0A=20=20*=20state=09=09opaque=20= state=20as=20returned=20by=20begin_heap_rewrite=0A=20=20*=20old_tuple=09= original=20tuple=20in=20the=20old=20heap=0A=20=20*=20new_tuple=09new,=20= rewritten=20tuple=20to=20be=20inserted=20to=20new=20heap=0A+=20*=20= recently_dead=09old_tuple=20is=20RECENTLY_DEAD=0A+=20*=0A+=20*=20The=20= TOAST=20data=20of=20a=20RECENTLY_DEAD=20tuple=20may=20already=20have=20= been=20removed;=20see=0A+=20*=20raw_heap_insert().=20=20Returns=20false=20= if=20new_tuple=20was=20skipped=20for=20that=20reason,=0A+=20*=20in=20= which=20case=20the=20caller=20should=20count=20it=20as=20dead.=20=20= Skipped=20older=20versions=0A+=20*=20of=20the=20same=20update=20chain,=20= which=20were=20stashed=20earlier=20and=20get=20written=20out=0A+=20*=20= here=20or=20in=20end_heap_rewrite(),=20are=20counted=20in=20= rs_tuples_dropped=20instead.=0A=20=20*/=0A-void=0A+bool=0A=20= rewrite_heap_tuple(RewriteState=20state,=0A-=09=09=09=09=20=20=20= HeapTuple=20old_tuple,=20HeapTuple=20new_tuple)=0A+=09=09=09=09=20=20=20= HeapTuple=20old_tuple,=20HeapTuple=20new_tuple,=0A+=09=09=09=09=20=20=20= bool=20recently_dead)=0A=20{=0A=20=09MemoryContext=20old_cxt;=0A=20=09= ItemPointerData=20old_tid;=0A@@=20-438,13=20+459,14=20@@=20= rewrite_heap_tuple(RewriteState=20state,=0A=20=0A=20=09=09=09= unresolved->old_tid=20=3D=20old_tuple->t_self;=0A=20=09=09=09= unresolved->tuple=20=3D=20heap_copytuple(new_tuple);=0A+=09=09=09= unresolved->recently_dead=20=3D=20recently_dead;=0A=20=0A=20=09=09=09/*=0A= =20=09=09=09=20*=20We=20can't=20do=20anything=20more=20now,=20since=20we=20= don't=20know=20where=20the=0A=20=09=09=09=20*=20tuple=20will=20be=20= written.=0A=20=09=09=09=20*/=0A=20=09=09=09= MemoryContextSwitchTo(old_cxt);=0A-=09=09=09return;=0A+=09=09=09return=20= true;=0A=20=09=09}=0A=20=09}=0A=20=0A@@=20-462,7=20+484,24=20@@=20= rewrite_heap_tuple(RewriteState=20state,=0A=20=09=09ItemPointerData=20= new_tid;=0A=20=0A=20=09=09/*=20Insert=20the=20tuple=20and=20find=20out=20= where=20it's=20put=20in=20new_heap=20*/=0A-=09=09raw_heap_insert(state,=20= new_tuple);=0A+=09=09if=20(!raw_heap_insert(state,=20new_tuple,=20= recently_dead))=0A+=09=09{=0A+=09=09=09if=20(!free_new)=0A+=09=09=09{=0A= +=09=09=09=09MemoryContextSwitchTo(old_cxt);=0A+=09=09=09=09return=20= false;=0A+=09=09=09}=0A+=0A+=09=09=09/*=0A+=09=09=09=20*=20This=20is=20a=20= stashed=20older=20version,=20and=20the=20caller's=20tuple=20has=0A+=09=09= =09=20*=20already=20been=20written.=20=20Any=20still=20older=20version=20= waiting=20for=20this=0A+=09=09=09=20*=20one=20is=20written=20out=20by=20= end_heap_rewrite().=0A+=09=09=09=20*/=0A+=09=09=09= state->rs_tuples_dropped=20+=3D=201;=0A+=09=09=09= heap_freetuple(new_tuple);=0A+=09=09=09MemoryContextSwitchTo(old_cxt);=0A= +=09=09=09return=20true;=0A+=09=09}=0A=20=09=09new_tid=20=3D=20= new_tuple->t_self;=0A=20=0A=20=09=09logical_rewrite_heap_tuple(state,=20= old_tid,=20new_tuple);=0A@@=20-503,6=20+542,7=20@@=20= rewrite_heap_tuple(RewriteState=20state,=0A=20=09=09=09=09new_tuple=20=3D=20= unresolved->tuple;=0A=20=09=09=09=09free_new=20=3D=20true;=0A=20=09=09=09= =09old_tid=20=3D=20unresolved->old_tid;=0A+=09=09=09=09recently_dead=20=3D= =20unresolved->recently_dead;=0A=20=09=09=09=09new_tuple->t_data->t_ctid=20= =3D=20new_tid;=0A=20=0A=20=09=09=09=09/*=0A@@=20-539,6=20+579,7=20@@=20= rewrite_heap_tuple(RewriteState=20state,=0A=20=09}=0A=20=0A=20=09= MemoryContextSwitchTo(old_cxt);=0A+=09return=20true;=0A=20}=0A=20=0A=20= /*=0A@@=20-599,9=20+640,14=20@@=20rewrite_heap_dead_tuple(RewriteState=20= state,=20HeapTuple=20old_tuple)=0A=20=20*=20t_self=20of=20the=20tuple=20= is=20set=20to=20the=20new=20TID=20of=20the=20tuple.=20If=20t_ctid=20of=20= the=0A=20=20*=20tuple=20is=20invalid=20on=20entry,=20it's=20replaced=20= with=20the=20new=20TID=20as=20well=20(in=0A=20=20*=20the=20inserted=20= data=20only,=20not=20in=20the=20caller's=20copy).=0A+=20*=0A+=20*=20= recently_dead=20must=20be=20set=20if=20the=20tuple=20is=20RECENTLY_DEAD.=20= =20Other=20backends=0A+=20*=20may=20already=20consider=20such=20a=20= tuple=20fully=20dead,=20and=20VACUUM=20or=20pruning=20of=20the=0A+=20*=20= TOAST=20relation=20may=20have=20removed=20its=20TOAST=20data.=20=20In=20= that=20case=20nobody=20can=0A+=20*=20see=20the=20tuple=20anymore,=20so=20= it=20is=20not=20inserted,=20and=20false=20is=20returned.=0A=20=20*/=0A= -static=20void=0A-raw_heap_insert(RewriteState=20state,=20HeapTuple=20= tup)=0A+static=20bool=0A+raw_heap_insert(RewriteState=20state,=20= HeapTuple=20tup,=20bool=20recently_dead)=0A=20{=0A=20=09Page=09=09page;=0A= =20=09Size=09=09pageFreeSpace,=0A@@=20-629,6=20+675,7=20@@=20= raw_heap_insert(RewriteState=20state,=20HeapTuple=20tup)=0A=20=09else=20= if=20(HeapTupleHasExternal(tup)=20||=20tup->t_len=20>=20= TOAST_TUPLE_THRESHOLD)=0A=20=09{=0A=20=09=09uint32=09=09options=20=3D=20= HEAP_INSERT_SKIP_FSM;=0A+=09=09uint32=09=09toastflags=20=3D=20= recently_dead=20?=20TOAST_MISSING_OK=20:=200;=0A=20=0A=20=09=09/*=0A=20=09= =09=20*=20While=20rewriting=20the=20heap=20for=20REPACK,=20make=20sure=20= data=20for=20the=20TOAST=0A@@=20-638,7=20+685,9=20@@=20= raw_heap_insert(RewriteState=20state,=20HeapTuple=20tup)=0A=20=09=09= options=20|=3D=20HEAP_INSERT_NO_LOGICAL;=0A=20=0A=20=09=09heaptup=20=3D=20= heap_toast_insert_or_update(state->rs_new_rel,=20tup,=20NULL,=0A-=09=09=09= =09=09=09=09=09=09=09=09=20=20options);=0A+=09=09=09=09=09=09=09=09=09=09= =09=20=20options,=20toastflags);=0A+=09=09if=20(heaptup=20=3D=3D=20NULL)=0A= +=09=09=09return=20false;=0A=20=09}=0A=20=09else=0A=20=09=09heaptup=20=3D=20= tup;=0A@@=20-712,6=20+761,8=20@@=20raw_heap_insert(RewriteState=20state,=20= HeapTuple=20tup)=0A=20=09/*=20If=20heaptup=20is=20a=20private=20copy,=20= release=20it.=20*/=0A=20=09if=20(heaptup=20!=3D=20tup)=0A=20=09=09= heap_freetuple(heaptup);=0A+=0A+=09return=20true;=0A=20}=0A=20=0A=20/*=20= ------------------------------------------------------------------------=0A= diff=20--git=20a/src/backend/access/table/toast_helper.c=20= b/src/backend/access/table/toast_helper.c=0Aindex=20= 2613d9dc095..e74e28d8e2c=20100644=0A---=20= a/src/backend/access/table/toast_helper.c=0A+++=20= b/src/backend/access/table/toast_helper.c=0A@@=20-36,9=20+36,12=20@@=0A=20= =20*=20toast_flags=20is=20just=20a=20single=20uint8,=20but=20toast_attr=20= is=20a=20caller-provided=0A=20=20*=20array=20with=20a=20length=20equal=20= to=20tupleDesc->natts.=20=20The=20caller=20need=20not=0A=20=20*=20= perform=20any=20initialization=20of=20the=20array=20before=20calling=20= this=20function.=0A+=20*=0A+=20*=20If=20flags=20includes=20= TOAST_MISSING_OK=20and=20an=20external=20value=20of=20the=20new=20tuple=0A= +=20*=20cannot=20be=20fetched,=20returns=20false=20instead=20of=20= raising=20an=20error.=0A=20=20*/=0A-void=0A= -toast_tuple_init(ToastTupleContext=20*ttc)=0A+bool=0A= +toast_tuple_init(ToastTupleContext=20*ttc,=20uint32=20flags)=0A=20{=0A=20= =09TupleDesc=09tupleDesc=20=3D=20ttc->ttc_rel->rd_att;=0A=20=09int=09=09=09= numAttrs=20=3D=20tupleDesc->natts;=0A@@=20-141,7=20+144,25=20@@=20= toast_tuple_init(ToastTupleContext=20*ttc)=0A=20=09=09=09if=20= (VARATT_IS_EXTERNAL(new_value))=0A=20=09=09=09{=0A=20=09=09=09=09= ttc->ttc_attr[i].tai_oldexternal=20=3D=20new_value;=0A-=09=09=09=09if=20= (att->attstorage=20=3D=3D=20TYPSTORAGE_PLAIN)=0A+=0A+=09=09=09=09if=20= ((flags=20&=20TOAST_MISSING_OK)=20!=3D=200=20&&=0A+=09=09=09=09=09= VARATT_IS_EXTERNAL_ONDISK(new_value))=0A+=09=09=09=09{=0A+=09=09=09=09=09= new_value=20=3D=20detoast_external_attr_extended(new_value);=0A+=09=09=09= =09=09if=20(new_value=20=3D=3D=20NULL)=0A+=09=09=09=09=09=09goto=20= toast_missing;=0A+=0A+=09=09=09=09=09/*=20PLAIN=20storage=20does=20not=20= allow=20compressed=20values=20*/=0A+=09=09=09=09=09if=20(att->attstorage=20= =3D=3D=20TYPSTORAGE_PLAIN=20&&=0A+=09=09=09=09=09=09= VARATT_IS_COMPRESSED(new_value))=0A+=09=09=09=09=09{=0A+=09=09=09=09=09=09= varlena=20=20=20=20*decompressed=20=3D=20detoast_attr(new_value);=0A+=0A= +=09=09=09=09=09=09pfree(new_value);=0A+=09=09=09=09=09=09new_value=20=3D=20= decompressed;=0A+=09=09=09=09=09}=0A+=09=09=09=09}=0A+=09=09=09=09else=20= if=20(att->attstorage=20=3D=3D=20TYPSTORAGE_PLAIN)=0A=20=09=09=09=09=09= new_value=20=3D=20detoast_attr(new_value);=0A=20=09=09=09=09else=0A=20=09= =09=09=09=09new_value=20=3D=20detoast_external_attr(new_value);=0A@@=20= -163,6=20+184,20=20@@=20toast_tuple_init(ToastTupleContext=20*ttc)=0A=20=09= =09=09ttc->ttc_attr[i].tai_colflags=20|=3D=20TOASTCOL_IGNORE;=0A=20=09=09= }=0A=20=09}=0A+=0A+=09return=20true;=0A+=0A+toast_missing:=0A+=09/*=20= release=20the=20values=20fetched=20so=20far=20*/=0A+=09for=20(;=20i=20>=3D= =200;=20i--)=0A+=09{=0A+=09=09if=20(ttc->ttc_attr[i].tai_colflags=20&=20= TOASTCOL_NEEDS_FREE)=0A+=09=09{=0A+=09=09=09= pfree(DatumGetPointer(ttc->ttc_values[i]));=0A+=09=09=09= ttc->ttc_attr[i].tai_colflags=20&=3D=20~TOASTCOL_NEEDS_FREE;=0A+=09=09}=0A= +=09}=0A+=09return=20false;=0A=20}=0A=20=0A=20/*=0Adiff=20--git=20= a/src/include/access/detoast.h=20b/src/include/access/detoast.h=0Aindex=20= 93b7a253760..c5411b34fcc=20100644=0A---=20a/src/include/access/detoast.h=0A= +++=20b/src/include/access/detoast.h=0A@@=20-91,6=20+91,15=20@@=20= toast_external_info_get(const=20struct=20varlena=20*attr,=20= toast_external_data=20*toast_e=0A=20=20*/=0A=20extern=20varlena=20= *detoast_external_attr(varlena=20*attr);=0A=20=0A+/*=20----------=0A+=20= *=20detoast_external_attr_extended()=20-=0A+=20*=0A+=20*=09=09Like=20= detoast_external_attr,=20but=20returns=20NULL=20if=20toast=20chunks=0A+=20= *=09=09are=20missing=20(instead=20of=20raising=20an=20error).=0A+=20*=20= ----------=0A+=20*/=0A+extern=20varlena=20= *detoast_external_attr_extended(varlena=20*attr);=0A+=0A=20/*=20= ----------=0A=20=20*=20detoast_attr()=20-=0A=20=20*=0Adiff=20--git=20= a/src/include/access/heaptoast.h=20b/src/include/access/heaptoast.h=0A= index=204c3fda8a5f9..f51f965507f=20100644=0A---=20= a/src/include/access/heaptoast.h=0A+++=20= b/src/include/access/heaptoast.h=0A@@=20-105,11=20+105,14=20@@=0A=20/*=20= ----------=0A=20=20*=20heap_toast_insert_or_update=20-=0A=20=20*=0A-=20*=09= Called=20by=20heap_insert()=20and=20heap_update().=0A+=20*=09Called=20by=20= heap_insert()=20and=20heap_update().=20=20Returns=20NULL=20if=20flags=0A= +=20*=09includes=20TOAST_MISSING_OK=20and=20an=20external=20value=20= could=20not=20be=20fetched.=0A+=20*=09See=20toast_helper.h=20for=20the=20= values=20of=20"flags".=0A=20=20*=20----------=0A=20=20*/=0A=20extern=20= HeapTuple=20heap_toast_insert_or_update(Relation=20rel,=20HeapTuple=20= newtup,=0A-=09=09=09=09=09=09=09=09=09=09=09=20HeapTuple=20oldtup,=20= uint32=20options);=0A+=09=09=09=09=09=09=09=09=09=09=09=20HeapTuple=20= oldtup,=20uint32=20options,=0A+=09=09=09=09=09=09=09=09=09=09=09=20= uint32=20flags);=0A=20=0A=20/*=20----------=0A=20=20*=20= heap_toast_delete=20-=0A@@=20-153,11=20+156,14=20@@=20extern=20HeapTuple=20= toast_build_flattened_tuple(TupleDesc=20tupleDesc,=0A=20/*=20----------=0A= =20=20*=20heap_fetch_toast_slice=0A=20=20*=0A-=20*=09Fetch=20a=20slice=20= from=20a=20toast=20value=20stored=20in=20a=20heap=20table.=0A+=20*=09= Fetch=20a=20slice=20from=20a=20toast=20value=20stored=20in=20a=20heap=20= table.=20=20Returns=0A+=20*=09false=20if=20flags=20includes=20= TOAST_MISSING_OK=20and=20chunks=20are=20missing.=0A+=20*=09See=20= toast_helper.h=20for=20the=20values=20of=20"flags".=0A=20=20*=20= ----------=0A=20=20*/=0A-extern=20void=20heap_fetch_toast_slice(Relation=20= toastrel,=20Oid8=20valueid,=0A+extern=20bool=20= heap_fetch_toast_slice(Relation=20toastrel,=20Oid8=20valueid,=0A=20=09=09= =09=09=09=09=09=09=20=20=20int32=20attrsize,=20int32=20sliceoffset,=0A-=09= =09=09=09=09=09=09=09=20=20=20int32=20slicelength,=20varlena=20*result);=0A= +=09=09=09=09=09=09=09=09=20=20=20int32=20slicelength,=20varlena=20= *result,=0A+=09=09=09=09=09=09=09=09=20=20=20uint32=20flags);=0A=20=0A=20= #endif=09=09=09=09=09=09=09/*=20HEAPTOAST_H=20*/=0Adiff=20--git=20= a/src/include/access/rewriteheap.h=20b/src/include/access/rewriteheap.h=0A= index=206ccf7b45c04..63a78179071=20100644=0A---=20= a/src/include/access/rewriteheap.h=0A+++=20= b/src/include/access/rewriteheap.h=0A@@=20-24,9=20+24,9=20@@=20typedef=20= struct=20RewriteStateData=20*RewriteState;=0A=20extern=20RewriteState=20= begin_heap_rewrite(Relation=20old_heap,=20Relation=20new_heap,=0A=20=09=09= =09=09=09=09=09=09=09=20=20=20TransactionId=20oldest_xmin,=20= TransactionId=20freeze_xid,=0A=20=09=09=09=09=09=09=09=09=09=20=20=20= MultiXactId=20cutoff_multi);=0A-extern=20void=20= end_heap_rewrite(RewriteState=20state);=0A-extern=20void=20= rewrite_heap_tuple(RewriteState=20state,=20HeapTuple=20old_tuple,=0A-=09=09= =09=09=09=09=09=20=20=20HeapTuple=20new_tuple);=0A+extern=20double=20= end_heap_rewrite(RewriteState=20state);=0A+extern=20bool=20= rewrite_heap_tuple(RewriteState=20state,=20HeapTuple=20old_tuple,=0A+=09=09= =09=09=09=09=09=20=20=20HeapTuple=20new_tuple,=20bool=20recently_dead);=0A= =20extern=20bool=20rewrite_heap_dead_tuple(RewriteState=20state,=20= HeapTuple=20old_tuple);=0A=20=0A=20/*=0Adiff=20--git=20= a/src/include/access/tableam.h=20b/src/include/access/tableam.h=0Aindex=20= 9d2fc7f9acb..70bf786ce08=20100644=0A---=20a/src/include/access/tableam.h=0A= +++=20b/src/include/access/tableam.h=0A@@=20-782,12=20+782,17=20@@=20= typedef=20struct=20TableAmRoutine=0A=20=09=20*=20This=20callback=20is=20= invoked=20when=20detoasting=20a=20value=20stored=20in=20a=20toast=0A=20=09= =20*=20table=20implemented=20by=20this=20AM.=20=20See=20= table_relation_fetch_toast_slice()=0A=20=09=20*=20for=20more=20details.=0A= +=09=20*=0A+=09=20*=20Returns=20true=20on=20success.=20=20If=20flags=20= (see=20toast_helper.h)=20includes=0A+=09=20*=20TOAST_MISSING_OK,=20= returns=20false=20instead=20of=20raising=20an=20error=20when=20chunks=0A= +=09=20*=20are=20missing.=0A=20=09=20*/=0A-=09void=09=09= (*relation_fetch_toast_slice)=20(Relation=20toastrel,=20Oid8=20valueid,=0A= +=09bool=09=09(*relation_fetch_toast_slice)=20(Relation=20toastrel,=20= Oid8=20valueid,=0A=20=09=09=09=09=09=09=09=09=09=09=09=20=20=20int32=20= attrsize,=0A=20=09=09=09=09=09=09=09=09=09=09=09=20=20=20int32=20= sliceoffset,=0A=20=09=09=09=09=09=09=09=09=09=09=09=20=20=20int32=20= slicelength,=0A-=09=09=09=09=09=09=09=09=09=09=09=20=20=20varlena=20= *result);=0A+=09=09=09=09=09=09=09=09=09=09=09=20=20=20varlena=20= *result,=0A+=09=09=09=09=09=09=09=09=09=09=09=20=20=20uint32=20flags);=0A= =20=0A=20=0A=20=09/*=20= ------------------------------------------------------------------------=0A= @@=20-2003,11=20+2008,16=20@@=20table_relation_toast_am(Relation=20rel)=0A= =20=20*=0A=20=20*=20result=20is=20caller-allocated=20space=20into=20= which=20the=20fetched=20bytes=20should=20be=0A=20=20*=20stored.=0A+=20*=0A= +=20*=20flags=20are=20TOAST=20fetch=20flags,=20see=20toast_helper.h.=20=20= Returns=20true=20on=20success.=0A+=20*=20If=20flags=20includes=20= TOAST_MISSING_OK,=20returns=20false=20instead=20of=20raising=20an=0A+=20= *=20error=20when=20chunks=20are=20missing.=0A=20=20*/=0A-static=20inline=20= void=0A+static=20inline=20bool=0A=20= table_relation_fetch_toast_slice(Relation=20toastrel,=20Oid8=20valueid,=0A= =20=09=09=09=09=09=09=09=09=20int32=20attrsize,=20int32=20sliceoffset,=0A= -=09=09=09=09=09=09=09=09=20int32=20slicelength,=20varlena=20*result)=0A= +=09=09=09=09=09=09=09=09=20int32=20slicelength,=20varlena=20*result,=0A= +=09=09=09=09=09=09=09=09=20uint32=20flags)=0A=20{=0A=20=09if=20= (attrsize=20<=200=20||=20sliceoffset=20<=200=20||=20slicelength=20<=200)=0A= =20=09=09elog(ERROR,=20"invalid=20toast=20slice:=20offset=20%d,=20length=20= %d,=20value=20size=20%d",=0A@@=20-2015,10=20+2025,10=20@@=20= table_relation_fetch_toast_slice(Relation=20toastrel,=20Oid8=20valueid,=0A= =20=09if=20(slicelength=20>=20attrsize=20-=20sliceoffset)=0A=20=09=09= elog(ERROR,=20"slice=20length=20is=20too=20big");=0A=20=0A-=09= toastrel->rd_tableam->relation_fetch_toast_slice(toastrel,=20valueid,=0A= -=09=09=09=09=09=09=09=09=09=09=09=09=09=20attrsize,=0A-=09=09=09=09=09=09= =09=09=09=09=09=09=09=20sliceoffset,=20slicelength,=0A-=09=09=09=09=09=09= =09=09=09=09=09=09=09=20result);=0A+=09return=20= toastrel->rd_tableam->relation_fetch_toast_slice(toastrel,=20valueid,=0A= +=09=09=09=09=09=09=09=09=09=09=09=09=09=09=09attrsize,=0A+=09=09=09=09=09= =09=09=09=09=09=09=09=09=09=09sliceoffset,=20slicelength,=0A+=09=09=09=09= =09=09=09=09=09=09=09=09=09=09=09result,=20flags);=0A=20}=0A=20=0A=20=0A= diff=20--git=20a/src/include/access/toast_helper.h=20= b/src/include/access/toast_helper.h=0Aindex=202ec92397f26..622700e3131=20= 100644=0A---=20a/src/include/access/toast_helper.h=0A+++=20= b/src/include/access/toast_helper.h=0A@@=20-101,7=20+101,16=20@@=20= typedef=20struct=0A=20#define=20TOASTCOL_IGNORE=09=09=09=09=09=090x0010=0A= =20#define=20TOASTCOL_INCOMPRESSIBLE=09=09=09=090x0020=0A=20=0A-extern=20= void=20toast_tuple_init(ToastTupleContext=20*ttc);=0A+/*=0A+=20*=20Flags=20= for=20TOAST=20fetch=20operations.=0A+=20*=0A+=20*=20TOAST_MISSING_OK=20= makes=20the=20fetch=20report=20missing=20or=20inconsistent=20chunks=20to=0A= +=20*=20the=20caller=20instead=20of=20raising=20an=20error.=20=20This=20= is=20only=20appropriate=20for=0A+=20*=20RECENTLY_DEAD=20tuples,=20whose=20= TOAST=20data=20may=20legitimately=20be=20gone=20already.=0A+=20*/=0A= +#define=20TOAST_MISSING_OK=09=09(1=20<<=200)=0A+=0A+extern=20bool=20= toast_tuple_init(ToastTupleContext=20*ttc,=20uint32=20flags);=0A=20= extern=20int=09toast_tuple_find_biggest_attribute(ToastTupleContext=20= *ttc,=0A=20=09=09=09=09=09=09=09=09=09=09=09=20=20=20bool=20= for_compression,=0A=20=09=09=09=09=09=09=09=09=09=09=09=20=20=20bool=20= check_main);=0A--=20=0A2.54.0=20(Apple=20Git-157)=0A=0A= --Apple-Mail=_62091BF7-E2A4-4692-8A58-19E5656A5476 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii
--Apple-Mail=_62091BF7-E2A4-4692-8A58-19E5656A5476-- --Apple-Mail=_13202E66-6869-45A3-844A-476F78DB037C--