From: Tom Lane <tgl@sss.pgh.pa.us>
To: dan-eli@mail.ru
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18890: /src/timezone/localtime.c condition always false
In-reply-to: <18890-ef0514797325c193@postgresql.org>
References: <18890-ef0514797325c193@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Thu, 10 Apr 2025 16:44:55 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <537385.1744308142.1@sss.pgh.pa.us>
Date: Thu, 10 Apr 2025 14:02:22 -0400
Message-ID: <537386.1744308142@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/537386.1744308142%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> On line 223 there is a check of string 'name' and in this case it is
> initiallized and then is being checked for null once more with no reason.

This code is taken from the upstream tzcode distribution, in which
TZDEFAULT can be NULL.  (Or so I assume anyway without having looked.)
I'm disinclined to diverge from their code just to satisfy some static
analyzer complaining about useless code --- any reasonable C compiler
will discard that code, so it's not a problem.

> The code becomes quite buggy.

If there is actually a bug here, I'm not seeing it.

			regards, tom lane