Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1XBpC2-0004NA-0H for pgsql-bugs@arkaria.postgresql.org; Mon, 28 Jul 2014 17:58:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1XBpC1-0003e2-2Q for pgsql-bugs@arkaria.postgresql.org; Mon, 28 Jul 2014 17:58:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1XBpC0-0003dv-AM for pgsql-bugs@postgresql.org; Mon, 28 Jul 2014 17:58:36 +0000 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]) by makus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1XBpBw-0005rF-0G for pgsql-bugs@postgresql.org; Mon, 28 Jul 2014 17:58:33 +0000 Received: from sc9-mailhost1.vmware.com (sc9-mailhost1.vmware.com [10.113.161.71]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id D932528420; Mon, 28 Jul 2014 10:58:29 -0700 (PDT) Received: from EX13-CAS-008.vmware.com (EX13-CAS-008.vmware.com [10.113.191.58]) by sc9-mailhost1.vmware.com (Postfix) with ESMTP id D284C19639; Mon, 28 Jul 2014 10:58:29 -0700 (PDT) Received: from EX13-MBX-024.vmware.com (10.113.191.44) by EX13-MBX-005.vmware.com (10.113.191.25) with Microsoft SMTP Server (TLS) id 15.0.775.38; Mon, 28 Jul 2014 10:58:29 -0700 Received: from [192.168.1.90] (10.113.160.246) by EX13-MBX-024.vmware.com (10.113.191.44) with Microsoft SMTP Server (TLS) id 15.0.775.38; Mon, 28 Jul 2014 10:58:28 -0700 Message-ID: <53D68F41.40604@vmware.com> Date: Mon, 28 Jul 2014 20:58:25 +0300 From: Heikki Linnakangas Organization: VMware User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Andres Freund CC: Tom Lane , , Subject: Re: BUG #11032: Prepared transactions do not update pg_last_xact_replay_timestamp() anymore References: <20140724191127.32089.82261@wrigleys.postgresql.org> <20429.1406238373@sss.pgh.pa.us> <20140724215743.GG16857@alap3.anarazel.de> <21266.1406241129@sss.pgh.pa.us> <20140724223459.GI16857@alap3.anarazel.de> <21620.1406242232@sss.pgh.pa.us> <53D62059.6060304@vmware.com> <20140728141757.GN17793@alap3.anarazel.de> In-Reply-To: <20140728141757.GN17793@alap3.anarazel.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.113.160.246] X-ClientProxiedBy: EX13-CAS-013.vmware.com (10.113.191.65) To EX13-MBX-024.vmware.com (10.113.191.44) X-Pg-Spam-Score: -7.6 (-------) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-bugs Precedence: bulk Sender: pgsql-bugs-owner@postgresql.org On 07/28/2014 05:17 PM, Andres Freund wrote: > On 2014-07-28 13:05:13 +0300, Heikki Linnakangas wrote: >> We probably should set XLogRecord->xl_xid in COMMIT_/ABORT_PREPARED records >> though. It seems weird not to, and it would simplify code that interprets >> those records. But I don't think we should back-patch that. > > I doubt that'd be a net improvement - wouldn't that just make the life > of anything tracking xid liveliness a bit more complicated? How so? - Heikki -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs