agora inbox for pgsql-bugs@postgresql.org
help / color / mirror / Atom feedFrom: Konstantin Knizhnik <knizhnik@garret.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Imran Zaheer <imran.zhir@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19519: REPACK can fail due to missing chunk for toast value
Date: Thu, 9 Jul 2026 13:08:43 +0300
Message-ID: <53dd03d4-5aab-405d-bff3-f3c5433edef7@garret.ru> (raw)
In-Reply-To: <ak806l8j5A45y2LD@paquier.xyz>
References: <CAEze2WhCRX86ZY2QN7vuGc3wsAyOJbArFSc0i5KtMVnsguA7Kw@mail.gmail.com>
<akw336Xpi9Ck9-Oz@paquier.xyz>
<CAEze2WgBjhf6KTKuJ-UqHHGj9Z66f62grmJgZ1EazvMH9HU+XA@mail.gmail.com>
<akxZiYmGhvNfPVvh@paquier.xyz>
<akyM9G67ZIhPXjmQ@paquier.xyz>
<CAFC+b6rOdx6rMi_numCrK8cM4z_HWQKrAcBY0dfrRcRWTRpsBQ@mail.gmail.com>
<ak16dMkUP1pS0rCn@paquier.xyz>
<ak2jc7mIhcMDkm-k@paquier.xyz>
<bc6ec409-41ca-4889-a5c7-4e2f7a3f081c@iki.fi>
<21477053-efd1-485a-8f72-c2e292fcf2a0@garret.ru>
<ak806l8j5A45y2LD@paquier.xyz>
On 09/07/2026 8:43 AM, Michael Paquier wrote:
> On Thu, Jul 09, 2026 at 08:17:06AM +0300, Konstantin Knizhnik wrote:
>> Changing `table_relation_fetch_toast_slice` signature breaks compatibility
>> with some extensions, for example duckdb.
>> I wonder if we can change only `bool (*relation_fetch_toast_slice)(...,
>> bool missing_ok)` callback signature, but preserve signature of
>> `table_relation_fetch_toast_slice`, adding one more function
>> `table_relation_try_fetch_toast_slice`:
> Thanks for the input.
>
> Adding more functions implies to change the size of TableAmRoutine,
> which may be bad. For now I'd be tempted to just focus on how to fix
> the problem on HEAD in a way we are happy with. We could sort out an
> optional back-branch version as a second step.
> --
> Michael
Sorry, I do not suggest to extend TableAmRoutine - it will contain
single `relation_fetch_toast_slice` entry with new signature.
I suggest to add only new wrapper function
`table_relation_try_fetch_toast_slice`, preserving original
`table_relation_fetch_toast_slice`. It will preserve compatibility with
extensions (there are not using TableAmRoutine directly) and do not
extend TableAmRoutine.
view thread (26+ messages) latest in thread
Message-ID: <53dd03d4-5aab-405d-bff3-f3c5433edef7@garret.ru>
Permalink: ../../53dd03d4-5aab-405d-bff3-f3c5433edef7@garret.ru/
Also on: postgresql.org/message-id/53dd03d4-5aab-405d-bff3-f3c5433edef7@garret.ru
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: knizhnik@garret.ru, michael@paquier.xyz, hlinnaka@iki.fi, srinath2133@gmail.com, boekewurm+postgres@gmail.com, imran.zhir@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19519: REPACK can fail due to missing chunk for toast value
In-Reply-To: <53dd03d4-5aab-405d-bff3-f3c5433edef7@garret.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox