public inbox for [email protected]
help / color / mirror / Atom feedFrom: Konstantin Knizhnik <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Srinath Reddy Sadipiralla <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: Imran Zaheer <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: PostgreSQL mailing lists <[email protected]>
Subject: Re: BUG #19519: REPACK can fail due to missing chunk for toast value
Date: Thu, 9 Jul 2026 13:08:43 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAEze2WhCRX86ZY2QN7vuGc3wsAyOJbArFSc0i5KtMVnsguA7Kw@mail.gmail.com>
<[email protected]>
<CAEze2WgBjhf6KTKuJ-UqHHGj9Z66f62grmJgZ1EazvMH9HU+XA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAFC+b6rOdx6rMi_numCrK8cM4z_HWQKrAcBY0dfrRcRWTRpsBQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
On 09/07/2026 8:43 AM, Michael Paquier wrote:
> On Thu, Jul 09, 2026 at 08:17:06AM +0300, Konstantin Knizhnik wrote:
>> Changing `table_relation_fetch_toast_slice` signature breaks compatibility
>> with some extensions, for example duckdb.
>> I wonder if we can change only `bool (*relation_fetch_toast_slice)(...,
>> bool missing_ok)` callback signature, but preserve signature of
>> `table_relation_fetch_toast_slice`, adding one more function
>> `table_relation_try_fetch_toast_slice`:
> Thanks for the input.
>
> Adding more functions implies to change the size of TableAmRoutine,
> which may be bad. For now I'd be tempted to just focus on how to fix
> the problem on HEAD in a way we are happy with. We could sort out an
> optional back-branch version as a second step.
> --
> Michael
Sorry, I do not suggest to extend TableAmRoutine - it will contain
single `relation_fetch_toast_slice` entry with new signature.
I suggest to add only new wrapper function
`table_relation_try_fetch_toast_slice`, preserving original
`table_relation_fetch_toast_slice`. It will preserve compatibility with
extensions (there are not using TableAmRoutine directly) and do not
extend TableAmRoutine.
view thread (21+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: BUG #19519: REPACK can fail due to missing chunk for toast value
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox