Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQYZa-0001b1-5X for pgsql-bugs@arkaria.postgresql.org; Mon, 20 Apr 2020 15:43:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jQYZZ-0002bV-2r for pgsql-bugs@arkaria.postgresql.org; Mon, 20 Apr 2020 15:43:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQYZY-0002bO-OM for pgsql-bugs@lists.postgresql.org; Mon, 20 Apr 2020 15:43:00 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQYZR-0001nb-9F for pgsql-bugs@postgresql.org; Mon, 20 Apr 2020 15:42:59 +0000 Received: from hnk.local (p2421237-ipbf2725funabasi.chiba.ocn.ne.jp [122.24.33.237]) by oss.nttdata.com (Postfix) with ESMTPSA id 3DB43602D0; Tue, 21 Apr 2020 00:42:49 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: pg_stat_statements: rows not updated for CREATE TABLE AS SELECT statements To: legrand legrand , pgsql-bugs@postgresql.org References: <1584293755198-0.post@n3.nabble.com> <1585330995153-0.post@n3.nabble.com> From: Fujii Masao Message-ID: <54fa2fec-b133-0fc0-4227-3e308ba68812@oss.nttdata.com> Date: Tue, 21 Apr 2020 00:42:48 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1585330995153-0.post@n3.nabble.com> Content-Type: multipart/mixed; boundary="------------9D8578200E4A2FADFDEBA7EF" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------9D8578200E4A2FADFDEBA7EF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2020/03/28 2:43, legrand legrand wrote: > Thank you for those answers ! > >> The utility commands that return CMDTAG_SELECT are >> only CREATE TABLE AS SELECT and CREATE MATERIALIZED VIEW? >> I'd just like to confirm that there is no case where "rows" must not >> be counted when CMDTAG_SELECT is returned. > > I don't have any in mind ... I found that SELECT INTO also returns CMDTAG_SELECT. > >> BTW, "rows" should be updated when FETCH or MOVE is executed >> because each command returns or affects the rows? > > Yes they should, but they aren't yet (event with CMDTAG_SELECT added) > > Note that implicit cursors behave the same way ;o( Thanks for confirming this! Attached is the patch that makes pgss track the total number of rows retrieved or affected by CREATE TABLE AS, SELECT INTO, CREATE MATERIALIZED VIEW and FETCH. I think this is new feature rather than bug fix, so am planning to add this patch into next CommitFest for v14. Thought? Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------9D8578200E4A2FADFDEBA7EF Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="pgss_track_rows_of_utility_v1.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="pgss_track_rows_of_utility_v1.patch" ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcGdfc3RhdF9zdGF0ZW1lbnRzL2V4cGVjdGVkL3BnX3N0 YXRfc3RhdGVtZW50cy5vdXQgYi9jb250cmliL3BnX3N0YXRfc3RhdGVtZW50cy9leHBlY3Rl ZC9wZ19zdGF0X3N0YXRlbWVudHMub3V0CmluZGV4IGY2MTVmOGMyYmYuLjVlNWVlNWU4OTkg MTAwNjQ0Ci0tLSBhL2NvbnRyaWIvcGdfc3RhdF9zdGF0ZW1lbnRzL2V4cGVjdGVkL3BnX3N0 YXRfc3RhdGVtZW50cy5vdXQKKysrIGIvY29udHJpYi9wZ19zdGF0X3N0YXRlbWVudHMvZXhw ZWN0ZWQvcGdfc3RhdF9zdGF0ZW1lbnRzLm91dApAQCAtNTI3LDYgKzUyNyw2OSBAQCBTRUxF Q1QgcXVlcnksIGNhbGxzLCByb3dzIEZST00gcGdfc3RhdF9zdGF0ZW1lbnRzIE9SREVSIEJZ IHF1ZXJ5IENPTExBVEUgIkMiOwogIFNFTEVDVCBxdWVyeSwgY2FsbHMsIHJvd3MgRlJPTSBw Z19zdGF0X3N0YXRlbWVudHMgT1JERVIgQlkgcXVlcnkgQ09MTEFURSAiQyIgfCAgICAgMCB8 ICAgIDAKICg5IHJvd3MpCiAKKy0tCistLSBUcmFjayB0aGUgdG90YWwgbnVtYmVyIG9mIHJv d3MgcmV0cmlldmVkIG9yIGFmZmVjdGVkIGJ5IHRoZSB1dGlsaXR5CistLSBjb21tYW5kcyBv ZiBDT1BZLCBGRVRDSCwgQ1JFQVRFIFRBQkxFIEFTLCBDUkVBVEUgTUFURVJJQUxJWkVEIFZJ RVcKKy0tIGFuZCBTRUxFQ1QgSU5UTworLS0KK1NFTEVDVCBwZ19zdGF0X3N0YXRlbWVudHNf cmVzZXQoKTsKKyBwZ19zdGF0X3N0YXRlbWVudHNfcmVzZXQgCistLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQorIAorKDEgcm93KQorCitDUkVBVEUgVEFCTEUgcGdzc19jdGFzIEFTIFNF TEVDVCBhLCAnY3RhcycgYiBGUk9NIGdlbmVyYXRlX3NlcmllcygxLCAxMCkgYTsKK1NFTEVD VCBnZW5lcmF0ZV9zZXJpZXMoMSwgMTApIGMgSU5UTyBwZ3NzX3NlbGVjdF9pbnRvOworQ09Q WSBwZ3NzX2N0YXMgKGEsIGIpIEZST00gU1RESU47CitDUkVBVEUgTUFURVJJQUxJWkVEIFZJ RVcgcGdzc19tYXR2IEFTIFNFTEVDVCAqIEZST00gcGdzc19jdGFzOworQkVHSU47CitERUNM QVJFIHBnc3NfY3Vyc29yIENVUlNPUiBGT1IgU0VMRUNUICogRlJPTSBwZ3NzX21hdHY7CitG RVRDSCBORVhUIHBnc3NfY3Vyc29yOworIGEgfCAgYiAgIAorLS0tKy0tLS0tLQorIDEgfCBj dGFzCisoMSByb3cpCisKK0ZFVENIIEZPUldBUkQgNSBwZ3NzX2N1cnNvcjsKKyBhIHwgIGIg ICAKKy0tLSstLS0tLS0KKyAyIHwgY3RhcworIDMgfCBjdGFzCisgNCB8IGN0YXMKKyA1IHwg Y3RhcworIDYgfCBjdGFzCisoNSByb3dzKQorCitGRVRDSCBGT1JXQVJEIEFMTCBwZ3NzX2N1 cnNvcjsKKyBhICB8ICBiICAgCistLS0tKy0tLS0tLQorICA3IHwgY3RhcworICA4IHwgY3Rh cworICA5IHwgY3RhcworIDEwIHwgY3RhcworIDExIHwgY29weQorIDEyIHwgY29weQorIDEz IHwgY29weQorKDcgcm93cykKKworQ09NTUlUOworU0VMRUNUIHF1ZXJ5LCBwbGFucywgY2Fs bHMsIHJvd3MgRlJPTSBwZ19zdGF0X3N0YXRlbWVudHMgT1JERVIgQlkgcXVlcnkgQ09MTEFU RSAiQyI7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcXVlcnkg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBwbGFucyB8IGNhbGxz IHwgcm93cyAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rLS0tLS0tLSstLS0t LS0tKy0tLS0tLQorIEJFR0lOICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgIDAgfCAg ICAgMSB8ICAgIDAKKyBDT01NSVQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgICAwIHwg ICAgIDEgfCAgICAwCisgQ09QWSBwZ3NzX2N0YXMgKGEsIGIpIEZST00gU1RESU4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAgMCB8 ICAgICAxIHwgICAgMworIENSRUFURSBNQVRFUklBTElaRUQgVklFVyBwZ3NzX21hdHYgQVMg U0VMRUNUICogRlJPTSBwZ3NzX2N0YXMgICAgICAgICAgICAgICAgICAgICAgIHwgICAgIDAg fCAgICAgMSB8ICAgMTMKKyBDUkVBVEUgVEFCTEUgcGdzc19jdGFzIEFTIFNFTEVDVCBhLCAn Y3RhcycgYiBGUk9NIGdlbmVyYXRlX3NlcmllcygxLCAxMCkgYSAgICAgICAgICB8ICAgICAw IHwgICAgIDEgfCAgIDEwCisgREVDTEFSRSBwZ3NzX2N1cnNvciBDVVJTT1IgRk9SIFNFTEVD VCAqIEZST00gcGdzc19tYXR2ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAg MCB8ICAgICAxIHwgICAgMAorIEZFVENIIEZPUldBUkQgNSBwZ3NzX2N1cnNvciAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAg IDAgfCAgICAgMSB8ICAgIDUKKyBGRVRDSCBGT1JXQVJEIEFMTCBwZ3NzX2N1cnNvciAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg ICAwIHwgICAgIDEgfCAgICA3CisgRkVUQ0ggTkVYVCBwZ3NzX2N1cnNvciAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg ICAgMCB8ICAgICAxIHwgICAgMQorIFNFTEVDVCBnZW5lcmF0ZV9zZXJpZXMoMSwgMTApIGMg SU5UTyBwZ3NzX3NlbGVjdF9pbnRvICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAgIDAgfCAgICAgMSB8ICAgMTAKKyBTRUxFQ1QgcGdfc3RhdF9zdGF0ZW1lbnRzX3Jlc2V0 KCkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgICAwIHwgICAgIDEgfCAgICAxCisgU0VMRUNUIHF1ZXJ5LCBwbGFucywgY2FsbHMsIHJv d3MgRlJPTSBwZ19zdGF0X3N0YXRlbWVudHMgT1JERVIgQlkgcXVlcnkgQ09MTEFURSAiQyIg fCAgICAgMSB8ICAgICAwIHwgICAgMAorKDEyIHJvd3MpCisKIC0tCiAtLSBUcmFjayB1c2Vy IGFjdGl2aXR5IGFuZCByZXNldCB0aGVtCiAtLQpAQCAtNzI3LDYgKzc5MCw5IEBAIFNFTEVD VCBxdWVyeSwgY2FsbHMsIHJvd3MgRlJPTSBwZ19zdGF0X3N0YXRlbWVudHMgT1JERVIgQlkg cXVlcnkgQ09MTEFURSAiQyI7CiAtLQogRFJPUCBST0xFIHJlZ3Jlc3Nfc3RhdHNfdXNlcjE7 CiBEUk9QIFJPTEUgcmVncmVzc19zdGF0c191c2VyMjsKK0RST1AgTUFURVJJQUxJWkVEIFZJ RVcgcGdzc19tYXR2OworRFJPUCBUQUJMRSBwZ3NzX2N0YXM7CitEUk9QIFRBQkxFIHBnc3Nf c2VsZWN0X2ludG87CiAtLQogLS0gW3JlXXBsYW4gY291bnRpbmcKIC0tCmRpZmYgLS1naXQg YS9jb250cmliL3BnX3N0YXRfc3RhdGVtZW50cy9wZ19zdGF0X3N0YXRlbWVudHMuYyBiL2Nv bnRyaWIvcGdfc3RhdF9zdGF0ZW1lbnRzL3BnX3N0YXRfc3RhdGVtZW50cy5jCmluZGV4IDkw YmM2ZmQwMTMuLjljMTY4OWZkOTYgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvcGdfc3RhdF9zdGF0 ZW1lbnRzL3BnX3N0YXRfc3RhdGVtZW50cy5jCisrKyBiL2NvbnRyaWIvcGdfc3RhdF9zdGF0 ZW1lbnRzL3BnX3N0YXRfc3RhdGVtZW50cy5jCkBAIC0xMTcwLDcgKzExNzAsMTUgQEAgcGdz c19Qcm9jZXNzVXRpbGl0eShQbGFubmVkU3RtdCAqcHN0bXQsIGNvbnN0IGNoYXIgKnF1ZXJ5 U3RyaW5nLAogCQlJTlNUUl9USU1FX1NFVF9DVVJSRU5UKGR1cmF0aW9uKTsKIAkJSU5TVFJf VElNRV9TVUJUUkFDVChkdXJhdGlvbiwgc3RhcnQpOwogCi0JCXJvd3MgPSAocWMgJiYgcWMt PmNvbW1hbmRUYWcgPT0gQ01EVEFHX0NPUFkpID8gcWMtPm5wcm9jZXNzZWQgOiAwOworCQkv KgorCQkgKiBUcmFjayB0aGUgdG90YWwgbnVtYmVyIG9mIHJvd3MgcmV0cmlldmVkIG9yIGFm ZmVjdGVkIGJ5CisJCSAqIHRoZSB1dGlsaXR5IHN0YXRlbWVudHMgb2YgQ09QWSwgRkVUQ0gs IENSRUFURSBUQUJMRSBBUywKKwkJICogQ1JFQVRFIE1BVEVSSUFMSVpFRCBWSUVXIGFuZCBT RUxFQ1QgSU5UTy4KKwkJICovCisJCXJvd3MgPSAocWMgJiYgKHFjLT5jb21tYW5kVGFnID09 IENNRFRBR19DT1BZIHx8CisJCQkJCSAgIHFjLT5jb21tYW5kVGFnID09IENNRFRBR19GRVRD SCB8fAorCQkJCQkgICBxYy0+Y29tbWFuZFRhZyA9PSBDTURUQUdfU0VMRUNUKSkgPworCQkJ cWMtPm5wcm9jZXNzZWQgOiAwOwogCiAJCS8qIGNhbGMgZGlmZmVyZW5jZXMgb2YgYnVmZmVy IGNvdW50ZXJzLiAqLwogCQltZW1zZXQoJmJ1ZnVzYWdlLCAwLCBzaXplb2YoQnVmZmVyVXNh Z2UpKTsKZGlmZiAtLWdpdCBhL2NvbnRyaWIvcGdfc3RhdF9zdGF0ZW1lbnRzL3NxbC9wZ19z dGF0X3N0YXRlbWVudHMuc3FsIGIvY29udHJpYi9wZ19zdGF0X3N0YXRlbWVudHMvc3FsL3Bn X3N0YXRfc3RhdGVtZW50cy5zcWwKaW5kZXggNzVjMTA1NTRhOC4uM2NiYWY0NWM5ZCAxMDA2 NDQKLS0tIGEvY29udHJpYi9wZ19zdGF0X3N0YXRlbWVudHMvc3FsL3BnX3N0YXRfc3RhdGVt ZW50cy5zcWwKKysrIGIvY29udHJpYi9wZ19zdGF0X3N0YXRlbWVudHMvc3FsL3BnX3N0YXRf c3RhdGVtZW50cy5zcWwKQEAgLTI0OSw2ICsyNDksMzAgQEAgRFJPUCBGVU5DVElPTiBQTFVT X1RXTyhJTlRFR0VSKTsKIAogU0VMRUNUIHF1ZXJ5LCBjYWxscywgcm93cyBGUk9NIHBnX3N0 YXRfc3RhdGVtZW50cyBPUkRFUiBCWSBxdWVyeSBDT0xMQVRFICJDIjsKIAorLS0KKy0tIFRy YWNrIHRoZSB0b3RhbCBudW1iZXIgb2Ygcm93cyByZXRyaWV2ZWQgb3IgYWZmZWN0ZWQgYnkg dGhlIHV0aWxpdHkKKy0tIGNvbW1hbmRzIG9mIENPUFksIEZFVENILCBDUkVBVEUgVEFCTEUg QVMsIENSRUFURSBNQVRFUklBTElaRUQgVklFVworLS0gYW5kIFNFTEVDVCBJTlRPCistLQor U0VMRUNUIHBnX3N0YXRfc3RhdGVtZW50c19yZXNldCgpOworCitDUkVBVEUgVEFCTEUgcGdz c19jdGFzIEFTIFNFTEVDVCBhLCAnY3RhcycgYiBGUk9NIGdlbmVyYXRlX3NlcmllcygxLCAx MCkgYTsKK1NFTEVDVCBnZW5lcmF0ZV9zZXJpZXMoMSwgMTApIGMgSU5UTyBwZ3NzX3NlbGVj dF9pbnRvOworQ09QWSBwZ3NzX2N0YXMgKGEsIGIpIEZST00gU1RESU47CisxMQljb3B5Cisx Mgljb3B5CisxMwljb3B5CitcLgorQ1JFQVRFIE1BVEVSSUFMSVpFRCBWSUVXIHBnc3NfbWF0 diBBUyBTRUxFQ1QgKiBGUk9NIHBnc3NfY3RhczsKK0JFR0lOOworREVDTEFSRSBwZ3NzX2N1 cnNvciBDVVJTT1IgRk9SIFNFTEVDVCAqIEZST00gcGdzc19tYXR2OworRkVUQ0ggTkVYVCBw Z3NzX2N1cnNvcjsKK0ZFVENIIEZPUldBUkQgNSBwZ3NzX2N1cnNvcjsKK0ZFVENIIEZPUldB UkQgQUxMIHBnc3NfY3Vyc29yOworQ09NTUlUOworCitTRUxFQ1QgcXVlcnksIHBsYW5zLCBj YWxscywgcm93cyBGUk9NIHBnX3N0YXRfc3RhdGVtZW50cyBPUkRFUiBCWSBxdWVyeSBDT0xM QVRFICJDIjsKKwogLS0KIC0tIFRyYWNrIHVzZXIgYWN0aXZpdHkgYW5kIHJlc2V0IHRoZW0K IC0tCkBAIC0zMTIsNiArMzM2LDkgQEAgU0VMRUNUIHF1ZXJ5LCBjYWxscywgcm93cyBGUk9N IHBnX3N0YXRfc3RhdGVtZW50cyBPUkRFUiBCWSBxdWVyeSBDT0xMQVRFICJDIjsKIC0tCiBE Uk9QIFJPTEUgcmVncmVzc19zdGF0c191c2VyMTsKIERST1AgUk9MRSByZWdyZXNzX3N0YXRz X3VzZXIyOworRFJPUCBNQVRFUklBTElaRUQgVklFVyBwZ3NzX21hdHY7CitEUk9QIFRBQkxF IHBnc3NfY3RhczsKK0RST1AgVEFCTEUgcGdzc19zZWxlY3RfaW50bzsKIAogLS0KIC0tIFty ZV1wbGFuIGNvdW50aW5nCg== --------------9D8578200E4A2FADFDEBA7EF--