From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
        Hamid Akhtar <hamid.akhtar@gmail.com>,
        Simon Riggs <simon.riggs@enterprisedb.com>,
        "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>
Subject: Re: Bug in error reporting for multi-line JSON
In-reply-to: <A999DFE1-BD97-4E93-9EBF-55B386974C90@yesql.se>
References: 
 <CANbhV-EPBnXm3MF_TTWBwwqgn1a1Ghmep9VHfqmNBQ8BT0f+_g@mail.gmail.com>
 <914794.1611252508@sss.pgh.pa.us>
 <CANbhV-FJk_+XTcnuuxujP2FUi7qwC=sUUyEBcbqYoOWmZhxD4A@mail.gmail.com>
 <CANugjhuR8U+uzSptTZ7tEUGvCt8vGnSz89rRw+89yd+wx_nLvA@mail.gmail.com>
 <CANugjhsOvEk9OJ4b1Y3CxC9A8GwHt-cRU1-ymiod859En833-Q@mail.gmail.com>
 <01F48B70-5CAA-4922-B900-80E49A2D8488@yesql.se>
 <849057.1614635401@sss.pgh.pa.us>
 <OS0PR01MB61137C4054774F44E3A9DC89FBC69@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <A999DFE1-BD97-4E93-9EBF-55B386974C90@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 25 Aug 2021 10:56:31 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <552304.1629903352.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 25 Aug 2021 10:55:52 -0400
Message-ID: <552305.1629903352@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/552305.1629903352%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 25 Aug 2021, at 10:22, tanghy.fnst@fujitsu.com wrote:
>> I think the while condition "context_start < context_end" added in comm=
it ffd3944ab9 is useless. Thoughts?

> Judging by the diff it=E2=80=99s likely a leftover from the previous cod=
ing.  I don=E2=80=99t
> see a case for when it would hit, but it also doesn=E2=80=99t seem to do=
 any harm apart
> from potentially causing static analyzers to get angry.

Yeah.  I think that while reviewing this patch I read the while-condition
as a range check on context_start, but it isn't --- both inequalities
are in the same direction.  I suppose there could be some quibble
about what happens if context_end - context_start is so large as to
overflow an integer, but that's never gonna happen (and if it did,
we'd have other issues, for instance the lack of any check-for-interrupt
in this loop).

Will fix.

			regards, tom lane