From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: James Inform <james.inform@pharmapp.de>,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
        Euler Taveira <euler@eulerto.com>
Subject: Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation
In-reply-to: 
 <CAH2-Wzn9jjv22x-Vto-5xo_YJNuMWid0xuOGMcN+LYSXRk-PPA@mail.gmail.com>
References: <17584-95c79b4a7d771f44@postgresql.org>
 <f6d74de8-df28-4ef7-8d9e-10f2ab77ea8e@www.fastmail.com>
 <a9851f48-b281-8313-52f4-59ece14adb86@pharmapp.de>
 <465044.1660428315@sss.pgh.pa.us>
 <92087cd5-5410-a4e9-41fe-4ff310439190@pharmapp.de>
 <541938.1660437017@sss.pgh.pa.us>
 <CAH2-Wzk11wvwjhrbje4DDyXydy5pGACb4wNCHCXiuij0Y10h+Q@mail.gmail.com>
 <555147.1660447264@sss.pgh.pa.us>
 <CAH2-Wzn9jjv22x-Vto-5xo_YJNuMWid0xuOGMcN+LYSXRk-PPA@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Sat, 13 Aug 2022 20:55:46 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <559702.1660450255.1@sss.pgh.pa.us>
Date: Sun, 14 Aug 2022 00:10:55 -0400
Message-ID: <559703.1660450255@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/559703.1660450255%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> On Sat, Aug 13, 2022 at 8:21 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmm, but if we're enlarging the buffer, doesn't that imply
>> a new input value?  Seems like invalidation must occur anyway.

> Yeah, on second thought it should be invalidated anyway (I had to
> check because the details of how we cache strxfrm() and strcoll() are
> tricky). Even still, I think that we should just use repalloc for
> this.

Works for me.  I'll see about pushing the fix tomorrow.  Thanks
for the additional investigation!

			regards, tom lane