Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iozd5-0004Uh-R2 for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Jan 2020 00:55:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iozd4-0003qf-8H for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Jan 2020 00:55:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iozd3-0003mK-Rq for pgsql-hackers@lists.postgresql.org; Wed, 08 Jan 2020 00:55:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iozd1-00067r-JK for pgsql-hackers@lists.postgresql.org; Wed, 08 Jan 2020 00:55:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 0080tHGN005603; Tue, 7 Jan 2020 19:55:17 -0500 From: Tom Lane To: Michael Paquier cc: Robert Haas , Mahendra Singh , Kyotaro Horiguchi , PostgreSQL Hackers Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema In-reply-to: <20200108004409.GA3413@paquier.xyz> References: <28862.1577382716@sss.pgh.pa.us> <20191227090604.GA540891@paquier.xyz> <20200106014202.GA3598@paquier.xyz> <31319.1578332027@sss.pgh.pa.us> <20200107002216.GA2386@paquier.xyz> <14868.1578420368@sss.pgh.pa.us> <20200108004409.GA3413@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Wed, 08 Jan 2020 09:44:09 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5601.1578444917.1@sss.pgh.pa.us> Date: Tue, 07 Jan 2020 19:55:17 -0500 Message-ID: <5602.1578444917@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > Okay, I am running out of arguments then, so attached is a patch to > address things. I would also prefer if we keep the relation name in > the log even if the namespace is missing. A couple of thoughts: * Please revert a052f6c as a separate commit specifically doing that, so that when it comes time to make the release notes, it's clear that a052f6c doesn't require documentation. * I think the check on log_min_messages <= LOG is probably wrong, since LOG sorts out of order for this purpose. Compare is_log_level_output() in elog.c. I'd suggest not bothering with trying to optimize away the get_namespace_name call here; we shouldn't be in this code path often enough for performance to matter, and nobody ever cared about it before. * I don't greatly like the notation dropping orphan temp table \"%s.(null).%s\" ... and I bet Robert won't either. Not sure offhand about a better idea --- maybe dropping orphan temp table \"%s\" with OID %u in database \"%s\" regards, tom lane