Message-ID: <56b4ea59-936f-c54f-2e7c-81ac7e638849@enterprisedb.com>
Date: Wed, 20 Apr 2022 18:21:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: =?UTF-8?Q?Re=3a_BUG_=2317466=3a_Is_it_possible_to_supplement_the_de?=
 =?UTF-8?Q?fault_compilation_options_of_CFLAGS_in_configure_file=ef=bc=9f?=
Content-Language: en-US
To: wysunxavier@gmail.com, pgsql-bugs@lists.postgresql.org,
 PG Bug reporting form <noreply@postgresql.org>
References: <17466-6ab1e589e78a166a@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <17466-6ab1e589e78a166a@postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/56b4ea59-936f-c54f-2e7c-81ac7e638849%40enterprisedb.com>
Precedence: bulk

On 19.04.22 05:36, PG Bug reporting form wrote:
> When I try to specify some compilation options in CFLAGS, such as compiling
> with macros, when I execute “./configure CFLAGS='-DUSE_TOOLS'”,it will use
> '-O0' to compile by default, which is easy to miscompile into a debug
> version. I wonder if it is possible to supplement the judgment conditions in
> the postgresql source code: If the compilation option is not specified in
> CFLAGS, '-O2' is used by default to avoid compiling the wrong debug
> version.

The use case you are describing is not without merit.  But ultimately, 
the handling of these compiler option variables has decades of history 
behind it, and just poking at that for one specific case is going to 
break someone else's use case somehow.

We generally avoid the need to add CFLAGS to the configure command line 
except in cases where you actually want to override the defaults.  Other 
cases should have a command-line option or perhaps a spot in 
pg_config_manual.h.

In your specific case you could also pass CPPFLAGS instead, which is 
more correct anyway, and it doesn't have a default that you can 
accidentally override.