From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: James Inform <james.inform@pharmapp.de>,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
        Euler Taveira <euler@eulerto.com>
Subject: Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation
In-reply-to: <559703.1660450255@sss.pgh.pa.us>
References: <17584-95c79b4a7d771f44@postgresql.org>
 <f6d74de8-df28-4ef7-8d9e-10f2ab77ea8e@www.fastmail.com>
 <a9851f48-b281-8313-52f4-59ece14adb86@pharmapp.de>
 <465044.1660428315@sss.pgh.pa.us>
 <92087cd5-5410-a4e9-41fe-4ff310439190@pharmapp.de>
 <541938.1660437017@sss.pgh.pa.us>
 <CAH2-Wzk11wvwjhrbje4DDyXydy5pGACb4wNCHCXiuij0Y10h+Q@mail.gmail.com>
 <555147.1660447264@sss.pgh.pa.us>
 <CAH2-Wzn9jjv22x-Vto-5xo_YJNuMWid0xuOGMcN+LYSXRk-PPA@mail.gmail.com>
 <559703.1660450255@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sun, 14 Aug 2022 00:10:55 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <587800.1660457745.1@sss.pgh.pa.us>
Date: Sun, 14 Aug 2022 02:15:45 -0400
Message-ID: <587801.1660457745@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/587801.1660457745%40sss.pgh.pa.us>
Precedence: bulk

... BTW, I wondered how come we'd missed noticing such a serious problem
in any testing.  The code coverage report at

https://coverage.postgresql.org/src/backend/utils/adt/varlena.c.gcov.html

says that only the "if (sss->collate_c)" path in varstr_abbrev_convert
gets exercised in our regression tests.  I thought maybe that just
meant that the coverage.postgresql.org run uses C locale, but I see
the same lack-of-coverage in a local test under LANG=en_US.utf8.
How can we only be reaching this function with sss->collate_c true
when the prevailing locale isn't that?

			regards, tom lane