Message-ID: <58e47d097ed2a1512f47891293a7102d573fc970.camel@cybertec.at>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in
 catalog
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: =?ISO-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>, Virender
 Singla <virender.cse@gmail.com>, pgsql-bugs@lists.postgresql.org, Aniket
 Jha	 <aniketkumarj@gmail.com>
Date: Fri, 21 Feb 2025 17:23:24 +0100
In-Reply-To: <3073713.1740148903@sss.pgh.pa.us>
References: <202502131716.7mgkcnrem2hn@alvherre.pgsql>
	 <2939991.1740089974@sss.pgh.pa.us>
	 <b0459688caa95c77f439bebf3b30341169986369.camel@cybertec.at>
	 <3073713.1740148903@sss.pgh.pa.us>
User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) 
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/58e47d097ed2a1512f47891293a7102d573fc970.camel%40cybertec.at>
Precedence: bulk

On Fri, 2025-02-21 at 09:41 -0500, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > I have one question about the first patch:
> 
> > > -	if (addroleto || adminmembers || rolemembers)
> > > +	if (addroleto || adminmembers || rolemembers || !superuser())
> > > 		CommandCounterIncrement();
> 
> > That change seems unrelated to the problem at hand, and I don't see it
> > mentioned in the commit message.  Is that an oversight you fixed on the
> > fly?
> 
> Well, kinda, because the patch doesn't work without it.  The
> problematic case is where none of those 3 flags are set and also
> !superuser, so that we decide we need the default grant implemented a
> few lines further down.  That grant now has an explicit reference to
> the new roleid, and if we haven't CommandCounterIncrement'ed, the
> pg_shdepend code will error out because it doesn't see the catalog
> entry for roleid.

Thanks for the explanation.  That might be worth a comment.

Yours,
Laurenz Albe

-- 

*E-Mail Disclaimer*
Der Inhalt dieser E-Mail ist ausschliesslich fuer den 
bezeichneten Adressaten bestimmt. Wenn Sie nicht der vorgesehene Adressat 
dieser E-Mail oder dessen Vertreter sein sollten, so beachten Sie bitte, 
dass jede Form der Kenntnisnahme, Veroeffentlichung, Vervielfaeltigung oder 
Weitergabe des Inhalts dieser E-Mail unzulaessig ist. Wir bitten Sie, sich 
in diesem Fall mit dem Absender der E-Mail in Verbindung zu setzen.

*CONFIDENTIALITY NOTICE & DISCLAIMER
*This message and any attachment are 
confidential and may be privileged or otherwise protected from disclosure 
and solely for the use of the person(s) or entity to whom it is intended. 
If you have received this message in error and are not the intended 
recipient, please notify the sender immediately and delete this message and 
any attachment from your system. If you are not the intended recipient, be 
advised that any use of this message is prohibited and may be unlawful, and 
you must not copy this message or attachment or disclose the contents to 
any other person.