Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1u2wVJ-0086hD-94
	for pgsql-bugs@arkaria.postgresql.org; Thu, 10 Apr 2025 18:19:57 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1u2wVH-00Fpns-Ij
	for pgsql-bugs@arkaria.postgresql.org; Thu, 10 Apr 2025 18:19:55 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1u2wVH-00Fpnj-A8
	for pgsql-bugs@lists.postgresql.org; Thu, 10 Apr 2025 18:19:55 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1u2wVF-0046L5-2e
	for pgsql-bugs@lists.postgresql.org;
	Thu, 10 Apr 2025 18:19:54 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 53AIJqAh593244;
	Thu, 10 Apr 2025 14:19:53 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: dan-eli@mail.ru
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18889: /src/backend/utils/adt/network.c condition is always
 false
In-reply-to: <18889-73d4f19e953a629e@postgresql.org>
References: <18889-73d4f19e953a629e@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Thu, 10 Apr 2025 16:41:51 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <593242.1744309192.1@sss.pgh.pa.us>
Date: Thu, 10 Apr 2025 14:19:52 -0400
Message-ID: <593243.1744309192@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/593243.1744309192%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> On line 282 there is a check of nb < 0, which is always false, so i think it
> is better to be replaced with 'Assert(nb > 0);'

This one I do agree with getting rid of --- in fact, I don't
even see a need for an Assert.  Done at f27eb0325.

			regards, tom lane