From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Justin Pryzby <pryzby@telsasoft.com>, Peter Geoghegan <pg@bowt.ie>,
        postgresql@taljaren.se, pgsql-hackers@lists.postgresql.org,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and
 possible memory issue)
In-reply-to: <20221229182657.GA165622@nathanxps13>
References: <3439037.1671130590@sss.pgh.pa.us>
 <CAH2-Wzne4Wgaaruq-VSY2qWNhxcPRqWUbdwVQPkM81TpaHY_kQ@mail.gmail.com>
 <3544447.1671141436@sss.pgh.pa.us>
 <CAH2-WzkXmYt-K+pQqMqjFgwU7jiykD3amngd5-jkqQF=gST7Og@mail.gmail.com>
 <3672943.1671202149@sss.pgh.pa.us>
 <CAH2-WzkHRxcE-0Mub9N0Rr09SGEEF1Ex4pUbcOBSRoNGNVy93w@mail.gmail.com>
 <407579.1672258403@sss.pgh.pa.us> <20221229012354.GF1153@telsasoft.com>
 <451605.1672280274@sss.pgh.pa.us> <576868.1672334578@sss.pgh.pa.us>
 <20221229182657.GA165622@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Thu, 29 Dec 2022 10:26:57 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <599740.1672345755.1@sss.pgh.pa.us>
Date: Thu, 29 Dec 2022 15:29:15 -0500
Message-ID: <599741.1672345755@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/599741.1672345755%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Thu, Dec 29, 2022 at 12:22:58PM -0500, Tom Lane wrote:
>> Justin Pryzby <pryzby@telsasoft.com> writes:
>>> VACUUM (UPDATE_DATABASE_STATS {yes,no,only})
>>>> VACUUM (DATABASE_STATS {UPDATE,SKIP,ONLY})

> +1 for only introducing one option.  IMHO UPDATE_DATABASE_STATS fits a
> little better since it states the action like most of the other options,
> but I think both choices are sufficiently clear.

I tried to make a patch along these lines, and soon hit a stumbling
block: ONLY is a fully-reserved SQL keyword.  I don't think this
syntax is attractive enough to justify requiring people to
double-quote the option, so we are back to square one.  Anybody
have a different suggestion?

			regards, tom lane