Message-ID: <5C1A0B6C.1040502@lab.ntt.co.jp>
Date: Wed, 19 Dec 2018 18:12:12 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a
 transaction
References: <15552-c64aa14c5c22f63c@postgresql.org>
 <8e82d10d-cc16-eed4-7634-3654f59d8053@lab.ntt.co.jp>
 <LEJPR01MB00109D0BECB8A961074A7CAFE7BC0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
 <30718b48-8020-329a-c6f0-74e1222e5283@lab.ntt.co.jp>
 <5C18ECBB.2000507@lab.ntt.co.jp>
 <LEJPR01MB001074FD67CB65B539122E4DE7BD0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
 <3539e73a-313a-5406-27c7-850affb47921@lab.ntt.co.jp>
 <20181219023814.GA6577@paquier.xyz>
 <6daa6d4a-d4a9-bd2c-0b84-c4e31d2b9844@lab.ntt.co.jp>
 <5C19F7FF.9060904@lab.ntt.co.jp> <20181219083422.GA680@paquier.xyz>
In-Reply-To: <20181219083422.GA680@paquier.xyz>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
        Luis Carril <luis.carril@swarm64.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>,
        PG Bug reporting form <noreply@postgresql.org>,
        Michael Paquier <michael.paquier@gmail.com>
Precedence: bulk

(2018/12/19 17:34), Michael Paquier wrote:
> On Wed, Dec 19, 2018 at 04:49:19PM +0900, Etsuro Fujita wrote:
>> BTW I noticed that this error occurs not only for foreign tables but for
>> views with INSTEAD OF INSERT triggers.  Here is an example on HEAD:
>>
>> To fix this I think we would also need the same treatment for the view case.
>
> Yes, this means an extra relkind check for views.

I think so too.  I think it might be better to add regression tests for 
the view case as well, though.

> Would you like to
> update the patch yourself?

I'd be happy if you worked on that.

Best regards,
Etsuro Fujita