Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gaBoR-0004J5-Mp for pgsql-bugs@arkaria.postgresql.org; Fri, 21 Dec 2018 03:49:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gaBoP-0005Mk-ME for pgsql-bugs@arkaria.postgresql.org; Fri, 21 Dec 2018 03:49:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gaBoP-0005Mb-Cu for pgsql-bugs@lists.postgresql.org; Fri, 21 Dec 2018 03:49:21 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gaBoI-0008Pc-39 for pgsql-bugs@lists.postgresql.org; Fri, 21 Dec 2018 03:49:19 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wBL3nB9R004093; Fri, 21 Dec 2018 12:49:11 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 94A76638533; Fri, 21 Dec 2018 12:49:11 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 88EAB63851E; Fri, 21 Dec 2018 12:49:11 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 846A6400875; Fri, 21 Dec 2018 12:49:11 +0900 (JST) Message-ID: <5C1C62C5.8040409@lab.ntt.co.jp> Date: Fri, 21 Dec 2018 12:49:25 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction References: <30718b48-8020-329a-c6f0-74e1222e5283@lab.ntt.co.jp> <5C18ECBB.2000507@lab.ntt.co.jp> <3539e73a-313a-5406-27c7-850affb47921@lab.ntt.co.jp> <20181219023814.GA6577@paquier.xyz> <6daa6d4a-d4a9-bd2c-0b84-c4e31d2b9844@lab.ntt.co.jp> <5C19F7FF.9060904@lab.ntt.co.jp> <20181219083422.GA680@paquier.xyz> <5C1A0B6C.1040502@lab.ntt.co.jp> <20181220003140.GE27104@paquier.xyz> In-Reply-To: <20181220003140.GE27104@paquier.xyz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Michael Paquier Cc: Amit Langote , Luis Carril , "pgsql-bugs@lists.postgresql.org" , PG Bug reporting form , Michael Paquier X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2018/12/20 9:31), Michael Paquier wrote: > On Wed, Dec 19, 2018 at 06:12:12PM +0900, Etsuro Fujita wrote: >> I think so too. I think it might be better to add regression tests for the >> view case as well, though. > > Agreed. Cool. >>> Would you like to >>> update the patch yourself? >> >> I'd be happy if you worked on that. > > Attached is the patch with two new test cases blowing with wal_level = > minimal. On HEAD, I suggest that we use RELKIND_CAN_HAVE_STORAGE to not > fall again in this trap in the future. For back-branches, let's just > add the appropriate relkind checks as suggested upthread. To make maintenance easy, I think it might be better to add the appropriate relkind checks on HEAD as well. Other than that, the patch looks good to me. > Please note > that the attached patch is for HEAD, and I'll adjust for other branches. > The view part needs to go down to v10, and the part for foreign tables > down to v11. Thanks for the updated patch! Best regards, Etsuro Fujita