Message-ID: <5CA1A320.4050707@lab.ntt.co.jp>
Date: Mon, 01 Apr 2019 14:35:28 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: BUG #15724: Can't create foreign table as partition
References: <20190329141050.GA22336@alvherre.pgsql>
In-Reply-To: <20190329141050.GA22336@alvherre.pgsql>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, stepya@ukr.net,
        pgsql-bugs@lists.postgresql.org
Precedence: bulk

(2019/03/29 23:10), Alvaro Herrera wrote:
> On 2019-Mar-29, Tom Lane wrote:
>
>> Alvaro Herrera<alvherre@2ndquadrant.com>  writes:
>>> On 2019-Mar-29, PG Bug reporting form wrote:
>>>> SQL Error [42809]: ERROR: cannot create index on foreign table "msg_json"

>> Really, what *ought* to happen in such a case is that the FDW gets
>> told about the command and has the opportunity to try to do something
>> corresponding to making an index.

Interesting!

>> corresponding to making an index.  But that smells like a new feature
>> rather than a bug fix.

> ENOTIME to get it done for pg12 I suppose (I don't know a thing about
> postgres_fdw or the FDW API layer).

Yeah, I think so.

>> I'm not sure that just forcing the case to be a no-op is wise.
>> What if the index is supposed to be UNIQUE?
>
> Hmm, good point, that should be disallowed too.

Agreed.

Best regards,
Etsuro Fujita