Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAqd7-0007Tl-Rv for pgsql-bugs@arkaria.postgresql.org; Mon, 01 Apr 2019 06:41:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hAqd6-0000oj-Hs for pgsql-bugs@arkaria.postgresql.org; Mon, 01 Apr 2019 06:41:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAqd6-0000ob-AR for pgsql-bugs@lists.postgresql.org; Mon, 01 Apr 2019 06:41:12 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hAqd3-0003AW-H7 for pgsql-bugs@lists.postgresql.org; Mon, 01 Apr 2019 06:41:11 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x316f7kD001733; Mon, 1 Apr 2019 15:41:07 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 6ACAA638EB8; Mon, 1 Apr 2019 15:41:07 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 5F6D2638D16; Mon, 1 Apr 2019 15:41:07 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 4FB73400B71; Mon, 1 Apr 2019 15:41:07 +0900 (JST) Message-ID: <5CA1B271.4040409@lab.ntt.co.jp> Date: Mon, 01 Apr 2019 15:40:49 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: BUG #15724: Can't create foreign table as partition References: <20190329135519.GA21373@alvherre.pgsql> <21389.1553868091@sss.pgh.pa.us> <1553876622.668408412.24u6zti5@frv53.fwdcdn.com> In-Reply-To: <1553876622.668408412.24u6zti5@frv53.fwdcdn.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Stepan Yankevych Cc: Tom Lane , Alvaro Herrera , pgsql-bugs@lists.postgresql.org X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2019/03/30 1:25), Stepan Yankevych wrote: >>> I'm not sure that just forcing the case to be a no-op is wise. >>> What if the index is supposed to be UNIQUE? > > Anyway it would be better to have no-op in 11.3 than having it not working. > > We just can put comment in the doc like. > > Foreign Server should take care about indexing foreign table as partition. That might be OK, but before doing that, we would need to support eg, unique constraints on foreign tables, so this seems more like a feature than a fix to me. Best regards, Etsuro Fujita