Message-ID: <5CA74513.3040408@lab.ntt.co.jp>
Date: Fri, 05 Apr 2019 21:07:47 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: BUG #15724: Can't create foreign table as partition
References: <21389.1553868091@sss.pgh.pa.us>
 <20190329141050.GA22336@alvherre.pgsql>
 <1553869152.858391073.5f8m3n0x@frv53.fwdcdn.com>
 <5CA1A94E.1070002@lab.ntt.co.jp>
 <6e24fca7-07d1-4f6c-80ec-e817b58859bd@lab.ntt.co.jp>
In-Reply-To: <6e24fca7-07d1-4f6c-80ec-e817b58859bd@lab.ntt.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Stepan Yankevych <stepya@ukr.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Tom Lane <tgl@sss.pgh.pa.us>, pgsql-bugs@lists.postgresql.org,
        etsuro.fujita@gmail.com
Precedence: bulk

(2019/04/01 15:45), Amit Langote wrote:
> On 2019/04/01 15:01, Etsuro Fujita wrote:
>> +1 for adding such notes, but I'm not sure if it's a good idea to put it
>> there because I think that would make the introductory documentation a bit
>> verbose.  How about adding it to the reference pages of CREATE FOREIGN
>> TABLE and ALTER TABLE like the attached?
>
> Thanks for creating the patch.  Looks good to me.

Pushed after fixing a copy-pasto: s/sql-createtable/sql-createforeigntable/

Thanks for reviewing, Amit-san!

Best regards,
Etsuro Fujita