Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCREH-0000x6-14 for pgsql-bugs@arkaria.postgresql.org; Fri, 15 Jul 2022 19:44:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oCREE-0004CA-Rt for pgsql-bugs@arkaria.postgresql.org; Fri, 15 Jul 2022 19:43:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCREE-0004Bv-Ga for pgsql-bugs@lists.postgresql.org; Fri, 15 Jul 2022 19:43:58 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCREB-0007Fe-Sa for pgsql-bugs@postgresql.org; Fri, 15 Jul 2022 19:43:57 +0000 Received: by mail-pj1-x102c.google.com with SMTP id t5-20020a17090a6a0500b001ef965b262eso7058528pjj.5 for ; Fri, 15 Jul 2022 12:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version; bh=ZeOfeBbySaFjym5Sr36/C2qvMYywAqvvxarwoVTmpLg=; b=5vHa7YjH8L7pjkQSe+UwT9cF3qcqDP2Ql7u7fbX4MzbaRfQQICXGaq9BQrNTzBGzWV aHuzT9FXshqzBbS+T5yiHDIBOJyt+ASWSrnIk/b3QuB19byMLkeK9c8GNKWlGf6YqEsg b8/dpWT6gHWtV9hUORkKwt2UdXH1j565iAQIwNkqt0ugngKOj26UtoM+3Zs39YHIsO12 rki+24Sk/PtZJEDFI5+AVnHQreh6fIRe63bkIHPbXkreBT5sExv/W/M9zMqOYkNuKZy6 kb52ekNkYP2mpnmVpoy0DZwHtkNOhyDpKKQUMLka2HS4GKt1VyGg7dsJYkvPZoCDWMxO 9tNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=ZeOfeBbySaFjym5Sr36/C2qvMYywAqvvxarwoVTmpLg=; b=CjerdrByIHx6W4wMfsddEFD/FenP1ODuEoYcwgKniXydd26sl9TiNUgrkcLDGN2R+o B2kBf6b31H/OS/hyLJf5ae5nD82Glel4+9coYGjt7tWdVRbLEauO9faOS425u1uORjMu Eh3hYRwY6zRvlTJ5q4uoJkORwVYCCF19DVh1HFPX/SElB7i1lFbKhpUMutySK0Gh+bM5 fF6q/rA8SuIuFyhHDW1QdF96pQJZWe6Y0xudh0uPABTaWRn3XDEpNXNRMPVzuS6puagB kxtJeOJqxxOnE1frLSuAmKqbyR4K42ieiZpswQPj4l5DyeziHuvqKP1B2jrbNm0fxJiG cHwQ== X-Gm-Message-State: AJIora9sYl6GLf1/nkBUNqdqEffQiE1LRLl2/CTK5saH9hHOYBysTTcA zOSjzlSIh1H7qx1KQhKo/W3pUQ== X-Google-Smtp-Source: AGRyM1s9nJFeeWtv4USMaUMyF+K1DYUH4csbE//R4fMPBT0u5AKi/GXkOcIrBgHTO+IcVHREAYWNbA== X-Received: by 2002:a17:903:2406:b0:16a:fd0:a65e with SMTP id e6-20020a170903240600b0016a0fd0a65emr15487893plo.124.1657914234757; Fri, 15 Jul 2022 12:43:54 -0700 (PDT) Received: from jdavis.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id u18-20020a17090341d200b0016cb98ab5b4sm3210208ple.153.2022.07.15.12.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 12:43:54 -0700 (PDT) Message-ID: <5f35eb43799f99ec49d0280a8628e88c0932cad4.camel@j-davis.com> Subject: Re: [15] Custom WAL resource managers, single user mode, and recovery From: Jeff Davis To: Tom Lane Cc: pgsql-bugs@postgresql.org Date: Fri, 15 Jul 2022 12:43:52 -0700 In-Reply-To: <3192874.1657846137@sss.pgh.pa.us> References: <9decc18a42634f8a2f15c97a385a0f51a752f396.camel@j-davis.com> <3192874.1657846137@sss.pgh.pa.us> Content-Type: multipart/mixed; boundary="=-CncSJpC3nrP7wXQbIHeY" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-CncSJpC3nrP7wXQbIHeY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Thu, 2022-07-14 at 20:48 -0400, Tom Lane wrote: > I think that the patch might be missing some stuff. In postmaster.c, > there are several steps after process_shared_preload_libraries() > that look to be there to support loadable libraries, such as > process_shmem_requests(). Wouldn't it be reasonable to expect > that a loadable library would malfunction without those? New patch attached. This can also be a problem for custom table AMs, if the AM is expecting to be loaded in shared_preload_libraries. For instance, it would be reasonable for a module to have in _PG_init() something like: if (!process_shared_preload_libraries_in_progress) elog(ERROR, "module must be loaded in shared_preload_libraries"); to ensure hooks are properly configured at the right time. But if the module does something like that, and also implements a custom table AM, then it breaks single-user mode entirely because you can no longer do a database-wide VACUUM. I'm debating whether to backport this just to v15, where custom wal resource managers were introduced, or all the way back to v12, where custom table AMs were introduced. I'm inclined to just go to 15, because the issue with table AMs is more of a gotcha than a real bug. Regards, Jeff Davis --=-CncSJpC3nrP7wXQbIHeY Content-Disposition: attachment; filename*0=v2-0001-Process-shared_preload_libraries-in-single-user-mode.; filename*1=patch Content-Type: text/x-patch; name*0=v2-0001-Process-shared_preload_libraries-in-single-user-mode.patc; name*1=h; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA1ZTlhNTUyNmQ4YzZmYzFjZjhkMjdkYzgwMGU4OTI4NDA5NDBhMGJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZGF2aXNAcG9zdGdyZXNxbC5vcmc+CkRh dGU6IEZyaSwgMTUgSnVsIDIwMjIgMTI6MjQ6MTAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBQcm9j ZXNzIHNoYXJlZF9wcmVsb2FkX2xpYnJhcmllcyBpbiBzaW5nbGUtdXNlciBtb2RlLgoKV2l0aG91 dCBwcm9jZXNzaW5nIHNoYXJlZF9wcmVsb2FkX2xpYnJhcmllcywgaXQncyBpbXBvc3NpYmxlIHRv CnJlY292ZXIgaWYgY3VzdG9tIFdBTCByZXNvdXJjZSBtYW5hZ2VycyBhcmUgbmVlZGVkLiBJdCBt YXkgYWxzbyBwb3NlIGEKcHJvYmxlbSBydW5uaW5nIFZBQ1VVTSBvbiBhIHRhYmxlIHdpdGggYSBj dXN0b20gQU0sIGlmIHRoZSBtb2R1bGUKaW1wbGVtZW50aW5nIHRoZSBBTSBpcyBleHBlY3Rpbmcg dG8gYmUgbG9hZGVkIGJ5CnNoYXJlZF9wcmVsb2FkX2xpYnJhcmllcy4KClRoZSByZWFzb24gdGhp cyB3YXNuJ3QgZG9uZSBiZWZvcmUgd2FzIGp1c3QgdGhlIGdlbmVyYWwgcHJpbmNpcGxlIHRvCmRv IGZld2VyIHRoaW5ncyBpbiBzaW5nbGUtdXNlciBtb2RlLiBCdXQgaXQncyBlYXN5IGVub3VnaCB0 byBqdXN0IHNldApzaGFyZWRfcHJlbG9hZF9saWJyYXJpZXMgdG8gZW1wdHksIGZvciB0aGUgc2Ft ZSBlZmZlY3QuCgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tLzlkZWNjMThhNDI2MzRm OGEyZjE1Yzk3YTM4NWEwZjUxYTc1MmYzOTYuY2FtZWwlNDBqLWRhdmlzLmNvbQpSZXZpZXdlZC1i eTogVG9tIExhbmUsIEFuZHJlcyBGcmV1bmQKQmFja3BhdGNoLXRocm91Z2g6IDE1Ci0tLQogc3Jj L2JhY2tlbmQvdGNvcC9wb3N0Z3Jlcy5jIHwgMjMgKysrKysrKysrKysrKysrKysrKysrKysKIDEg ZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQv dGNvcC9wb3N0Z3Jlcy5jIGIvc3JjL2JhY2tlbmQvdGNvcC9wb3N0Z3Jlcy5jCmluZGV4IDZmMThi Njg4NTYuLjhiYTFjMTcwZjAgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3Rjb3AvcG9zdGdyZXMu YworKysgYi9zcmMvYmFja2VuZC90Y29wL3Bvc3RncmVzLmMKQEAgLTM5MzMsOSArMzkzMywzMiBA QCBQb3N0Z3Jlc1NpbmdsZVVzZXJNYWluKGludCBhcmdjLCBjaGFyICphcmd2W10sCiAJLyogcmVh ZCBjb250cm9sIGZpbGUgKGVycm9yIGNoZWNraW5nIGFuZCBjb250YWlucyBjb25maWcgKSAqLwog CUxvY2FsUHJvY2Vzc0NvbnRyb2xGaWxlKGZhbHNlKTsKIAorCS8qCisJICogcHJvY2VzcyBhbnkg bGlicmFyaWVzIHRoYXQgc2hvdWxkIGJlIHByZWxvYWRlZCBhdCBwb3N0bWFzdGVyIHN0YXJ0CisJ ICovCisJcHJvY2Vzc19zaGFyZWRfcHJlbG9hZF9saWJyYXJpZXMoKTsKKwogCS8qIEluaXRpYWxp emUgTWF4QmFja2VuZHMgKi8KIAlJbml0aWFsaXplTWF4QmFja2VuZHMoKTsKIAorCS8qCisJICog R2l2ZSBwcmVsb2FkZWQgbGlicmFyaWVzIGEgY2hhbmNlIHRvIHJlcXVlc3QgYWRkaXRpb25hbCBz aGFyZWQgbWVtb3J5LgorCSAqLworCXByb2Nlc3Nfc2htZW1fcmVxdWVzdHMoKTsKKworCS8qCisJ ICogTm93IHRoYXQgbG9hZGFibGUgbW9kdWxlcyBoYXZlIGhhZCB0aGVpciBjaGFuY2UgdG8gcmVx dWVzdCBhZGRpdGlvbmFsCisJICogc2hhcmVkIG1lbW9yeSwgZGV0ZXJtaW5lIHRoZSB2YWx1ZSBv ZiBhbnkgcnVudGltZS1jb21wdXRlZCBHVUNzIHRoYXQKKwkgKiBkZXBlbmQgb24gdGhlIGFtb3Vu dCBvZiBzaGFyZWQgbWVtb3J5IHJlcXVpcmVkLgorCSAqLworCUluaXRpYWxpemVTaG1lbUdVQ3Mo KTsKKworCS8qCisJICogTm93IHRoYXQgbW9kdWxlcyBoYXZlIGJlZW4gbG9hZGVkLCB3ZSBjYW4g cHJvY2VzcyBhbnkgY3VzdG9tIHJlc291cmNlCisJICogbWFuYWdlcnMgc3BlY2lmaWVkIGluIHRo ZSB3YWxfY29uc2lzdGVuY3lfY2hlY2tpbmcgR1VDLgorCSAqLworCUluaXRpYWxpemVXYWxDb25z aXN0ZW5jeUNoZWNraW5nKCk7CisKIAlDcmVhdGVTaGFyZWRNZW1vcnlBbmRTZW1hcGhvcmVzKCk7 CiAKIAkvKgotLSAKMi4yNS4xCgo= --=-CncSJpC3nrP7wXQbIHeY--