Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xIfis-00000003pGd-2nLq for pgsql-bugs@arkaria.postgresql.org; Mon, 19 Oct 2026 05:15:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xIfiq-00000005Nvr-2Vx7 for pgsql-bugs@arkaria.postgresql.org; Mon, 19 Oct 2026 05:15:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xIfiq-00000005Nvj-1IV7 for pgsql-bugs@lists.postgresql.org; Mon, 19 Oct 2026 05:15:44 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xIfin-00000002unw-0ZTr for pgsql-bugs@lists.postgresql.org; Mon, 19 Oct 2026 05:15:43 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-3a4b9732d5aso1548761a91.3 for ; Sun, 18 Oct 2026 22:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792386939; x=1792991739; darn=lists.postgresql.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:content-type:from:to:cc :subject:date:message-id:reply-to:content-type; bh=CAlWOCrWJF9oX+uGG+hPPxN/9A5vqGE86FETNHiL8VU=; b=NgAY9yrG+CdtOyk5sJiGuVyTOYTxAiZ20ZUch2vrQgNJsKl24QWZMfcVu8lkB/w4j4 oJJMJy/8WW28f2b+Toh188NQMgymhydr24eofuzvhNYuI97anL23SBfJG7UlKtw3j8TW TBsRWBMHeUX6esvTj5NC4jeO58qV9uDdilUXbvLz0pPLn+KEZcbLNm6FOhIJt5XUgwa0 BRjml0BG2VrGkE1ypDQTcJBBe6o8hCrswEYlykc2qcfnhpiJzQv9do+V4dPKK+bI3LO7 voZCqxGcp5XcckCB1fqB1Zvz9zVxdarCCE213BXDgk3Dp131cxFqojHFYqytNUiAjCNB tDvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792386939; x=1792991739; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CAlWOCrWJF9oX+uGG+hPPxN/9A5vqGE86FETNHiL8VU=; b=PfzYOOgJ3Q7MlaSXJNY9NuK/s6CBfevKGihfV+bu5DcKD49PGBjrKPQw1JiXvYWBnZ SJT6KS/WmVbQpvb7ysEE6GHhqovz9eggInMdyfJ13GMLzof8HGW92Ipwl1jTULZ3UFgv bP3EkILy2f3fC+/C6G9HEk3n9WcJIEE3DvVxh1HekqVWOepwjyM2WFELEEajo6bcqC3e afpYSD2/pfxSbgkRKagu2YImOQc2Wm1MMQG8OpcN8ohteW+2twQmLNq1mW5ZDedLOKVZ XJrRxktka4XCFX2SU1VlApfKpyoFVkm97pZzJTDSt7r9TyS1amlgci35KQzkPpeG7EjX 3I1Q== X-Forwarded-Encrypted: i=1; AKwUvBxRw0ayncWAdH834ujE3ox90K5tzKY09Dm4ip6lB1JlSHpCPe00W3bI7CabIHOZx8dIqh96Dyp6i4l6@lists.postgresql.org X-Gm-Message-State: AFq9FYJU8l6I70vtqs6NcmEPrrmDaiQtZozwTBCo+mKzA+7dKzZEiFHX by4NHvh7rDq/w8FZhjdTZH9GJu5JCViEe5dg//cl0H/Q5tiCMPR+8atV X-Gm-Gg: AYBFou2zK8RKI61b8tIye52VIoLhEretd+k83h0Cl0z9XIfLsZKCTXtZ1rjZG/7zEJP SPjX2mYknsmrNjYLaNAWYCzzMdN5PVqvNmOrbsEszlmRwHxqAbFMDhmovp4OUa+/l0ZXCfxEpQ0 pSAS+Z5E6ko6q9q4LYT5ydXt+p/vwKgygEzIo8h3WlaegDWzqGLBGHEem9uygjqIvDJFJJPnxiE 131kMt6kkvXZuSxrPYkggtVb94Vs/4T0dCrPBoA7UxP42Ury++t4TT6E1SFEt2Q6etNl/q800zH z1S5i5oaaccyq/HKTgjD4HMiflC2W/SUr/vquzvrTPkzpl4rnuctINgilO704ma+c3bZ82osxur N2EqXfz7nw3CnrMayafMh5STNd3RddH6IM5nVd/WTlIJmF1PxKLd8Bu8TqBlNX6b88LhryWrjiG GRpeAIZPPSP/QJ32+NfDP8LJDCfU5JsqWNpPFs+PCqhBsKjjVjcnZE06Gtx/1NzHaWHAU8i+6+V SeLwXVZSI/XJMYWKUZO88zGk53VUQuQcl37QniU04zB40eJHxVDSjBFFw== X-Received: by 2002:a17:90b:4cd0:b0:3ac:a203:e0a5 with SMTP id 98e67ed59e1d1-3acef104296mr5756473a91.11.1792386938796; Sun, 18 Oct 2026 22:15:38 -0700 (PDT) Received: from [192.168.1.19] (58-190-153-33f1.hyg1.eonet.ne.jp. [58.190.153.33]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac940055f5sm18925468a91.0.2026.10.18.22.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Oct 2026 22:15:38 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------iomM1G669N0N5Imlh8xrnkb0" Message-ID: <5fff280b-96c4-497f-bbfc-0af95b9844b3@gmail.com> Date: Mon, 19 Oct 2026 14:15:35 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction To: shihao zhong , Ayush Tiwari Cc: alpkeles99@gmail.com, pgsql-bugs@lists.postgresql.org References: <19760-8f9a0eba17bc8c92@postgresql.org> <41175da6-293f-4b8f-ad18-3636f3d8a2f6@gmail.com> Content-Language: en-US From: Takeshi Ideriha In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------iomM1G669N0N5Imlh8xrnkb0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Shihao, Ayush On 2026/10/19 12:31, shihao zhong wrote: > Hi, > > Here is a patch. rewrite_heap_dead_tuple() drops the held tuple when its > successor is dead, but that is only right if the successor's inserter > committed. If it aborted, the update never happened, so 0001 keeps the > tuple and adds its logical rewrite mapping. > Setting the hint in HeapTupleSatisfiesVacuum() is not enough. VACUUM > FULL on a catalog can see a transaction that is still open, and this > loses the pg_class row of a committed table: I was actually also writing a code to fix the issue and have just noticed the patch was already submitted. Attached a patch for reference. I haven't considered into logical_rewrite_heap_tuple(). I need to check this... Thank you. > { >+ /* >+ * If the inserter of this tuple aborted, the update >never happened >+ * and the earlier tuple is not dead. It will be >written at the end. >+ */ >+ if (!HeapTupleHeaderXminCommitted(old_tuple->t_data) && >+ !>TransactionIdDidCommit(HeapTupleHeaderGetXmin(old_tuple->t_data))) >+ return false; I am thinking like the below since HeapTupleSatisfiesVacuum set the xmin invalid hint bit for the dead tuple. So I believe we can just rely on HeapTupleHeaderXminInvalid hint bit. + if (HeapTupleHeaderXminInvalid(old_tuple->t_data)) + return false; What do you think above? >0002 is an isolation test for that case, it is optional. But I want it >in tree to prevent >future regression in that area. +1. I also think this is optional but I believe the issue is easy to oversight, so adding a new test would be helpful. Regards, Takeshi Ideriha --------------iomM1G669N0N5Imlh8xrnkb0 Content-Type: text/plain; charset=UTF-8; name="v1-0001-fix-cluster-misses-a-live-tuple-updated-by-subtra.patch" Content-Disposition: attachment; filename*0="v1-0001-fix-cluster-misses-a-live-tuple-updated-by-subtra.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0YTJiMDM0NDlmYTE0OGM5NDRlM2I2ODJjZWY2MjJiMmJmYTNhZWU1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUYWtlc2hpIElkZXJpaGEgPGlkZXJpaGF0YWtlc2hp QGdtYWlsLmNvbT4KRGF0ZTogTW9uLCAxOSBPY3QgMjAyNiAxMzo1ODo0MCArMDkwMApTdWJq ZWN0OiBbUEFUQ0ggdjJdIGZpeCBjbHVzdGVyIG1pc3NlcyBhIGxpdmUgdHVwbGUgdXBkYXRl ZCBieSBzdWJ0cmFzYW5jdGlvbgogd2hpY2ggd2lsbCBiZSBhYm9ydGVkCgotLS0KIHNyYy9i YWNrZW5kL2FjY2Vzcy9oZWFwL3Jld3JpdGVoZWFwLmMgfCAyMCArKysrKysrKysrKysrKysr KysrKwogMSBmaWxlIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9z cmMvYmFja2VuZC9hY2Nlc3MvaGVhcC9yZXdyaXRlaGVhcC5jIGIvc3JjL2JhY2tlbmQvYWNj ZXNzL2hlYXAvcmV3cml0ZWhlYXAuYwppbmRleCAwNjQ4ZTQzMzAzMS4uZGY5YzE3NjA2YTAg MTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2FjY2Vzcy9oZWFwL3Jld3JpdGVoZWFwLmMKKysr IGIvc3JjL2JhY2tlbmQvYWNjZXNzL2hlYXAvcmV3cml0ZWhlYXAuYwpAQCAtNTU0LDYgKzU1 NCwxNSBAQCByZXdyaXRlX2hlYXBfZGVhZF90dXBsZShSZXdyaXRlU3RhdGUgc3RhdGUsIEhl YXBUdXBsZSBvbGRfdHVwbGUpCiAJICogd2hlbiB4bWluIG9mIGEgdHVwbGUgaXMgZ3JlYXRl ciB0aGFuIHhtYXgsIHdoaWNoIHNvdW5kcwogCSAqIGNvdW50ZXItaW50dWl0aXZlIGJ1dCBp cyBwZXJmZWN0bHkgdmFsaWQuCiAJICoKKwkgKiBUaGVyZSBpcyBvbmUgZXhjZXB0aW9uLiBT dXBwb3NlIGEgdHVwbGUgaXMgY3JlYXRlZCBieSBhIHRyYW5zYWN0aW9uLCBhbmQKKwkgKiB0 aGVuIHVwZGF0ZWQgaW4gYSBzdWJ0cmFuc2FjdGlvbiwgYW5kIHRoYXQgc3VidHJhbnNhY3Rp b24gaXMgYWJvcnRlZC4KKwkgKiBUaGUgZXhwbGFuYXRpb24gaW4gdGhlIHBhcmFncmFwaCBh Ym92ZSBhc3N1bWVzIHRoYXQgdGhlIGRlYWQgdHVwbGUgd2FzCisJICogb25jZSBjb21taXR0 ZWQuIEluIHRoaXMgY2FzZSwgdGhlIGRlYWQgdHVwbGUgd2FzIG5ldmVyIGNvbW1pdHRlZCwg c28gdGhlCisJICogZWFybGllciB0dXBsZSBpcyBub3QgbmVzZXNzYXJpbHkgZGVhZC4gQWxz bywgaW4gdGhpcyBjYXNlLCB0aGUgZWFybGllciAKKwkgKiB0dXBsZSBpcyBwdXQgaW4gdGhl IHVucmVzb2x2ZWQgdGFibGUgYmVjYXVzZSBubyBoaW50IGJpdCBpcyBhc3NpZ25lZCB0byAK KwkgKiB0aGlzIHR1cGxlIGFuZCBIZWFwVHVwbGVTYXRpc2ZpZXNWYWN1dW0ganVkZ2VzIGl0 IGFzIElOU0VSVF9JTl9QUk9HUkVTUy4KKwkgKiBBcyBhIHJlc3VsdCwgYSB0dXBsZSB0aGF0 IGlzIGFjdHVhbGx5IGxpdmUgd291bGQgbm90IGJlIGNvcGllZC4KKwkgKgogCSAqIFdlIGRv bid0IGJvdGhlciB0byB0cnkgdG8gZGV0ZWN0IHRoZSBzaXR1YXRpb24gdGhlIG90aGVyIHdh eSByb3VuZCwKIAkgKiB3aGVuIHdlIGVuY291bnRlciB0aGUgZGVhZCB0dXBsZSBmaXJzdCBh bmQgdGhlbiB0aGUgcmVjZW50bHkgZGVhZCBvbmUKIAkgKiB0aGF0IHBvaW50cyB0byBpdC4g SWYgdGhhdCBoYXBwZW5zLCB3ZSdsbCBoYXZlIHNvbWUgdW5tYXRjaGVkIGVudHJpZXMKQEAg LTU3NCw2ICs1ODMsMTcgQEAgcmV3cml0ZV9oZWFwX2RlYWRfdHVwbGUoUmV3cml0ZVN0YXRl IHN0YXRlLCBIZWFwVHVwbGUgb2xkX3R1cGxlKQogCiAJaWYgKHVucmVzb2x2ZWQgIT0gTlVM TCkKIAl7CisJCS8qCisJCSAqIEluIHRoaXMgY2FzZSwgdGhlIGVhcmxpZXIgdHVwbGUgaXMg bm90IG5lY2Vzc2FyaWx5IGRlYWQuIFdlIHNob3VsZAorCQkgKiBjb3B5IHRoaXMgdHVwbGUg dG8gYSBuZXcgdGFibGUuIEl0J3MgZmluZSB0byBsZWF2ZSB0aGlzIHR1cGxlIGluCisJCSAq IHVucmVzb2x2ZWQgdGFibGUgc2luY2UgZW5kX2hlYXBfcmV3cml0ZSB3aWxsIGNvcHkgdGhl IHR1cGxlcyByZW1haW5lZAorCQkgKiBpbiB0aGUgdGFibGUgd2l0aCBpbnZhbGlkIGN0aWQu CisJCSAqCisJCSAqIFdlIGNhbiByZWx5IG9uIGhpbnQgYml0IHNpbmNlIEhlYXBUdXBsZVNh dGlzZmllc1ZhY3V1bSBzZXQgdGhlIGhpbnQgCisJCSAqIGJpdCBmb3IgdGhlIGRlYWQgdHVw bGUuCisJCSAqLworCQlpZiAoSGVhcFR1cGxlSGVhZGVyWG1pbkludmFsaWQob2xkX3R1cGxl LT50X2RhdGEpKQorCQkJcmV0dXJuIGZhbHNlOwogCQkvKiBOZWVkIHRvIGZyZWUgdGhlIGNv bnRhaW5lZCB0dXBsZSBhcyB3ZWxsIGFzIHRoZSBoYXNodGFibGUgZW50cnkgKi8KIAkJaGVh cF9mcmVldHVwbGUodW5yZXNvbHZlZC0+dHVwbGUpOwogCQloYXNoX3NlYXJjaChzdGF0ZS0+ cnNfdW5yZXNvbHZlZF90dXBzLCAmaGFzaGtleSwKLS0gCjIuNTAuMSAoQXBwbGUgR2l0LTE1 NSkKCg== --------------iomM1G669N0N5Imlh8xrnkb0--