Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjYwp-0001WD-0S for pgsql-bugs@arkaria.postgresql.org; Fri, 12 Jun 2020 01:57:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jjYwn-0000eF-RJ for pgsql-bugs@arkaria.postgresql.org; Fri, 12 Jun 2020 01:57:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjYwn-0000e8-LG for pgsql-bugs@lists.postgresql.org; Fri, 12 Jun 2020 01:57:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjYwl-00028R-Gh for pgsql-bugs@lists.postgresql.org; Fri, 12 Jun 2020 01:57:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 05C1vP1K608106; Thu, 11 Jun 2020 21:57:25 -0400 From: Tom Lane To: Kyotaro Horiguchi cc: jeff.janes@gmail.com, frank.gagnepain@intm.fr, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16476: pgp_sym_encrypt_bytea with compress-level=6 : Wrong key or corrupt data In-reply-to: <20200612.105131.63288858615945654.horikyota.ntt@gmail.com> References: <20200611.205831.1200962108435398529.horikyota.ntt@gmail.com> <20200612.105131.63288858615945654.horikyota.ntt@gmail.com> Comments: In-reply-to Kyotaro Horiguchi message dated "Fri, 12 Jun 2020 10:51:31 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <608104.1591927045.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Thu, 11 Jun 2020 21:57:25 -0400 Message-ID: <608105.1591927045@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Kyotaro Horiguchi writes: >> I put an assertion in the patch, but that is not appropriare. It shoud be >> an ereport instead. I¢ll fix that later. > Fixed. Hm, should we add a test case exercising this code? regards, tom lane