Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tVgWc-00AZqN-9Y for pgsql-bugs@arkaria.postgresql.org; Thu, 09 Jan 2025 00:35:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tVgWa-009F9v-N3 for pgsql-bugs@arkaria.postgresql.org; Thu, 09 Jan 2025 00:35:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tVgWa-009F9m-EQ for pgsql-bugs@lists.postgresql.org; Thu, 09 Jan 2025 00:35:48 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tVgWW-000bzY-2a for pgsql-bugs@lists.postgresql.org; Thu, 09 Jan 2025 00:35:47 +0000 Received: from [192.168.11.6] (p4062048-ipxg13601funabasi.chiba.ocn.ne.jp [153.216.203.48]) by oss.nttdata.com (Postfix) with ESMTPSA id A82E461271; Thu, 9 Jan 2025 09:35:40 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Content-Type: multipart/mixed; boundary="------------5nM3jMNatz0P6LZCciGon8Yj" Message-ID: <614200e4-9434-4aad-b44d-078bc6d5e65a@oss.nttdata.com> Date: Thu, 9 Jan 2025 09:35:39 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG #18663: synchronous_standby_names vs synchronous_commit vs pg_stat_replication From: Fujii Masao To: asphator@gmail.com, pgsql-bugs@lists.postgresql.org References: <18663-b02f75cb919f1b60@postgresql.org> Content-Language: en-US In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------5nM3jMNatz0P6LZCciGon8Yj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024/10/21 18:43, Fujii Masao wrote: > > > On 2024/10/18 23:48, PG Bug reporting form wrote: >> The following bug has been logged on the website: >> >> Bug reference:      18663 >> Logged by:          Asphator >> Email address:      asphator@gmail.com >> PostgreSQL version: 15.7 >> Operating system:   RHEL7+ >> Description: >> >> Hello >> >> I would like to raise 2 issues: >> - documentation issue >> - pg_stat_replication view issue in a very specific use case >> >> 1. Documentation >> Regarding parameter synchronous_standby_names, I did not manage to find >> anything in documentation preventing from setting value 0. The only thing >> I've found is a comment in a commit of 2016. Would be nice to mention in >> documentation that value must be a "positive" integer. > > Agreed. I've attached the patch. I made a slight wording adjustment. Unless there are objections, I'll commit the attached patch. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------5nM3jMNatz0P6LZCciGon8Yj Content-Type: text/plain; charset=UTF-8; name="v2-0001-doc-Clarify-synchronous_standby_names-parameter.patch" Content-Disposition: attachment; filename*0="v2-0001-doc-Clarify-synchronous_standby_names-parameter.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSA0YmI2OWI1NWUwNjBkYzQxMjRiYTU1ZGNkN2RjYTE2NGNjNzZjMDlkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v cmc+CkRhdGU6IFRodSwgOSBKYW4gMjAyNSAwOToyNjozNiArMDkwMApTdWJqZWN0OiBbUEFU Q0ggdjJdIGRvYzogQ2xhcmlmeSBzeW5jaHJvbm91c19zdGFuZGJ5X25hbWVzIHBhcmFtZXRl ci4KClRoZSBzeW5jaHJvbm91c19zdGFuZGJ5X25hbWVzIEdVQyBhbGxvd3Mgc3BlY2lmeWlu ZyBudW1fc3luYywKdGhlIG51bWJlciBvZiBzeW5jaHJvbm91cyBzdGFuZGJ5cyB0cmFuc2Fj dGlvbnMgbXVzdCB3YWl0IGZvcgpyZXBsaWVzIGZyb20uIFRoaXMgdmFsdWUgbXVzdCBiZSBh biBpbnRlZ2VyIGdyZWF0ZXIgdGhhbiB6ZXJvLgpUaGlzIGNvbW1pdCB1cGRhdGVzIHRoZSBk b2N1bWVudGF0aW9uIHRvIGNsYXJpZnkgdGhpcyByZXF1aXJlbWVudC4KClJlcG9ydGVkLWJ5 OiBBc3BoYXRvciA8YXNwaGF0b3JAZ21haWwuY29tPgpEaXNjdXNzaW9uOiBodHRwczovL3Bv c3Rnci5lcy9tLzE4NjYzLWIwMmY3NWNiOTE5ZjFiNjBAcG9zdGdyZXNxbC5vcmcKLS0tCiBk b2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21sIGIvZG9j L3NyYy9zZ21sL2NvbmZpZy5zZ21sCmluZGV4IDg2ODNmMGJkZjUuLmYxYWI2MTQ1NzUgMTAw NjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9jb25maWcuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwv Y29uZmlnLnNnbWwKQEAgLTQ3MTUsNiArNDcxNSw4IEBAIEFOWSA8cmVwbGFjZWFibGUgY2xh c3M9InBhcmFtZXRlciI+bnVtX3N5bmM8L3JlcGxhY2VhYmxlPiAoIDxyZXBsYWNlYWJsZSBj bGFzcz0iCiAgICAgICAgIHdhaXQgZm9yIHJlcGxpZXMgZnJvbSwKICAgICAgICAgYW5kIDxy ZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5zdGFuZGJ5X25hbWU8L3JlcGxhY2VhYmxl PgogICAgICAgICBpcyB0aGUgbmFtZSBvZiBhIHN0YW5kYnkgc2VydmVyLgorICAgICAgICA8 cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+bnVtX3N5bmM8L3JlcGxhY2VhYmxlPgor ICAgICAgICBtdXN0IGJlIGFuIGludGVnZXIgdmFsdWUgZ3JlYXRlciB0aGFuIHplcm8uCiAg ICAgICAgIDxsaXRlcmFsPkZJUlNUPC9saXRlcmFsPiBhbmQgPGxpdGVyYWw+QU5ZPC9saXRl cmFsPiBzcGVjaWZ5IHRoZSBtZXRob2QgdG8gY2hvb3NlCiAgICAgICAgIHN5bmNocm9ub3Vz IHN0YW5kYnlzIGZyb20gdGhlIGxpc3RlZCBzZXJ2ZXJzLgogICAgICAgIDwvcGFyYT4KLS0g CjIuNDcuMAoK --------------5nM3jMNatz0P6LZCciGon8Yj--