Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebuop-0000iQ-RM for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Jan 2018 21:00:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebuoo-00065N-M0 for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Jan 2018 21:00:22 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ebuoo-000657-CU for pgsql-hackers@lists.postgresql.org; Wed, 17 Jan 2018 21:00:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ebuol-0007yR-KL for pgsql-hackers@lists.postgresql.org; Wed, 17 Jan 2018 21:00:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w0HL0GDd006359; Wed, 17 Jan 2018 16:00:16 -0500 From: Tom Lane To: Peter Geoghegan cc: Aleksandr Parfenov , PostgreSQL Hackers Subject: Re: PostgreSQL crashes with SIGSEGV In-reply-to: References: <1512661638.9720.34.camel@oopsware.de> <151608914608.25640.2144132915573008595.pgcf@coridan.postgresql.org> <14267.1516216998@sss.pgh.pa.us> <4977.1516221082@sss.pgh.pa.us> Comments: In-reply-to Peter Geoghegan message dated "Wed, 17 Jan 2018 12:41:13 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6357.1516222816.1@sss.pgh.pa.us> Date: Wed, 17 Jan 2018 16:00:16 -0500 Message-ID: <6358.1516222816@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Geoghegan writes: > On Wed, Jan 17, 2018 at 12:31 PM, Tom Lane wrote: >> +1. If the problem isn't known to be reproducible in those branches, >> the risk of adding new bugs seems to outweigh any benefit. > You could make the same objection to changing tuplesort_getdatum() > outside of the master branch, though. I think that going back further > than that for the (arguably independent) tuplesort_getdatum() subset > fix might still be a good idea. I wonder where you stand on this. I haven't been following the thread very closely, so I don't have an opinion on that. regards, tom lane