Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLkjc-00992I-1B for pgsql-bugs@arkaria.postgresql.org; Wed, 19 Nov 2025 16:08:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vLkja-00DoFe-3B for pgsql-bugs@arkaria.postgresql.org; Wed, 19 Nov 2025 16:08:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLkjL-00Dm6q-1G for pgsql-bugs@lists.postgresql.org; Wed, 19 Nov 2025 16:08:27 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLkjJ-000O3s-2t for pgsql-bugs@lists.postgresql.org; Wed, 19 Nov 2025 16:08:27 +0000 Received: from [10.0.2.15] (unknown [130.41.208.2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4dBRGv60RJz49Q3q; Wed, 19 Nov 2025 18:08:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1763568504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JPbmz54LOVDVh2teuLr12J2iwRsaXJvxNM3cSMWn9J4=; b=KdUgW9YIQHfIPGcNqmlCPedaf83p/vtxeeg1RjatOkbCvsM4jKsjmHXgD2AZVFs3Cpslcq C9+5Pvw5Vewse0sgOl3UAUwWQQCQqAKb2KLgXJ7cVPQhp6FoKfAYVyabqz7dn0mepEqQqa ORP6hUMGqRPSPop6SkTlvBsbPx4YzKUEpz8a5TV/n3jKQXMzdJairjFXozhitRWOowlGXW MJmI0VE/sDzeZpW1oUcLK5Aa47JNIy8wSV+MjFJwL/q55PfwgEmfb9eEfdtTVKKYdTWdiJ cYVoCVFSz8X7+DSz6SI3CwUozyvZNqAOAt1vQqBpetkqXa9cZJK5UrVS+kgaVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1763568504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JPbmz54LOVDVh2teuLr12J2iwRsaXJvxNM3cSMWn9J4=; b=cggTrRnWzQ5WLZNHZDceQrsoTODuAxMOdypf2z0QoYIxGZVpj6hADyYI8fs2Cz70P4W+7l 0GmdSiqPZYPw9nqkoV2LzqUa8rnSeOsT85f3YfBVROZ32lQ/g13tFG3C300EyfJ6bzCNTF 74urNZZIfpxeukUeElUZmZo/gAoTXDSvcwpKfnSBVmlc2NbbNPUNL5rchzcicnf99UJDd2 LzYWoCOxtXbSMgGjRPhXUTome+CvbPvO2xAxJobURWaxQ9Z7ltjJjz7cnHZdOhaXyLpNrJ R5h8cqYw0y/VtRQyFSPqRZ1/hiFa6FM6OmVmMG4BJbaTy7enXSmZaWRdnaeNmA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Seal: i=1; a=rsa-sha256; d=iki.fi; s=lahtoruutu; cv=none; t=1763568504; b=rSu6EUrLxWxaP+lYkhGi9vRVzKkVbfyjcdst11XhgjTX0ZumeUb6m9C+d/a5CkjKHCC/6S 2C9TyXPZMq7TJO7iSo33RFVQp8byXbJ5EM1T1ugJBwqdyx3eVBRw5a78M7wtHo2gTFPflL /54Rikf8aXmNPB6/Yotr3lEaE4/bYI/JTcoitEqIZY1mHSsgyYcuJwWTH2x+6q2ITEBdRx Q0AI7jM5GBr87PXcPH+7xgNHO6eIvllVyTybN9+M+mrYhEPV6ac04NYv77CqyMxH9JQtJD AMk6X8OuWk2vU600BWEjfFgOd/EL7a/GjSjuVHkYGKSMlBjdHLdvoau6mV+bOg== Message-ID: <638e63ba-b8a3-4236-9c48-0d4a5ef2f034@iki.fi> Date: Wed, 19 Nov 2025 18:08:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pg_resetwal prints new OldestXID in wrong circumstances To: Bertrand Drouvot Cc: "pgsql-bugs@lists.postgresql.org" References: <5461bc85-e684-4531-b4d2-d2e57ad18cba@iki.fi> Content-Language: en-US From: Heikki Linnakangas In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 19/11/2025 12:05, Bertrand Drouvot wrote: > On Wed, Nov 19, 2025 at 11:52:31AM +0200, Heikki Linnakangas wrote: >> Printing the new OldestXID value is incorrectly tied to whether the >> --next-transaction-id option is given, so this prints it, even though >> OldestXID is not being modified: > > Nice catch! > >> This seems to have been an oversight when the --oldest-transaction-id option >> was added (commit 74cf7d46a91d). > > yeah. > >> Before that, OldestXID was reset when the >> --next-transaction-id option was given. >> >> Fix attached. Barring objections, I will commit and backpatch this. > > LGTM, thanks! Committed, thanks! - Heikki