From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: constzl <const_sunny@126.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: Is Backgroundworker.bgw_restart_time is defined in seconds?
In-reply-to: <5FD75B47-1F5F-470F-B349-0B54614A49A2@yesql.se>
References: <4baeccb.80f0.17b81651c54.Coremail.const_sunny@126.com>
 <5FD75B47-1F5F-470F-B349-0B54614A49A2@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Thu, 26 Aug 2021 10:09:36 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <648774.1629986832.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 26 Aug 2021 10:07:12 -0400
Message-ID: <648775.1629986832@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/648775.1629986832%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 26 Aug 2021, at 09:38, constzl <const_sunny@126.com> wrote:
>> if ((worker->bgw_restart_time < 0 &&
>>      worker->bgw_restart_time !=3D BGW_NEVER_RESTART) ||
>>     (worker->bgw_restart_time > USECS_PER_DAY / 1000))

> My reading of the above code is that is tries to catch nonsensical value=
s, not
> to cap it to enforce restarts within a 24h period.

This may be intended to guard against integer overflows later (he guesses
without having read the code).

			regards, tom lane