Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gDMVD-0007cT-B0 for pgsql-bugs@arkaria.postgresql.org; Fri, 19 Oct 2018 04:35:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gDMVA-0000yY-Ok for pgsql-bugs@arkaria.postgresql.org; Fri, 19 Oct 2018 04:35:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gDMVA-0000yR-Ic for pgsql-bugs@lists.postgresql.org; Fri, 19 Oct 2018 04:35:08 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gDMV7-0003e5-Uv for pgsql-bugs@lists.postgresql.org; Fri, 19 Oct 2018 04:35:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w9J4Z1uq006567; Fri, 19 Oct 2018 00:35:01 -0400 From: Tom Lane To: karlcz@isi.edu cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15440: pg_dump does not preserve quoted identifiers for statement-level trigger transition table names In-reply-to: <15440-02d1468e94d63d76@postgresql.org> References: <15440-02d1468e94d63d76@postgresql.org> Comments: In-reply-to =?utf-8?q?PG_Bug_reporting_form?= message dated "Fri, 19 Oct 2018 03:16:52 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6565.1539923701.1@sss.pgh.pa.us> Date: Fri, 19 Oct 2018 00:35:01 -0400 Message-ID: <6566.1539923701@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk =?utf-8?q?PG_Bug_reporting_form?= writes: > If I create a statement-level trigger using quoted identifiers with the new > transition table feature in pg10 and dump the database with pg_dump, the > dumped CREATE TRIGGER statements lack quotes on the identifier. Yup, missing quote_identifier calls in pg_get_triggerdef_worker. Will fix, thanks for the report! regards, tom lane