Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1q83YZ-0002ha-Vg
	for pgsql-bugs@arkaria.postgresql.org; Sat, 10 Jun 2023 18:43:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1q83YY-0005SZ-2D
	for pgsql-bugs@arkaria.postgresql.org; Sat, 10 Jun 2023 18:43:22 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1q83YX-0005F2-G3
	for pgsql-bugs@lists.postgresql.org; Sat, 10 Jun 2023 18:43:21 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1q83YQ-001L2M-LV
	for pgsql-bugs@lists.postgresql.org; Sat, 10 Jun 2023 18:43:20 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 35AIgsJI665280;
	Sat, 10 Jun 2023 14:42:54 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
cc: Tristan Partin <tristan@neon.tech>, Heikki Linnakangas <hlinnaka@iki.fi>,
        gdo@leader.it, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
In-reply-to: <f1856a5d-3703-66ff-e7c7-01d2489315c1@joeconway.com>
References: <17946-3e84cb577e9551c3@postgresql.org>
 <1564676.1685043220@sss.pgh.pa.us>
 <555bb26e-c27c-ab65-028f-3fd5b82df9de@iki.fi>
 <CT887GSPI31W.BQCSW35JL67L@gonk>
 <ca35e375-be82-322d-8c81-78127d8fb33f@joeconway.com>
 <5676b739-0854-f924-4b97-466e3504c692@joeconway.com>
 <f1856a5d-3703-66ff-e7c7-01d2489315c1@joeconway.com>
Comments: In-reply-to Joe Conway <mail@joeconway.com>
	message dated "Sat, 10 Jun 2023 12:12:36 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <665278.1686422573.1@sss.pgh.pa.us>
Date: Sat, 10 Jun 2023 14:42:54 -0400
Message-ID: <665279.1686422574@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/665279.1686422574%40sss.pgh.pa.us>
Precedence: bulk

Joe Conway <mail@joeconway.com> writes:
> 5/ The attached fixes the issue for me on pg10 and passes check-world.
> Comments?

The call in PGLC_localeconv seems *very* oddly placed.  Why not
do that before it does any other locale calls?  Otherwise you don't
really have reason to believe you're saving the appropriate
values to restore later.

			regards, tom lane