From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: bernddorn@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17227: segmentation fault with jsonb_to_recordset
In-reply-to: <675396.1634157283@sss.pgh.pa.us>
References: <202110131359.a6m35hpudkg7@alvherre.pgsql>
 <649678.1634135335@sss.pgh.pa.us> <675396.1634157283@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 13 Oct 2021 16:34:43 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <676463.1634158492.1@sss.pgh.pa.us>
Date: Wed, 13 Oct 2021 16:54:52 -0400
Message-ID: <676464.1634158492@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/676464.1634158492%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> This works OK in v12, so somebody broke it between v12 and v13.

Looks like the somebody was me.  git bisect pins the blame on

commit 7266d0997dd2a0632da38a594c78e25ff21df67e
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   Thu Aug 1 18:50:22 2019 -0400

    Allow functions-in-FROM to be pulled up if they reduce to constants.

A relevant-looking part of the commit message is

    To do this, we need to rearrange when eval_const_expressions()
    happens for expressions in function RTEs.  I moved it to
    inline_set_returning_functions(), which already has to iterate over
    every function RTE, and in consequence renamed that function to
    preprocess_function_rtes().

Apparently this idea failed to account for subexpressions pulled up
during later processing.  Back to the drawing board.

			regards, tom lane