Message-ID: <68138521-5345-8780-4390-1474afdcba1f@gmail.com>
Date: Sun, 10 Dec 2023 07:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: BUG #18224: message bug in libpqwalreceiver.c.
Content-Language: en-US
To: Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: king tomo <t.katsumata1122@gmail.com>, pgsql-bugs@lists.postgresql.org
References: <18224-59c34f71e2c6a5ed@postgresql.org>
 <CAC55fYeoBvYSyRupWEP+BzGwhdi7R7nvPffM7QhQyqDcpedxig@mail.gmail.com>
 <C35E2C78-AA74-4115-8A25-A3D425349604@yesql.se>
 <750771.1701698849@sss.pgh.pa.us>
 <A44077E7-8D36-470A-A1AC-C560DEA26E6E@yesql.se>
 <751760.1701699492@sss.pgh.pa.us>
 <9C3157E9-C42D-40E3-9A11-64E4F890CD4E@yesql.se>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <9C3157E9-C42D-40E3-9A11-64E4F890CD4E@yesql.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/68138521-5345-8780-4390-1474afdcba1f%40gmail.com>
Precedence: bulk

Hello Daniel,

05.12.2023 16:44, Daniel Gustafsson wrote:
> Following the bouncing ball it turns out that restricting to 9.4+ (effectively
> reapplying 083d29c65b78 adapted to the callsites moved to a common function)
> across the board isn't doable since pg_basebackup requires IDENTIFY_SYSTEM for
> 9.1->9.3 to get the starttli.  Thus I opted for just fixing the error message
> and left the restriction on 9.4+ as future work for when it can be done across
> all callers.

Isn't IDENTIFY_SERVER a mistake in the comment added?:

+     * IDENTIFY_SERVER returns 3 columns in 9.3 and earlier, and 4 columns in
+     * 9.4 and onwards.

Best regards,
Alexander