Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXOhy-0004KZ-7N for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Jun 2018 10:26:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fXOhu-0000zz-Tu for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Jun 2018 10:26:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXOhu-0000zs-Kp for pgsql-bugs@lists.postgresql.org; Mon, 25 Jun 2018 10:26:50 +0000 Received: from forward4p.cmail.yandex.net ([2a02:6b8:0:1465::14]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXOhn-0007jU-2A for pgsql-bugs@lists.postgresql.org; Mon, 25 Jun 2018 10:26:49 +0000 Received: from mxback15j.mail.yandex.net (mxback15j.mail.yandex.net [IPv6:2a02:6b8:0:1619::91]) by forward4p.cmail.yandex.net (Yandex) with ESMTP id A680720CF1; Mon, 25 Jun 2018 13:26:39 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback15j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id eEVMtoFKup-Qclaer5B; Mon, 25 Jun 2018 13:26:38 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zsrv.org; s=mail; t=1529922398; bh=l92mLU4YxGL/Sx8W1T3gABvY3o5ySoy/VXRseD7OJjI=; h=From:To:In-Reply-To:References:Subject:Date:Message-Id; b=EseICj05/mlnXlIvGt05dzKkt9UnzAQmyzyPIAwunRIRjmxx1iIN9FVtP4lOZ196p zqDE+Xp0WRKH0CCfJSyzPKQrD/m6PH4mou8gA5ljEq46BklG/jcj51EEClRwJOsoks uosItHu7bASRyLKumPVaCscn+QVIMGggFw8CtShw= Authentication-Results: mxback15j.mail.yandex.net; dkim=pass header.i=@zsrv.org Received: by web45j.yandex.ru with HTTP; Mon, 25 Jun 2018 13:26:38 +0300 From: Sergei Kornilov To: "lizenko79@gmail.com" , "pgsql-bugs@lists.postgresql.org" In-Reply-To: <152992021588.1268.16786093506650391435@wrigleys.postgresql.org> References: <152992021588.1268.16786093506650391435@wrigleys.postgresql.org> Subject: Re: BUG #15252: "do not dump comments" in pg_restore help MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Mon, 25 Jun 2018 13:26:38 +0300 Message-Id: <6993521529922398@web45j.yandex.ru> Content-Type: multipart/mixed; boundary="----==--bound.699353.web45j.yandex.ru" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk ------==--bound.699353.web45j.yandex.ru Content-Transfer-Encoding: 7bit Content-Type: text/plain Hello Thank you! I recheck behavior too, option works correct and has only wrong description. Simple patch attached. regards, Sergei ------==--bound.699353.web45j.yandex.ru Content-Disposition: attachment; filename="bug15252_pg_restore_no_comments_description.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name="bug15252_pg_restore_no_comments_description.patch" ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdfcmVzdG9yZS5zZ21sIGIvZG9jL3NyYy9z Z21sL3JlZi9wZ19yZXN0b3JlLnNnbWwKaW5kZXggMzQ1MzI0Yi4uMTRhYzIyYiAxMDA2NDQKLS0t IGEvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZXN0b3JlLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3Jl Zi9wZ19yZXN0b3JlLnNnbWwKQEAgLTU3OSw3ICs1NzksNyBAQAogICAgICAgPHRlcm0+PG9wdGlv bj4tLW5vLWNvbW1lbnRzPC9vcHRpb24+PC90ZXJtPgogICAgICAgPGxpc3RpdGVtPgogICAgICAg IDxwYXJhPgotICAgICAgICBEbyBub3QgZHVtcCBjb21tZW50cy4KKyAgICAgICAgRG8gbm90IHJl c3RvcmUgY29tbWVudHMuCiAgICAgICAgPC9wYXJhPgogICAgICAgPC9saXN0aXRlbT4KICAgICAg PC92YXJsaXN0ZW50cnk+CmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5j IGIvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYwppbmRleCAyMzQyYTYzLi41MDFkN2NlIDEw MDY0NAotLS0gYS9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jCisrKyBiL3NyYy9iaW4vcGdf ZHVtcC9wZ19yZXN0b3JlLmMKQEAgLTQ4Myw3ICs0ODMsNyBAQCB1c2FnZShjb25zdCBjaGFyICpw cm9nbmFtZSkKIAlwcmludGYoXygiICAtLWRpc2FibGUtdHJpZ2dlcnMgICAgICAgICAgIGRpc2Fi bGUgdHJpZ2dlcnMgZHVyaW5nIGRhdGEtb25seSByZXN0b3JlXG4iKSk7CiAJcHJpbnRmKF8oIiAg LS1lbmFibGUtcm93LXNlY3VyaXR5ICAgICAgICBlbmFibGUgcm93IHNlY3VyaXR5XG4iKSk7CiAJ cHJpbnRmKF8oIiAgLS1pZi1leGlzdHMgICAgICAgICAgICAgICAgICB1c2UgSUYgRVhJU1RTIHdo ZW4gZHJvcHBpbmcgb2JqZWN0c1xuIikpOwotCXByaW50ZihfKCIgIC0tbm8tY29tbWVudHMgICAg ICAgICAgICAgICAgZG8gbm90IGR1bXAgY29tbWVudHNcbiIpKTsKKwlwcmludGYoXygiICAtLW5v LWNvbW1lbnRzICAgICAgICAgICAgICAgIGRvIG5vdCByZXN0b3JlIGNvbW1lbnRzXG4iKSk7CiAJ cHJpbnRmKF8oIiAgLS1uby1kYXRhLWZvci1mYWlsZWQtdGFibGVzICBkbyBub3QgcmVzdG9yZSBk YXRhIG9mIHRhYmxlcyB0aGF0IGNvdWxkIG5vdCBiZVxuIgogCQkJICIgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY3JlYXRlZFxuIikpOwogCXByaW50ZihfKCIgIC0tbm8tcHVibGljYXRp b25zICAgICAgICAgICAgZG8gbm90IHJlc3RvcmUgcHVibGljYXRpb25zXG4iKSk7Cg== ------==--bound.699353.web45j.yandex.ru--