Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes
 required quotes
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
References: <16059-8836946734c02b84@postgresql.org>
 <30313.1572729260@sss.pgh.pa.us> <1628.1572820800@sss.pgh.pa.us>
Cc: steven.winfield@cantabcapital.com
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <6ccd23e4-ce58-c2b5-39a1-801a9937ae86@2ndquadrant.com>
Date: Fri, 3 Jan 2020 08:54:35 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1628.1572820800@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-11-03 23:40, Tom Lane wrote:
> * The patch now always quotes completed filenames, so quote_if_needed()
> is misnamed and overcomplicated for this use-case.  I left the extra
> generality in place for possible future use.  On the other hand, this
> is the*only*  use-case, so you could also argue that we should just
> simplify the function's API.  I have no strong opinion about that.

I haven't found an explanation in this thread why it does always quote 
now.  That seems a bit unusual.  Is there a reason for this?  Can we do 
without it?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services