Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNKDQ-0001tq-NR for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Sep 2020 18:19:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kNKDP-0006KK-LA for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Sep 2020 18:19:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNKDP-0006KD-EQ for pgsql-hackers@lists.postgresql.org; Tue, 29 Sep 2020 18:19:03 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNKDN-0001aa-5T for pgsql-hackers@lists.postgresql.org; Tue, 29 Sep 2020 18:19:02 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 08TIIwBZ712971; Tue, 29 Sep 2020 14:18:58 -0400 From: Tom Lane To: Bruce Momjian cc: "David G. Johnston" , Laurenz Albe , PostgreSQL Hackers Subject: Re: BUG #16419: wrong parsing BC year in to_date() function In-reply-to: <663099.1601400389@sss.pgh.pa.us> References: <16419-d8d9db0a7553f01b@postgresql.org> <0123b852ae3fe53eca11b9451d035411b06dafd5.camel@cybertec.at> <20200904012149.GA13932@momjian.us> <20200904201224.GD6891@momjian.us> <663099.1601400389@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Tue, 29 Sep 2020 13:26:29 -0400" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0" Content-ID: <712875.1601403419.0@sss.pgh.pa.us> Date: Tue, 29 Sep 2020 14:18:58 -0400 Message-ID: <712970.1601403538@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk ------- =_aaaaaaaaaa0 Content-Type: text/plain; charset="us-ascii" Content-ID: <712875.1601403419.1@sss.pgh.pa.us> I wrote: > I think this is nuts. The current behavior is obviously broken; > we should just treat it as a bug and fix it, including back-patching. > I do not think there is a compatibility problem of any significance. > Who out there is going to have an application that is relying on the > ability to insert BC dates in this way? Concretely, I propose the attached. This adjusts Dar Alathar-Yemen's patch (it didn't do the right thing IMO for the combination of bc and year < 0) and adds test cases and docs. Oracle would have us throw an error for year zero, but our historical behavior has been to read it as 1 BC. That's not so obviously wrong that I'd want to change it in the back branches. Maybe it could be done as a follow-up change in HEAD. regards, tom lane ------- =_aaaaaaaaaa0 Content-Type: text/x-diff; name="fix-to-date-for-negative-years.patch"; charset="us-ascii" Content-ID: <712875.1601403419.2@sss.pgh.pa.us> Content-Description: fix-to-date-for-negative-years.patch Content-Transfer-Encoding: quoted-printable diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 62dd738230..ec8451d1b9 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -7678,6 +7678,15 @@ SELECT regexp_match('abc01234xyz', '(?:(.*?)(\d+)(.= *)){1,1}'); = + + + In to_timestamp and to_date, + negative years are treated as signifying BC. If you write both a + negative year and an explicit BC field, you get= AD + again. An input of year zero is treated as 1 BC. + + + In to_timestamp and to_date, diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/fo= rmatting.c index b91ff7bb80..3bb01cdb65 100644 --- a/src/backend/utils/adt/formatting.c +++ b/src/backend/utils/adt/formatting.c @@ -4569,8 +4569,11 @@ do_to_timestamp(text *date_txt, text *fmt, Oid coll= id, bool std, { /* If a 4-digit year is provided, we use that and ignore CC. */ tm->tm_year =3D tmfc.year; - if (tmfc.bc && tm->tm_year > 0) - tm->tm_year =3D -(tm->tm_year - 1); + if (tmfc.bc) + tm->tm_year =3D -tm->tm_year; + /* correct for our representation of BC years */ + if (tm->tm_year < 0) + tm->tm_year++; } fmask |=3D DTK_M(YEAR); } diff --git a/src/test/regress/expected/horology.out b/src/test/regress/exp= ected/horology.out index c8c33a0fc0..7f82dcfbfe 100644 --- a/src/test/regress/expected/horology.out +++ b/src/test/regress/expected/horology.out @@ -2916,6 +2916,45 @@ SELECT to_date('2458872', 'J'); 01-23-2020 (1 row) = +-- +-- Check handling of BC dates +-- +SELECT to_date('44-02-01 BC','YYYY-MM-DD BC'); + to_date = +--------------- + 02-01-0044 BC +(1 row) + +SELECT to_date('-44-02-01','YYYY-MM-DD'); + to_date = +--------------- + 02-01-0044 BC +(1 row) + +SELECT to_date('-44-02-01 BC','YYYY-MM-DD BC'); + to_date = +------------ + 02-01-0044 +(1 row) + +SELECT to_timestamp('44-02-01 11:12:13 BC','YYYY-MM-DD HH24:MI:SS BC'); + to_timestamp = +--------------------------------- + Fri Feb 01 11:12:13 0044 PST BC +(1 row) + +SELECT to_timestamp('-44-02-01 11:12:13','YYYY-MM-DD HH24:MI:SS'); + to_timestamp = +--------------------------------- + Fri Feb 01 11:12:13 0044 PST BC +(1 row) + +SELECT to_timestamp('-44-02-01 11:12:13 BC','YYYY-MM-DD HH24:MI:SS BC'); + to_timestamp = +------------------------------ + Mon Feb 01 11:12:13 0044 PST +(1 row) + -- -- Check handling of multiple spaces in format and/or input -- @@ -3183,6 +3222,12 @@ SELECT to_date('2016 366', 'YYYY DDD'); -- ok = SELECT to_date('2016 367', 'YYYY DDD'); ERROR: date/time field value out of range: "2016 367" +SELECT to_date('0000-02-01','YYYY-MM-DD'); -- allowed, though it shouldn= 't be + to_date = +--------------- + 02-01-0001 BC +(1 row) + -- -- Check behavior with SQL-style fixed-GMT-offset time zone (cf bug #8572= ) -- diff --git a/src/test/regress/sql/horology.sql b/src/test/regress/sql/horo= logy.sql index c464e6766c..fed21a53c8 100644 --- a/src/test/regress/sql/horology.sql +++ b/src/test/regress/sql/horology.sql @@ -426,6 +426,17 @@ SELECT to_date('1 4 1902', 'Q MM YYYY'); -- Q is ign= ored SELECT to_date('3 4 21 01', 'W MM CC YY'); SELECT to_date('2458872', 'J'); = +-- +-- Check handling of BC dates +-- + +SELECT to_date('44-02-01 BC','YYYY-MM-DD BC'); +SELECT to_date('-44-02-01','YYYY-MM-DD'); +SELECT to_date('-44-02-01 BC','YYYY-MM-DD BC'); +SELECT to_timestamp('44-02-01 11:12:13 BC','YYYY-MM-DD HH24:MI:SS BC'); +SELECT to_timestamp('-44-02-01 11:12:13','YYYY-MM-DD HH24:MI:SS'); +SELECT to_timestamp('-44-02-01 11:12:13 BC','YYYY-MM-DD HH24:MI:SS BC'); + -- -- Check handling of multiple spaces in format and/or input -- @@ -511,6 +522,7 @@ SELECT to_date('2015 366', 'YYYY DDD'); SELECT to_date('2016 365', 'YYYY DDD'); -- ok SELECT to_date('2016 366', 'YYYY DDD'); -- ok SELECT to_date('2016 367', 'YYYY DDD'); +SELECT to_date('0000-02-01','YYYY-MM-DD'); -- allowed, though it shouldn= 't be = -- -- Check behavior with SQL-style fixed-GMT-offset time zone (cf bug #8572= ) ------- =_aaaaaaaaaa0--