From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Nagaraj Raj <nagaraj.sf@yahoo.com>,
        Pg Bugs <pgsql-bugs@postgresql.org>
Subject: Re: ERROR: insufficient columns in the PRIMARY KEY constraint
 definition
In-reply-to: 
 <CAApHDvpE5omXqenT5wFLHigbJFjixqUC-DkcTw6aCFoMLmU2jw@mail.gmail.com>
References: <20200929223907.GA14950@alvherre.pgsql>
 <725317.1601419418@sss.pgh.pa.us>
 <CAApHDvrtVBHpFCSRP_KbYptX4LRv3LXthRPJQhfPKHouXvwauA@mail.gmail.com>
 <CAApHDvpE5omXqenT5wFLHigbJFjixqUC-DkcTw6aCFoMLmU2jw@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Wed, 30 Sep 2020 12:13:56 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <727063.1601421690.1@sss.pgh.pa.us>
Date: Tue, 29 Sep 2020 19:21:30 -0400
Message-ID: <727064.1601421690@sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> On Wed, 30 Sep 2020 at 12:08, David Rowley <dgrowleyml@gmail.com> wrote:
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> "Unique constraints (and[, by extension,] primary key constraints) on
>>> partitioned tables must include all the partition key columns.

> I didn't go with the same wording.  The reason was that I didn't feel
> the word "constraint" had to be mentioned twice.
> I won't object if you or Alvaro want to keep Alvaro's suggestion though.

I kind of like Alvaro's wording because it helps to reinforce the point
that pkeys are a type of unique constraint.  If you dislike repeating
"constraints", perhaps we could go with something like

Unique constraints (and hence primary keys) on partitioned tables ...

I'm not hugely against your wording though.

			regards, tom lane