Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xLPPN-00000001V3f-09Ln for pgsql-bugs@arkaria.postgresql.org; Mon, 26 Oct 2026 18:26:57 +0000 Received: from localhost ([127.0.0.1]:46336 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xLPPM-00000007FPJ-0fkc for pgsql-bugs@arkaria.postgresql.org; Mon, 26 Oct 2026 18:26:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:41482) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xLPPL-00000007FPB-3ofI for pgsql-bugs@lists.postgresql.org; Mon, 26 Oct 2026 18:26:55 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xLPPJ-000000016lB-2aEg for pgsql-bugs@lists.postgresql.org; Mon, 26 Oct 2026 18:26:55 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 69QIQYDB737424; Mon, 26 Oct 2026 14:26:34 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 sss.pgh.pa.us 69QIQYDB737424 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sss.pgh.pa.us; s=default; t=1793039194; bh=PkB8S7ToUTX+jPCWjPIhe23607WIBq3/719s9IX2Uak=; h=From:To:cc:Subject:In-reply-to:References:Date:From; b=XB0sv1HsEcDRaEDIfvEurcCOUJBKQhQGDFZdgM7iyV+H+E5SVItypCbT65DQWqC9e wm7OCM2S6RgCu8FSGW7BpXkN5SET9S1Cks23rz+WqNJzNaJYysiLeZcXyCgMwKMCxl ln3GhGn7FNAl6jGJ4m66N+UoffXID9fzi8IWkZWA= From: Tom Lane To: Staroverov Ilja cc: "pgsql-bugs@lists.postgresql.org" , "michael@paquier.xyz" Subject: Re: Query jumbling ignores XML names, ROLLUP/CUBE, VARIADIC and more In-reply-to: References: Comments: In-reply-to Staroverov Ilja message dated "Mon, 26 Oct 2026 10:45:40 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <737422.1793039194.1@sss.pgh.pa.us> Date: Mon, 26 Oct 2026 14:26:34 -0400 Message-ID: <737423.1793039194@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Staroverov Ilja writes: > While working on the SQL/JSON patterns in pg_stat_statements [1], I > looked at the other fields marked query_jumble_ignore, and some of them > change the results of the queries. I don't believe that query jumbles have ever been intended to distinguish every semantic detail of a query tree. To the contrary, merging together "sufficiently similar" queries has always been precisely the intention. So there is not one of these things that deserves the label of bug. We can have a discussion about whether the original (and clearly intentional) choice to mark a field as query_jumble_ignore was being too aggressive about what is "similar", but in each case that's going to be a judgment call. So rather than submitting a patch and expecting it to get pushed, you need to try to create some consensus on the -hackers list about whether these things should be changed. To my mind the benefit of the doubt should probably go to the existing behaviors. regards, tom lane