Subject: Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS
References: <20170621004237.GB8337@wolff.to>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Message-ID: <73b2a51a-3cf9-a44c-4cd0-bbc611016eb4@lab.ntt.co.jp>
Date: Wed, 21 Jun 2017 10:15:28 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20170621004237.GB8337@wolff.to>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To: Bruno Wolff III <bruno@wolff.to>, pgsql-bugs@postgresql.org
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

On 2017/06/21 9:42, Bruno Wolff III wrote:
> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF
> NOT EXISTS. Given this is new, maybe there is a bug in the parser.
> 
> Sample output:
> psql (10beta1)
> Type "help" for help.
> 
> o365logs=# select version();
>                                                 
> version                                                 
> --------------------------------------------------------------------------------
> 
> ----------------------------
> PostgreSQL 10beta1 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 4.8.5
> 20150623
> (Red Hat 4.8.5-11), 64-bit
> (1 row)
> 
> o365logs=# CREATE STATISTICS IF NOT EXISTS logs_corrtest (dependencies) ON
> record_type, operation FROM logs;
> ERROR:  syntax error at or near "NOT"
> LINE 1: CREATE STATISTICS IF NOT EXISTS logs_corrtest (dependencies)...

Looks like a documentation bug if the authors of the feature actually
meant to implement the following syntax:

  CREATE [ IF NOT EXISTS ] STATISTICS

create if not exists statistics words_stats on a, b from words;
CREATE STATISTICS

create if not exists statistics words_stats on a, b from words;
NOTICE:  statistics object "words_stats" already exists, skipping
CREATE STATISTICS

If that's really what's intended, it seems a bit inconsistent with most
other commands and with DROP STATISTICS [ IF NOT EXISTS ] itself.

Thanks,
Amit


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs