Content-Type: multipart/mixed; boundary="------------ABVCEeFcWBc0NTqzp2xCXUpN"
Message-ID: <74affb73-113e-0300-dc43-ea73535c23b9@gmail.com>
Date: Wed, 13 Mar 2024 11:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: BUG #18385: Assert("strategy_delta >= 0") in BgBufferSync() fails
 due to race condition
Content-Language: en-US
To: Tender Wang <tndrwang@gmail.com>
References: <18385-eaccb1d63684c704@postgresql.org>
 <CAHewXNmGmo7RPzZob+UL47rmujXAkEmwhHcYM+f8kye41SybJA@mail.gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
In-Reply-To: 
 <CAHewXNmGmo7RPzZob+UL47rmujXAkEmwhHcYM+f8kye41SybJA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/74affb73-113e-0300-dc43-ea73535c23b9%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------ABVCEeFcWBc0NTqzp2xCXUpN
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Tender Wang,

13.03.2024 09:50, Tender Wang wrote:
> Hi Alexander,
>    I haven't been able to reproduce this issue on my machine(2 vCPU, 2GB memory).
>
>  Can you reproduce this issue reliably on your machine?

Thanks for your attention to this issue!

On my 12-core workstation, where pgbench shows approximately 2500 tps,
`pgbench -t 10000 -c 40` failed on iterations 1, 1, 3:
...
number of transactions actually processed: 398639/400000
number of failed transactions: 0 (0.000%)
latency average = 15.931 ms
initial connection time = 56.806 ms
tps = 2510.845701 (without initial connection time)
pgbench: error: Run was aborted; the above results are incomplete.
...

The server built with gcc,
CPPFLAGS="-O0" ./configure --enable-debug --enable-cassert ...

I have also intensified bgwriter as follows:
          rc = WaitLatch(MyLatch,
                         WL_LATCH_SET | WL_TIMEOUT | WL_EXIT_ON_PM_DEATH,
-                       BgWriterDelay /* ms */ , WAIT_EVENT_BGWRITER_MAIN);
+                       1 /* ms */ , WAIT_EVENT_BGWRITER_MAIN);

That is, I have the attached modification applied and the following in my
extra.config:
fsync = off
autovacuum = off
shared_buffers = '1MB'

Best regards,
Alexander
--------------ABVCEeFcWBc0NTqzp2xCXUpN
Content-Type: text/x-patch; charset=UTF-8; name="debug-18385.patch"
Content-Disposition: attachment; filename="debug-18385.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvYmd3cml0ZXIuYyBiL3NyYy9i
YWNrZW5kL3Bvc3RtYXN0ZXIvYmd3cml0ZXIuYwppbmRleCBkYTJkOTViOTI2Li40ZGNiN2Nk
ZGQ3IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL2Jnd3JpdGVyLmMKKysr
IGIvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9iZ3dyaXRlci5jCkBAIC0yOTgsNyArMjk4LDcg
QEAgQmFja2dyb3VuZFdyaXRlck1haW4odm9pZCkKIAkJICovCiAJCXJjID0gV2FpdExhdGNo
KE15TGF0Y2gsCiAJCQkJCSAgIFdMX0xBVENIX1NFVCB8IFdMX1RJTUVPVVQgfCBXTF9FWElU
X09OX1BNX0RFQVRILAotCQkJCQkgICBCZ1dyaXRlckRlbGF5IC8qIG1zICovICwgV0FJVF9F
VkVOVF9CR1dSSVRFUl9NQUlOKTsKKwkJCQkJICAgMSAvKiBtcyAqLyAsIFdBSVRfRVZFTlRf
QkdXUklURVJfTUFJTik7CiAKIAkJLyoKIAkJICogSWYgbm8gbGF0Y2ggZXZlbnQgYW5kIEJn
QnVmZmVyU3luYyBzYXlzIG5vdGhpbmcncyBoYXBwZW5pbmcsIGV4dGVuZApkaWZmIC0tZ2l0
IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9idWZmZXIvZnJlZWxpc3QuYyBiL3NyYy9iYWNrZW5k
L3N0b3JhZ2UvYnVmZmVyL2ZyZWVsaXN0LmMKaW5kZXggMzYxMTM1N2ZhMy4uZWNmNzBhMDM2
YiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9idWZmZXIvZnJlZWxpc3QuYwor
KysgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2J1ZmZlci9mcmVlbGlzdC5jCkBAIC00MTUsNiAr
NDE1LDcgQEAgU3RyYXRlZ3lTeW5jU3RhcnQodWludDMyICpjb21wbGV0ZV9wYXNzZXMsIHVp
bnQzMiAqbnVtX2J1Zl9hbGxvYykKIAl7CiAJCSpudW1fYnVmX2FsbG9jID0gcGdfYXRvbWlj
X2V4Y2hhbmdlX3UzMigmU3RyYXRlZ3lDb250cm9sLT5udW1CdWZmZXJBbGxvY3MsIDApOwog
CX0KK3BnX3VzbGVlcCgzMDApOwogCVNwaW5Mb2NrUmVsZWFzZSgmU3RyYXRlZ3lDb250cm9s
LT5idWZmZXJfc3RyYXRlZ3lfbG9jayk7CiAJcmV0dXJuIHJlc3VsdDsKIH0K

--------------ABVCEeFcWBc0NTqzp2xCXUpN--