Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLX2h-0006Mg-8l for pgsql-bugs@arkaria.postgresql.org; Mon, 06 Apr 2020 19:04:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jLX2f-0003DO-Qb for pgsql-bugs@arkaria.postgresql.org; Mon, 06 Apr 2020 19:04:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLX2f-0003DE-KT; Mon, 06 Apr 2020 19:04:17 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLX2Z-0004J9-81; Mon, 06 Apr 2020 19:04:17 +0000 Received: from Davids-MacBook-Pro.local (c-73-39-102-148.hsd1.va.comcast.net [73.39.102.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id ED21854663; Mon, 6 Apr 2020 19:04:08 +0000 (UTC) Subject: Re: Don't try fetching future segment of a TLI. To: Fujii Masao , Pavel Suderevsky Cc: Kyotaro Horiguchi , pgsql-hackers@lists.postgresql.org, pgsql-bugs@lists.postgresql.org References: <16159-f5a34a3a04dc67e0@postgresql.org> <20191212.124856.202839248708529678.horikyota.ntt@gmail.com> <20200129.120222.1476610231001551715.horikyota.ntt@gmail.com> <8c831a30-a3a2-de89-2059-e7ce842d7aed@pgmasters.net> <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com> From: David Steele Message-ID: <762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net> Date: Mon, 6 Apr 2020 15:04:07 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 4/6/20 1:43 PM, Fujii Masao wrote: > > > On 2020/03/19 22:22, Pavel Suderevsky wrote: >> Hi, >> >> I've tested patch provided by Kyotaro and do confirm it fixes the issue. > > The patch looks good to me. Attached is the updated version of the patch. > I updated only comments. > > Barring any objection, I will commit this patch. The patch looks good to me. >> Any chance it will be merged to one of the next minor releases? > > This doesn't seem a bug, so I'm thinking to merge this to next *major* > version release, i.e., v13. Not a bug, perhaps, but I think we do consider back-patching performance problems. The rise in S3 usage has just exposed how poorly this performed code in high-latency environments. Regards, -- -David david@pgmasters.net