Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on
 composing an error message when adding a type to an extension being dropped)
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ranier Vilela <ranier.vf@gmail.com>,
 Laurenz Albe <laurenz.albe@cybertec.at>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <17098-b960f3616c861f83@postgresql.org>
 <2468663.1626017338@sss.pgh.pa.us> <2984422.1626110456@sss.pgh.pa.us>
 <dc29b1131b84bef879cf68d1d1edae07f51ca3d2.camel@cybertec.at>
 <3227956.1626186568@sss.pgh.pa.us>
 <CAEudQAq22dUhHp9ryKNOnro0HkQWiJE1F3g3VxHUFsqQ4ZkyeA@mail.gmail.com>
 <3280448.1626200778@sss.pgh.pa.us>
 <06a9ff0f-d1e9-0340-2f3b-180cefe41c7a@enterprisedb.com>
 <3517180.1626280000@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <768db26c-cf9a-6943-38b1-2d5ac8cc86f2@enterprisedb.com>
Date: Thu, 22 Jul 2021 08:20:28 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <3517180.1626280000@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/768db26c-cf9a-6943-38b1-2d5ac8cc86f2%40enterprisedb.com>
Precedence: bulk

On 14.07.21 18:26, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> In this particular case, I would for example be quite curious how those
>> alternative minimal C libraries such as musl-libc handle this.
> 
> Interesting question, so I took a look:
> 
> https://git.musl-libc.org/cgit/musl/tree/src/stdio/vfprintf.c#n593
> 
>                      case 's':
> 			a = arg.p ? arg.p : "(null)";
> 			...
> 
> Any others you'd like to consider?

Similar here: 
https://github.com/ensc/dietlibc/blob/master/lib/__v_printf.c#L188

I think unless we get counterexamples, this is all good.