Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfT7A-0006mv-Ee for pgsql-bugs@arkaria.postgresql.org; Fri, 04 Jan 2019 17:18:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gfT79-0007un-4d for pgsql-bugs@arkaria.postgresql.org; Fri, 04 Jan 2019 17:18:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfT78-0007ug-Ut for pgsql-bugs@lists.postgresql.org; Fri, 04 Jan 2019 17:18:30 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfT76-0002G8-Qt for pgsql-bugs@lists.postgresql.org; Fri, 04 Jan 2019 17:18:30 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x04HIO6d007800; Fri, 4 Jan 2019 12:18:25 -0500 From: Tom Lane To: Peter Eisentraut cc: feikesteenbergen@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15555: Syntax errors when using the COMMENT command in plpgsql and a "comment" variable In-reply-to: <52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com> References: <15555-149bbd70ddc7b4b6@postgresql.org> <31368.1545078376@sss.pgh.pa.us> <32114.1545079626@sss.pgh.pa.us> <23647.1545084358@sss.pgh.pa.us> <52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com> Comments: In-reply-to Peter Eisentraut message dated "Fri, 04 Jan 2019 15:09:48 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7798.1546622304.1@sss.pgh.pa.us> Date: Fri, 04 Jan 2019 12:18:24 -0500 Message-ID: <7799.1546622304@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Eisentraut writes: > On 17/12/2018 23:05, Tom Lane wrote: >> [ pokes at that for a bit ] The logic here is a bit denser than >> one could wish, but here's a draft patch that seems to get the >> job done. It passes check-world, which isn't conclusive but >> at least suggests that this doesn't break anything. > This looks good to me. I can't think of any other syntax scenarios that > it needs to address. Pushed, thanks for checking! regards, tom lane