Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6a2V-0000eV-Dv for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Jul 2021 14:51:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m6a1x-000175-4Y for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Jul 2021 14:50:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6a1w-00016w-PE for pgsql-bugs@lists.postgresql.org; Thu, 22 Jul 2021 14:50:32 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6a1m-0000fg-J9 for pgsql-bugs@lists.postgresql.org; Thu, 22 Jul 2021 14:50:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 16MEoIpo781666; Thu, 22 Jul 2021 10:50:18 -0400 From: Tom Lane To: David Rowley cc: cyg0810@gmail.com, PostgreSQL mailing lists Subject: Re: BUG #17117: FailedAssertion at planner.c In-reply-to: References: <17117-e7ed6c3108953c08@postgresql.org> Comments: In-reply-to David Rowley message dated "Fri, 23 Jul 2021 01:58:50 +1200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <781664.1626965418.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Jul 2021 10:50:18 -0400 Message-ID: <781665.1626965418@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk David Rowley writes: > On Fri, 23 Jul 2021 at 00:28, David Rowley wrote= : >> I'm unsure if parse->hasModifyingCTE is not being set properly and >> that's causing PlannerGlobal.parallelModeOK to be set incorrectly in >> standard_planner or if we should just be never setting anything to >> parallelModeOK that's not parse->querySource =3D=3D QSRC_ORIGINAL. > I think the hasModifyingCTE going missing is the problem here. I think this is a dup of the ongoing discussion at https://www.postgresql.org/message-id/flat/CAJcOf-fAdj=3DnDKMsRhQzndm-O13N= Y4dL6xGcEvdX5Xvbbi0V7g@mail.gmail.com The thing that's stalled that discussion is disagreement over whether it's necessary to make a bigger change than what you have here. regards, tom lane