MIME-Version: 1.0
Date: Fri, 21 Feb 2025 11:57:54 +0700
From: Vladlen Popolitov <v.popolitov@postgrespro.ru>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Subject: Re: Error in form on site commitfest.postgresql.org
In-Reply-To: <7CFA9589-F307-4EDB-9F5D-E21E76C05D50@yesql.se>
References: <ff6853183ac7d25acf2451d5eea7f6a5@postgrespro.ru>
 <7CFA9589-F307-4EDB-9F5D-E21E76C05D50@yesql.se>
Message-ID: <78c6b9661e1f88988b9b4fcd29b42751@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/78c6b9661e1f88988b9b4fcd29b42751%40postgrespro.ru>
Precedence: bulk

Hi!

I have included the solution into the body of the email.
Should I send some patch to the git of the sites source code?


I did not find any advice to fix www pages except sending
email to this mailing list. I hope it will work later or
ealier.


Daniel Gustafsson писал(а) 2025-02-13 21:41:
> I am moving this to pgsql-www@ where the project websites are 
> discussed,
> removing pgsql-bugs@ to avoid getting caught in cross-post moderation.
> 
>> On 13 Feb 2025, at 13:46, Vladlen Popolitov 
>> <v.popolitov@postgrespro.ru> wrote:
>> 
>> 
>> Hi!
>> 
>> I do not know, who supports commitfest site, it why I am writing here.
>> 
>> Every time I add my review in commit fest, I see wrong form -
>> not all field in form are visible, see attached picture.
>> As result review generate wrong misleading text, that tests are 
>> failed,
>> like this from my last review:
>> The following review has been posted through the commitfest 
>> application:
>> make installcheck-world:  tested, failed
>> Implements feature:       tested, failed
>> Spec compliant:           tested, failed
>> Documentation:            tested, failed
>> 
>> I tried Safari, Chrome on Mac, Chrome, Edge and Explorer on Windows -
>> the same result.
>> 
>> The reason: the field "Passed" under field "Tested" is not visible.
>> I suppose the problem in bootstrap classes. I tried to change them to
>> documented classes from Bootstrap 3 (as referenced in this page),
>> and form works.
>> 

The solution.

>> 
>> If change the :
>> <div id="id_review_installcheck" class="form-control"><div>
>> to
>> <div id="id_review_installcheck" class="container pull-left"><div>
>> 
>> <div id="id_review_implements" class="form-control"><div>
>> to
>> <div id="id_review_implements" class="container  pull-left"><div>
>> 
>> <div id="id_review_spec" class="form-control"><div>
>> to
>> <div id="id_review_spec" class="container pull-left"><div>
>> 
>> <div id="id_review_doc" class="form-control"><div>
>> to
>> <div id="id_review_doc" class="container pull-left"><div>
>> 
>> And all checkbook should be changed from
>> <input type="checkbox" name="review_installcheck" value="0"
>> class="form-control" id="id_review_installcheck_0">
>> to
>> <input type="checkbox" name="review_installcheck" value="0"
>> class="form-check-input" id="id_review_installcheck_0">
>> 
>> for better presentation.
>> 
>> 
>> In this case all fields will be visible.
>> 
>> --
>> Best regards,
>> 
>> Vladlen Popolitov.
> 
> 
> --
> Daniel Gustafsson

-- 
Best regards,

Vladlen Popolitov.