Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLVmB-0002jQ-RN for pgsql-bugs@arkaria.postgresql.org; Mon, 06 Apr 2020 17:43:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jLVmA-0007kY-1n for pgsql-bugs@arkaria.postgresql.org; Mon, 06 Apr 2020 17:43:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLVm9-0007kO-Rg; Mon, 06 Apr 2020 17:43:09 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLVm6-0001kt-Hs; Mon, 06 Apr 2020 17:43:08 +0000 Received: from hnk.local (p2421237-ipbf2725funabasi.chiba.ocn.ne.jp [122.24.33.237]) by oss.nttdata.com (Postfix) with ESMTPSA id 7657D602FB; Tue, 7 Apr 2020 02:43:02 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: Don't try fetching future segment of a TLI. To: Pavel Suderevsky , David Steele Cc: Kyotaro Horiguchi , pgsql-hackers@lists.postgresql.org, pgsql-bugs@lists.postgresql.org References: <16159-f5a34a3a04dc67e0@postgresql.org> <20191212.124856.202839248708529678.horikyota.ntt@gmail.com> <20200129.120222.1476610231001551715.horikyota.ntt@gmail.com> <8c831a30-a3a2-de89-2059-e7ce842d7aed@pgmasters.net> From: Fujii Masao Message-ID: <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com> Date: Tue, 7 Apr 2020 02:43:02 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------DBC0753037B99F8BBE15ED01" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------DBC0753037B99F8BBE15ED01 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2020/03/19 22:22, Pavel Suderevsky wrote: > Hi, > > I've tested patch provided by Kyotaro and do confirm it fixes the issue. The patch looks good to me. Attached is the updated version of the patch. I updated only comments. Barring any objection, I will commit this patch. > Any chance it will be merged to one of the next minor releases? This doesn't seem a bug, so I'm thinking to merge this to next *major* version release, i.e., v13. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------DBC0753037B99F8BBE15ED01 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="v2-0001-Don-t-try-fetching-out-of-timeline-segments.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="v2-0001-Don-t-try-fetching-out-of-timeline-segments.patch" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cuYyBiL3NyYy9i YWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cuYwppbmRleCBhYmY5NTRiYTM5Li5kMzUwOTRh MGNiIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMKKysr IGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZy5jCkBAIC0zNzc2LDExICszNzc2 LDM2IEBAIFhMb2dGaWxlUmVhZEFueVRMSShYTG9nU2VnTm8gc2Vnbm8sIGludCBlbW9kZSwg WExvZ1NvdXJjZSBzb3VyY2UpCiAKIAlmb3JlYWNoKGNlbGwsIHRsZXMpCiAJewotCQlUaW1l TGluZUlECXRsaSA9ICgoVGltZUxpbmVIaXN0b3J5RW50cnkgKikgbGZpcnN0KGNlbGwpKS0+ dGxpOworCQlUaW1lTGluZUhpc3RvcnlFbnRyeSAqaGVudCA9IChUaW1lTGluZUhpc3RvcnlF bnRyeSAqKSBsZmlyc3QoY2VsbCk7CisJCVRpbWVMaW5lSUQJdGxpID0gaGVudC0+dGxpOwog CiAJCWlmICh0bGkgPCBjdXJGaWxlVExJKQogCQkJYnJlYWs7CQkJCS8qIGRvbid0IGJvdGhl ciBsb29raW5nIGF0IHRvby1vbGQgVExJcyAqLwogCisJCS8qCisJCSAqIFNraXAgc2Nhbm5p bmcgdGhlIHRpbWVsaW5lIElEIHRoYXQgdGhlIGxvZ2ZpbGUgc2VnbWVudCB0byByZWFkCisJ CSAqIGRvZXNuJ3QgYmVsb25nIHRvCisJCSAqLworCQlpZiAoaGVudC0+YmVnaW4gIT0gSW52 YWxpZFhMb2dSZWNQdHIpCisJCXsKKwkJCVhMb2dTZWdObwliZWdpbnNlZyA9IDA7CisKKwkJ CVhMQnl0ZVRvU2VnKGhlbnQtPmJlZ2luLCBiZWdpbnNlZywgd2FsX3NlZ21lbnRfc2l6ZSk7 CisKKwkJCS8qCisJCQkgKiBUaGUgbG9nZmlsZSBzZWdtZW50IHRoYXQgZG9lc24ndCBiZWxv bmcgdG8gdGhlIHRpbWVsaW5lIGlzCisJCQkgKiBvbGRlciBvciBuZXdlciB0aGFuIHRoZSBz ZWdtZW50IHRoYXQgdGhlIHRpbWVsaW5lIHN0YXJ0ZWQgb3IKKwkJCSAqIGVuZWRlZCBhdCwg cmVzcGVjdGl2ZWx5LiBJdCdzIHN1ZmZpY2llbnQgdG8gY2hlY2sgb25seSB0aGUKKwkJCSAq IHN0YXJ0aW5nIHNlZ21lbnQgb2YgdGhlIHRpbWVsaW5lIGhlcmUuIFNpbmNlIHRoZSB0aW1l bGluZXMgYXJlCisJCQkgKiBzY2FubmVkIGluIGRlc2NlbmRpbmcgb3JkZXIgaW4gdGhpcyBs b29wLCBhbnkgc2VnbWVudHMgbmV3ZXIKKwkJCSAqIHRoYW4gdGhlIGVuZGluZyBzZWdtZW50 IHNob3VsZCBiZWxvbmcgdG8gbmV3ZXIgdGltZWxpbmUgYW5kCisJCQkgKiBoYXZlIGFscmVh ZHkgYmVlbiByZWFkIGJlZm9yZS4gU28gaXQncyBub3QgbmVjZXNzYXJ5IHRvIGNoZWNrCisJ CQkgKiB0aGUgZW5kaW5nIHNlZ21lbnQgb2YgdGhlIHRpbWVsaW5lIGhlcmUuCisJCQkgKi8K KwkJCWlmIChzZWdubyA8IGJlZ2luc2VnKQorCQkJCWNvbnRpbnVlOworCQl9CisKIAkJaWYg KHNvdXJjZSA9PSBYTE9HX0ZST01fQU5ZIHx8IHNvdXJjZSA9PSBYTE9HX0ZST01fQVJDSElW RSkKIAkJewogCQkJZmQgPSBYTG9nRmlsZVJlYWQoc2Vnbm8sIGVtb2RlLCB0bGksCg== --------------DBC0753037B99F8BBE15ED01--